From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B4FC432BE for ; Sun, 29 Aug 2021 12:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E67260698 for ; Sun, 29 Aug 2021 12:48:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235332AbhH2MtD (ORCPT ); Sun, 29 Aug 2021 08:49:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235124AbhH2MtC (ORCPT ); Sun, 29 Aug 2021 08:49:02 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E19C061575 for ; Sun, 29 Aug 2021 05:48:10 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id t19so24752765ejr.8 for ; Sun, 29 Aug 2021 05:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fx2U/XtzQdPMmzz3ViClmHkgP7ZRkumubzXlcaMQAgc=; b=H7J+kJ0FaROaSAEynu14/HHVZ7CW4MZShaUQBSZW+7FzWI/CNBHzVd1d4LJS05zrT6 QuJEJzHHbycc3CirYzrYyEIcJwA5oTcenjy+6lSvA8/X5LuLGiifCkJzQojiAuSIp+NC vUtR5o9YfDl4fU4U66GGLb8ukikmRFaSESPZaUhusSJWtYFQqJZ+NanVpb1bGrAjMaWt th/5+7jm3DxXGsrdkW5NOipxUWdbB/R7FM2QvecvM+QgUjArRWxMmCTGejJCNvZZOBFv d1/mfVDcf8M/UWr5R7uO2rAPvUI/IYIHaM0ya3P6q2GajyXOAG27CDIaMFifVoppyk53 UZow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fx2U/XtzQdPMmzz3ViClmHkgP7ZRkumubzXlcaMQAgc=; b=FSfZYBCgnM58QA80VZT+d9y5LBPxGHLJ5qK2srEvmXoDvzJEFQ/u/ev/Q5em36C1lE JDR8O6OXuv9TWlbaDYI/HEFGWGGBWye7vJiKX132BNmC+XyCdIQPpLchzEIMvPUmxvFG 9wUWuc2JxHSTwqVzZHY7doJjg8AzEvyiEL4pwIXlU7x41+dQXy2Yu3wBMCKEF2aA8KIZ p13sLwMmIkICEMnP8uHUAPCIrX8M1H6dqEtYZ7ESD8lhDz+JwGK+qDG85Vp/x8KRs2y9 XbgNAmxaUBMOcxaXxaSmw03zUMvIRPww16R9ibMpW4vUbd/4t+YGO295gMqY8PXhrH7s RqJA== X-Gm-Message-State: AOAM5339GoVv5gc1XiZGItMHfTYe5M1R1HqJu2xTSsKaGi9ed3d2cpST hHvSw7nzn28IIP2al3QRMJm6bami++U1+w== X-Google-Smtp-Source: ABdhPJyQXKQ2ht5+zMqKD0ywC/NdJXwdMwtgrwZPoAVAoOQhRvOxBQyX7Sk38fQnW9SmT48k3JjPBA== X-Received: by 2002:a17:906:3ed2:: with SMTP id d18mr19158501ejj.311.1630241288257; Sun, 29 Aug 2021 05:48:08 -0700 (PDT) Received: from ?IPV6:2a02:8108:96c0:3b88::16fa? ([2a02:8108:96c0:3b88::16fa]) by smtp.gmail.com with UTF8SMTPSA id i19sm6091154edx.54.2021.08.29.05.48.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Aug 2021 05:48:07 -0700 (PDT) Message-ID: <67d0244b-03d8-7775-8384-88a25b17769e@gmail.com> Date: Sun, 29 Aug 2021 14:48:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect Content-Language: en-US To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: From: Michael Straube In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/21 11:01, Saurav Girepunje wrote: > Remove the condition with no effect (if == else) and group multiple > cases which execute same statement in rtw_mlme_ext.c > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > index 5a472a4954b0..4178b3c1ff57 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > @@ -453,17 +453,8 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame) > fallthrough; > case WIFI_ASSOCREQ: > case WIFI_REASSOCREQ: > - _mgt_dispatcher(padapter, ptable, precv_frame); > - break; > case WIFI_PROBEREQ: > - if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) > - _mgt_dispatcher(padapter, ptable, precv_frame); > - else > - _mgt_dispatcher(padapter, ptable, precv_frame); > - break; > case WIFI_BEACON: > - _mgt_dispatcher(padapter, ptable, precv_frame); > - break; > case WIFI_ACTION: > _mgt_dispatcher(padapter, ptable, precv_frame); > break; > -- > 2.32.0 > Acked-by: Michael Straube Thanks, Michael