From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbdK3PAe (ORCPT ); Thu, 30 Nov 2017 10:00:34 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:38472 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdK3PAc (ORCPT ); Thu, 30 Nov 2017 10:00:32 -0500 Reply-To: shuah@kernel.org Subject: Re: [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather To: Yuyang Du , valentina.manea.m@gmail.com Cc: gregkh@linuxfoundation.org, k.opasiak@samsung.com, kstewart@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, juan.zea@qindel.com, Shuah Khan , Shuah Khan References: <1512008560-28594-1-git-send-email-yuyang.du@intel.com> From: Shuah Khan Message-ID: <67d4e73f-28a3-27c6-064b-6a471a89661c@kernel.org> Date: Thu, 30 Nov 2017 08:00:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1512008560-28594-1-git-send-email-yuyang.du@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2017 07:22 PM, Yuyang Du wrote: > The previous USB3 SuperSpeed enabling patches mistakenly enabled > URB scatter-gather chaining, which is actually not supported by > the VHCI HCD. This patch fixes that. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197867 > Fixes: 03cd00d538a6feb ("usbip: vhci-hcd: Set the vhci structure up to work") > Reported-by: Juan Zea > Signed-off-by: Yuyang Du > --- > drivers/usb/usbip/vhci_hcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c > index 713e941..6b3278c 100644 > --- a/drivers/usb/usbip/vhci_hcd.c > +++ b/drivers/usb/usbip/vhci_hcd.c > @@ -1098,7 +1098,6 @@ static int hcd_name_to_id(const char *name) > static int vhci_setup(struct usb_hcd *hcd) > { > struct vhci *vhci = *((void **)dev_get_platdata(hcd->self.controller)); > - hcd->self.sg_tablesize = ~0; > if (usb_hcd_is_primary_hcd(hcd)) { > vhci->vhci_hcd_hs = hcd_to_vhci_hcd(hcd); > vhci->vhci_hcd_hs->vhci = vhci; > This need to go into stable as well. It applies to 4.14 Acked-by: Shuah Khan thanks, -- Shuah