From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751013AbdAWDdF (ORCPT <rfc822;w@1wt.eu>);
        Sun, 22 Jan 2017 22:33:05 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:33674 "EHLO
        szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750975AbdAWDdE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 22 Jan 2017 22:33:04 -0500
Subject: Re: [PATCH] mm: extend zero pages to same element pages for zram
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
References: <1483692145-75357-1-git-send-email-zhouxianrong@huawei.com>
 <1484296195-99771-1-git-send-email-zhouxianrong@huawei.com>
 <20170121084338.GA405@jagdpanzerIV.localdomain>
 <84073d07-6939-b22d-8bda-4fa2a9127555@huawei.com>
 <20170123025826.GA24581@js1304-P5Q-DELUXE>
CC: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <sergey.senozhatsky@gmail.com>,
        <minchan@kernel.org>, <ngupta@vflare.org>, <Mi.Sophia.Wang@huawei.com>,
        <zhouxiyu@huawei.com>, <weidu.du@huawei.com>,
        <zhangshiming5@huawei.com>, <won.ho.park@huawei.com>
From: zhouxianrong <zhouxianrong@huawei.com>
Message-ID: <67d60a22-b09f-cea4-eeb0-0c8bb02a315d@huawei.com>
Date: Mon, 23 Jan 2017 11:32:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20170123025826.GA24581@js1304-P5Q-DELUXE>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.145.228]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

hey Joonsoo:
	i would test and give the same element type later.

On 2017/1/23 10:58, Joonsoo Kim wrote:
> Hello,
>
> On Sun, Jan 22, 2017 at 10:58:38AM +0800, zhouxianrong wrote:
>> 1. memset is just set a int value but i want to set a long value.
>
> Sorry for late review.
>
> Do we really need to set a long value? I cannot believe that
> long value is repeated in the page. Value repeatition is
> usually done by value 0 or 1 and it's enough to use int. And, I heard
> that value 0 or 1 is repeated in Android. Could you check the distribution
> of the value in the same page?
>
> Thanks.
>
>
> .
>