From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F59E3F4DE2 for ; Thu, 11 Jun 2026 12:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781179222; cv=none; b=cBqd8bBgoAva0KrI2ryqqYejjj+9/VHkfK5XwqNSKViyzQTC1JGqWScOajhB1SO9r6ACA7uuZB2rgc+rC++dhfKjak6+XRBDU+SwomAwAO1m3FfS3wCdMSdfRtVHmBthPGGZXBi+pedZGSKOk7Q4m51pTktE7w/syh9eX9XsrS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781179222; c=relaxed/simple; bh=mfwra88telGHmlK8pwk/qUqf4z2Dpnxn0DRxiXNQG+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZHG24DR6rkq3l8iwk0MIpXMAX93ls2/8+3ez1vi/1iRGGePwYUxnSMik3VFmPnX5S2XG4eBFMw/cCe4JIhbyCUvimz8wGzdhQyUd3S2BZWBsJtbAQBGV17MwasoJudKTkontVgVjnqSiolV2TxKwbZobnprIUu0XTkduPEJyJk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UjPsErVi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IftUlu+J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UjPsErVi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IftUlu+J" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BA1nDL271404 for ; Thu, 11 Jun 2026 12:00:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JzeBJn8FIGue9gwzl3iuXpkwL3cazzGEmpclsocTaAE=; b=UjPsErViRphn8y8O JS2I0WSC4C5ooDIbTf6q/ZBSj70ciUN9zgW6fhpNcu9dMt+s2hMPoTurw1WnwaE7 FT/VYDye+nt0Q3IC2mBVcvsFgY16Dg8oRGfFGnDTTpgl8Gdeb6v4BSWHeXOWVhTH Qm0pDB22qazQbSvOnFsDY0l2YehhJRlQ6G17Kin5RUIon4VgZOiqpjLRa14OvqcW sG+OJpg40JR6i36tFZ2zwMMzJpKWGybbXBA5bKKYi0xDLLzwyH8hEaqJwRg0Nohh 6/tqDErtbWqHAYEkMUevV2urNcCTp7dXyZX8aBFQzW+7xN/RRqzjjAAit/dU/oI+ gg9G0g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe71kbh1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 12:00:20 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5175bf22b2bso14849871cf.2 for ; Thu, 11 Jun 2026 05:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781179219; x=1781784019; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JzeBJn8FIGue9gwzl3iuXpkwL3cazzGEmpclsocTaAE=; b=IftUlu+JtUYW+OKgjlxs6w4CNnf/qXpHb+SzGjzxxujPcr9W20tBp2V7/4OfZQdf1r o5wPSEdnIyvwTr1ZVBcn+DjdYjdEp7mz5tjoVUTE5cidKzPOmDnQZ2O3iOPAhEnmDhVy eS/93plwL/tqbmTzSE2Dg/koBKlz04c0NNkYAj+IZkprnXYsDMwQp3Tr0gyVqOr7+1aB iJJn/QHMLinzlcrT+7V/og/9ZcoxMfSDswPF73cAYtkwp3ltClraE11M5FJUIq+y/TRp 8TqoIDaiVtnm6CPBdOg0lSKShBZzrOZDELtl7bMAqH28FwelGgh7gNSE5ODGnA3jOIO6 eqMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781179219; x=1781784019; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JzeBJn8FIGue9gwzl3iuXpkwL3cazzGEmpclsocTaAE=; b=Bcr+zS7uBmw+v1VjiTT5d+IiPS8qyDV1wnGIEJ3LOn1eSrq9ZIq01TdL+Ud4uAGIFT 0eWIOuYiOwewbENFI6z+CJL+Tjyp5wfQyv2PhfLXmT/JirBrbn57YGFLuQkbMqUGkiWL 1kj8tzjRJD3zJb9VoSdOUAgpO9NOVW7p9l9zy4Lcv5SILBMTpKCNxnRLQWnWYbaspwWw CyoAhON1TtjStcudMZpnGMCopuecyVrcC+tM6YMzQfcFwAQ/SikYvQn1N5fSHesD/w9s igiBDQ3I660HZxL1clTq6rbhzpLYNPMfRO4xqStuqJTRxy1cHu3ZD5FFCMeA4zNoc4Ai r1Xw== X-Forwarded-Encrypted: i=1; AFNElJ8stmfjBGHN7MCSLeMOVxV16/o24jic4MMR2vf9fMRxdwMGi8teMNUPwgZHvky71YrGgzYgHVwalfdW79w=@vger.kernel.org X-Gm-Message-State: AOJu0YwsCZT12sRbaHTl6Be5SWX4hWTvLx26WKSVkQaWYs9RP0h1sKtL St4K2bz/aaoe2mX4uYLmPaXP6f22lkAafCN4eBYhUnMCz0eReOKdXVRKVTWRIk/IDaPurNK4NWj GNcgxYet9h3dIH34ySHvwGz8gbrLnewIqThsKQI15b37Sy86c1BJVtY4HlAvNhYaeuHA= X-Gm-Gg: Acq92OE5cQ9PFXCVvaEXRYOlcd2B9L6tUy5OBSk0Qjp1J3e5o0G0OzhAM2VgUY+lm5x kQ5KKP5L1gL8jV0HshHfSW8LZjyPoZ0PUqrX5EQGbRrrsD5pDCoEynlNqrRPoD7S6Gddm1iVibg MZ7/wUXopgoLWz5OaiP8D1c26mMwKYJsdveRBKnOCVUOiTsQalORIo7SUmIfy5Bo3VPtB6RoMm/ FQgONk9pT82EO2pIJNIVbLZmWW9gGaD5iTC9ftcC0lwXjCaXPkk1UXrS7sRATKij+rNHsbzhG2t c6mhyI7boqW4XgwuzqRa1/fWiqUCCh008jxnTWcAGgqynGKo4Ok2BIm9cBUzMv8r7PDg5xKJ2Zz VeTeEyUfClWQ3JoMzGwQnp93yaKM4wY/QvIkZOTQfMAxlnPNowLZmqf4d X-Received: by 2002:a05:622a:4287:b0:50e:6311:7380 with SMTP id d75a77b69052e-517ee3c76f6mr22740261cf.6.1781179219287; Thu, 11 Jun 2026 05:00:19 -0700 (PDT) X-Received: by 2002:a05:622a:4287:b0:50e:6311:7380 with SMTP id d75a77b69052e-517ee3c76f6mr22739371cf.6.1781179218495; Thu, 11 Jun 2026 05:00:18 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfcb0f14cbdsm55083266b.2.2026.06.11.05.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 05:00:17 -0700 (PDT) Message-ID: <67d7280f-54e5-4e16-931c-92049bee3e00@oss.qualcomm.com> Date: Thu, 11 Jun 2026 14:00:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] clk: qcom: Add EVA clock controller driver for Glymur SoC To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260526-evacc_glymur-v1-0-b61c7755c403@oss.qualcomm.com> <20260526-evacc_glymur-v1-3-b61c7755c403@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260526-evacc_glymur-v1-3-b61c7755c403@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Rwo9IyNQn63MUPlufhllyDFAiuMSoVsf X-Proofpoint-GUID: Rwo9IyNQn63MUPlufhllyDFAiuMSoVsf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDEyMCBTYWx0ZWRfX/1e6g3/OfYiX HTZDb2ctsx5FX51JNoTvbLkzoExwH6BK6f+lJQMz7d/MTfROuphA8dCKKKop6UFfpdBkg3rxa6I iB7tfmo5PpnhCuEZqvg5xds1q3DRjZtT7kE9U2G7BepW1ZMsQL7VeKeb8AwS4F63p5kScYghbg8 C2FtXBb9dInkwJmC8FZhM4Vz+RtV/U+hvNEftxbT3aRt2gVZWU91LCjFKPwUk5ktcik+OuwkvJ1 0mvHS6igmXAoEOwpAdWGlM1du7dv1CO47ngVy2zLqY30Jr+ptpuSyrhPdIJ1O6L88C5hgRTkEQn 1qQmurP/mPFIRFKJn4UDjKNa1UJpsZ4EhBS7dorbY2Cze0SVyF8uoQjH/QoogafSUr76cXpP11T FUZzoh6yUlvBg5nwJL2CFSOlxQg+G3GrSxTqajaP11vgffNqzwf1bx0D0+0yk9Yl8h7tNw++ims 2W8mpMqJ0pC2d0xVXtw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDEyMCBTYWx0ZWRfX3OQQOvqBELQJ sKeoh2021UEUtLad+OgbBZFn+C53ETBllIzQHyHYS8VlQFA6LBbPFvpijul7Wn9jbo3HUV7REtL GdY39SIbkmmUwTOMyyv9wOuN9ytQqJA= X-Authority-Analysis: v=2.4 cv=Lf0MLDfi c=1 sm=1 tr=0 ts=6a2aa354 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KhKKGY6azsjSgFTL2HwA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110120 On 5/26/26 7:29 AM, Taniya Das wrote: > Add the Enhanced Video Analytics (EVA) clock controller driver for > the Glymur SoC. The EVACC manages the PLL, RCGs, branch clocks, GDSCs > and resets for the EVA subsystem which handles vision processing > workloads. > > Signed-off-by: Taniya Das > --- [...] > +enum { > + DT_AHB_CLK, > + DT_BI_TCXO, > + DT_BI_TCXO_AO, DT_BI_TCXO_AO is unused, will it ever be? [...] > +static void clk_glymur_regs_configure(struct device *dev, struct regmap *regmap) > +{ > + /* Update CTRL_IN register */ Is there any better comment we could share here? > + regmap_update_bits(regmap, 0x9f24, BIT(0), BIT(0)); regmap_set_bits() otherwise lgtm Konrad