From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10C2924CEF8 for ; Thu, 3 Apr 2025 15:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743693681; cv=none; b=kzu/UpuN7GGz7MaWxkACsy0KWF5vf4+ZZW/V14setCp4CRCJrkfZwmF6LbpfCKIRlOwVZgrWUVOYxGHfzKM8QVegwVwtCCyG7Qlz/Ecg8zNsKDmyw9/6HMj93mCFZi5eXhaYQvd3yquoPXzfQ4cwDSBzpyRLhcqQc/eemuEzers= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743693681; c=relaxed/simple; bh=7BYAU7FWqgp7VAH8vNjlWZeSog6QTqHnJvWr0crzcfg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l8vwm3Hbtxa7N7MOgEi3VAwxFd6OC7m9+CokXHdJphiAkPyBPt65VNdv4aJOK+vreIYF1KGGe21jOny8GPqClXbLo1jV1NGQ1IEzjMzoCLOBwHzj8AQIrsXL0rq72Fr4OP9pYwBhX8mNeIZz3ZPzUry1FWa7iRlmmNPWORA/XFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AhroqBEX; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AhroqBEX" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43ce70f9afbso10734215e9.0 for ; Thu, 03 Apr 2025 08:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743693678; x=1744298478; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LLzRxbLbGYqFEY7hyGVV9DDJqGfYqDcrqrelLGxLjeg=; b=AhroqBEXbCFTlHKBfAgoMN0g5OWIMnoaPsVMASuHluxkFNWXLBthuR1n8IGtRLzwmQ IYZl6Aex2c1DIvMtdWdYNMyegFPg0r6llYdXu2TuUba5pstb5B5lIdWcPWI51ydVG3qm YwrcMNWiX0wKD3UqfpbZwm7tXG573ZrEpQWOzgu6b8qIHdOGfynIjgC0G5cD0QwfVrsg yifvAude2NCcnH3FYyq+TeI1ipIfSZk2plZr8qyPg6rZFTWGYRbjK5HEmPqBu9pzwUhx HvDDl/Ah6KgmQlkDpEag+86mZKjisQ1CG5OD5ClW58q80y2sA4+x8HEOzwjEo3ZJoAt3 PIvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743693678; x=1744298478; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LLzRxbLbGYqFEY7hyGVV9DDJqGfYqDcrqrelLGxLjeg=; b=S8DApI7ztyXq7izrwk6fhlHHUCIWoHgAIwjWNd6qoGwKlER54eolBmaBJVibgUDSGc uFpqRKdgJlhTpcB4/8vdwdNyJ/u0bJY3oSlxPbAOmfcTi9nw3AuPN/P3TxgsxL6fM3jK ixhopCasedx80UsXfrPROoFTXdiuH/Z52w1BfJuxFtokOK/mP6SJBoPkw1+pIe/V5Nib d3K16hrJ/Er23zTXpZAoCehYwfVNfNMIGDxKVmKy5LmOZEnUtp9u71pzjgoSTrPZIdVL 3NzFqOXFWLDN0WfdR+NHb9pKsh0iWz4GHF/Mi7wNT1wtrgqUA/Vo+ElmXw24Zjh4oxFG v5Jw== X-Gm-Message-State: AOJu0Yw9R00rKpUia2DDbnwNuECAiEBSNtfnb9oFYfkRmPzJY9EMMp5y aJKQQNmQ9b6EAKdDw2mhYDfLJ0atD4meB6MYj559cNrlBYy5y4xHw3azh/fRmI8= X-Gm-Gg: ASbGncsisgaYBKVhlRcYjhd5Lhdi0MljBKuFIkUIp+x0Ian8FD3sThrYxRo5lJAIw5k xf1VBat0SySYNbOtSC8lTsTRY2dx+wSHakr2ACGfpQITMkJl8qrxuINs9zj6zQBU7blFd8Wxkir mFqbjDZyop4lg05snPplEHEyMFjr85W0EwNjFdhpHql4zyqhHC39t1MyE+B9sYR943CDSHfFKaK y1okdbVrZTIlhn9xgtzwjwtMySLBhuRbdEvZhKgSgzDlQHeX7iDGksqk/4oc3hKKjJTyYcWdOAk TjTHX+XQIQiLRN5OHBC0M1hvRqvCa4PnILVoNATodp9oCVQHqKEYUOqCzhBMCpPwBV6fMBdpQpw Z1r5BzbaU X-Google-Smtp-Source: AGHT+IGw5ghzd9cHyGdFKWQ5WVPa7dVeNteHj1/e+hjpE89/v7AeOKF8SPeYMkbL/YLt+h17xVXsbA== X-Received: by 2002:a5d:5c84:0:b0:39c:1efd:ed8f with SMTP id ffacd0b85a97d-39c1efdedbemr11060254f8f.50.1743693678287; Thu, 03 Apr 2025 08:21:18 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43ec34bbd9csm21302405e9.20.2025.04.03.08.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Apr 2025 08:21:17 -0700 (PDT) Message-ID: <67daf656-0e08-471d-afce-22ba8f2fa1f2@linaro.org> Date: Thu, 3 Apr 2025 17:21:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: timer: Add NXP System Timer Module To: Ghennadi Procopciuc , tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, thomas.fossati@linaro.org, Larisa.Grigore@nxp.com, ghennadi.procopciuc@nxp.com, krzysztof.kozlowski@linaro.org, S32@nxp.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" References: <20250402090714.3548055-1-daniel.lezcano@linaro.org> <20250402090714.3548055-2-daniel.lezcano@linaro.org> <2503deb2-b993-7fd1-adf3-cafa1e7bd2f4@oss.nxp.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <2503deb2-b993-7fd1-adf3-cafa1e7bd2f4@oss.nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/04/2025 08:33, Ghennadi Procopciuc wrote: > On 4/2/2025 12:07 PM, Daniel Lezcano wrote: > [ ... ] >> +examples: >> + - | >> + #include >> + >> + timer@4011c000 { >> + compatible = "nxp,s32g2-stm"; >> + reg = <0x4011c000 0x3000>; >> + interrupts = ; >> + clocks = <&clks 0x3b>; >> + }; > > The S32G reference manual specifies two clocks for the STM module: one > for the registers and another for the counter itself. Shouldn't both > clocks be represented in the bindings? AFAICS, there are two clocks as described in the documentation for the s32g2 page 843, section 23.7.3 Timer modules. The module and the register clock are fed by the XBAR_DIV3_CLK which is an system clock always-on. page 1994, 40.5.4 Clocking, the documentation says: "This module has no clocking considerations." From my understanding, we should not describe the XBAR_DIV3_CLK as it is a system clock. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog