From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E23C62DBF75 for ; Wed, 24 Jun 2026 11:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782302287; cv=none; b=IMC8i9ajc2QtgHS/VnNyCqT7dBkjyMCLovhkCDHetstxuY51NlwcnMO0dBf+NEUNHpxqteVa0+5GXyX1IWcivxA9EADbZl6lL5up+Gi9ng/vzoSB/NZiqrv9Yh0Xfnv+OjhWYVt7DhBgG3F1v488lXreqFBCgSkpNWE1B30AFfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782302287; c=relaxed/simple; bh=bEfOfabZA+/qtQxV7AKZPy05UnFJONr702kxAbMxXOM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WImjM5fhkft54s57+ZbTs/rjEu6W94EjwmspaGmy4DBcwClf89PQJtdXsfZ+kr4zkRsnzNwee4Vdt73SaBSlw+l4QEjhDZCBIZGeEELbwHbJ1FKAPi7a6Wof0QwTAyvijLGLv19Y/rzf1nEYKXQWDzn17cxxbSN5YFbmB40iII0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QKC0rigO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cu+jLiuy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QKC0rigO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cu+jLiuy" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OANTk32501716 for ; Wed, 24 Jun 2026 11:58:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ntsbvnXSjYdc95EwUdqEAAUmAKUq+3DroKE3kMSA6tU=; b=QKC0rigOFCItiJmA fVErRFoANKSkqDloe4YwzO48YCcnOhODyz9jPaDOj7ZfYFlVDpkfJHKDglMwhHap Go02khzu5QEQZHeDpMRKDUA+FDC4qEoa15mtHlsH9XL/n5WKcyjyYcSz1D6q1nhj 0CeDzKS+SUhfH5eS01dEVf2i+KdDa9aolbC/OQyZs4MhCTbR32DaOmTpyOV7+Db5 SGm9YLO2VU5k1oF+rLW3DlSxo8Fa1M4IB+qkUrJ3ZDWzP6dObLN7gJsoUAoNeFq7 uaXJ0FkVHpqctqZd5yE077UDBP9edga9xZcGggLMu1D7ZWCbGo+rcgtvhOQ/vdww iPI79w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0d450fed-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 11:58:03 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-517647fbff1so2744881cf.2 for ; Wed, 24 Jun 2026 04:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782302282; x=1782907082; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ntsbvnXSjYdc95EwUdqEAAUmAKUq+3DroKE3kMSA6tU=; b=cu+jLiuyOPEanJr0fHbCw/K0YRmCscwrcmeQASh3OZStpI/r1Lnf1dn/wVXQg1nXPb xA+zw+GgX5JdOzfwX6+w7bQsMUZ61Q4wOiGhF/gIK3AEnwnxG9KR/kpFOSw1XVybS7bz xP1kWDvA+EWhW36LlLidVZ1j83OLTjid0d/NXr8WzJf7w8OEUw+i+5vaDRgTRB/jHmcK Zu2qfsm0MMGM6Z1Kg3cSLxBFduenZ8kHzFDoiN7UyYrAJTA4Ecoo2y9wK5fP4WIPqVA3 P8Nmt3tSS4Nx7W1TL6kT7GMPbVmQiH/D5vnRd7KnpdeAuXS/f2zJaLWsb+IOY5MPSAui TFJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782302282; x=1782907082; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ntsbvnXSjYdc95EwUdqEAAUmAKUq+3DroKE3kMSA6tU=; b=Ph5PmWIPkj3XSiou5HRfhzArxbpW0TyDHbDEMrzAMzuyk8PaodZPTAkvBHwL6QHob5 bcXBle99pl/dEqzxkp0I1lecBQZFxomT/RPIKumfMfhOlK22ncugMBV7KbkmAIVHhrnZ +8xAlBLqoMGGqS2kzhBHdY/afW3vBzQ4KD8ll2iCpUBScodPjDnicnewc/haIRELzFlN VD5uNCrDBY7XkEQeM174Tkd0DUNhXCA5atZqoVC11HxW4v9xI/OlI2EnkZAt3g4tKAeh sMrujQ0yThdfgRJSTxFjzL+ZfLgV5UWYiz6xmduB6izBrH+19qqp3dUacj8JGBAHpXQI /UXQ== X-Forwarded-Encrypted: i=1; AFNElJ+k5M3quGj2yo2T2YQganYTRnFwqcX7z2Q3ea4i2zTwJwYmBNxzKxCzD4KHfQMYo1vJ+Y1lqyLj2xVERAQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+OIjkOEC58pOFMjM1Pgg/3RKqR3+mOVSuRKr5AkZHATj2xB3P +zH0POEpGfACN5yUb6FWj572JdEJFa6pjkXjJ15zG2+R7GvhjxqK0OOgzq366y5XjmgVcy8MX/Q fflJeKsRVAfS8JJYp/a+dc5DK/fpoFTrd20shM8lEPhijw+LDUVWdoPIsT6LqbNXSqrjyLXUfH+ w= X-Gm-Gg: AfdE7cl37xAYHapizPUzl5J11CycG2gTzjjJr7mku8T2ifuBTmDjDBk7PPTAhE5G5sh PWqYMpuihrm8i69jT7tmu/8qQtLxukWy0XBWMbirR2ZR57CdnJuuAN1M/u23q42dvVOuVX5bY8v 2b7p1ZmQI96gjUyLdMYoSy0y4XyiewhCeLKM3eaX4k/v+fLhft7/j67E7E6o5DboKOA85hrJnD1 8ocbsI16ZObb8LeMBqiFh3Dmq6Yf0tNOQgOsrkMhINBhAK9NBL3jC0vMKrA7WFVmIB6yvpAT5GU bEJcot+nJqS1wTycLQXZqskOYUD++fWQHTZHv1ExZ4k8dniyl3F2rqRL7k+nOkhj50vtKFt5VCI aGGKA9ZMZRGQUGJRou9eV6hz9hC0scP4Q+0k= X-Received: by 2002:a05:620a:460b:b0:913:b4b9:5ec8 with SMTP id af79cd13be357-925c87e2572mr934603685a.6.1782302282424; Wed, 24 Jun 2026 04:58:02 -0700 (PDT) X-Received: by 2002:a05:620a:460b:b0:913:b4b9:5ec8 with SMTP id af79cd13be357-925c87e2572mr934600685a.6.1782302282032; Wed, 24 Jun 2026 04:58:02 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e49a9fbsm648644366b.12.2026.06.24.04.58.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 04:58:01 -0700 (PDT) Message-ID: <67e22ad3-5ae6-464d-9f90-72f577d35d91@oss.qualcomm.com> Date: Wed, 24 Jun 2026 13:57:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: sm8250-xiaomi-elish: Add pm8008 PMIC To: Xin Xu , andersson@kernel.org, konradybcio@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA5OCBTYWx0ZWRfXwT3nFYDsiN1R y8mMKNVURt6GKKON63+F7EQ0dSETkjAxAXeKRdmDiXHI0+iKW1K97gl9Oyk8YtUWM7MGNBk+PEv y/cFEkxy13wnktL6ct7+JE9XADvyiMI= X-Proofpoint-GUID: 6w8KUuyljrk2rU-LMF4ZxDrbsxDZtDNx X-Authority-Analysis: v=2.4 cv=Ar7eGu9P c=1 sm=1 tr=0 ts=6a3bc64b cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=dZbOZ2KzAAAA:8 a=EUspDBNiAAAA:8 a=32zDLpEgVwPJr79w7xIA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: 6w8KUuyljrk2rU-LMF4ZxDrbsxDZtDNx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA5OCBTYWx0ZWRfXyINsT2a9Mu35 Rmq4vCMqkstPJb+MKehyJWr34vaIOK6rlxfBOEfUfYN4TPHsGYL8hBb00nEjDDoz11+GIPFPFr5 e3MFXOScJ0ggJldzmZjSm3sCGyeJBcCEq6x95wS0I0NSIS9NMYAKv+fLp960Rt8liiRcqw3/b99 7XabkggCZcLqX291q+HaIWk8ZVlsTDXif68NTwcVnHwcNUtHOmgO1G6igCkGhDjM1B54eG0bif1 FgGB3HKKU8+YU77x6SJO8rnTjR1aqGkXQLgjVMjlrdnzUhX6sVYwvA4fJDeS0awGl17BpgpwX6w 2In0Bs1v8EBA+hiiboToEQni+BLNLz2HMQMJTQ9zpG4rOfttTWrnnkqEjxN8/lO0pXOUAXdfxNq hsOA0Gww7eQ4S8P0eFJ7jRR5lrYrZA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240098 On 6/22/26 8:46 PM, Xin Xu wrote: > Add the pm8008 PMIC node on i2c15 with seven LDOs, > using GPIO84 as interrupt and GPIO76 as reset. > > Signed-off-by: Xin Xu > --- [...] > + pm8008_default: pm8008-default-state { > + int-pins { > + pins = "gpio84"; > + function = "gpio"; > + bias-disable; > + drive-strength = <2>; > + input-enable; > + }; > + > + reset-pins { > + pins = "gpio76"; > + function = "gpio"; > + bias-pull-up; > + drive-strength = <2>; nit: bias properties after drive-strength (I now noticed that 8250 dtsi has it ""wrong"", we'll mass-touch it up once we have a tool for that.. sorry for the trouble) otherwise Reviewed-by: Konrad Dybcio Konrad