From: Dan Williams <dan.j.williams@intel.com>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>,
<Jonathan.Cameron@huawei.com>, <dan.j.williams@intel.com>,
<rppt@kernel.org>, <akpm@linux-foundation.org>,
<david@redhat.com>, <bfaccini@nvidia.com>, <rafael@kernel.org>,
<lenb@kernel.org>, <dave@stgolabs.net>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <rrichter@amd.com>, <haibo1.xu@intel.com>
Cc: <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <chenbaozi@phytium.com.cn>,
Yuquan Wang <wangyuquan1236@phytium.com.cn>
Subject: Re: [RFC PATCH v3 0/2] ACPI: NUMA: debug invalid unused PXM value for CFMWs
Date: Wed, 26 Mar 2025 19:19:29 -0400 [thread overview]
Message-ID: <67e48b81493c2_13cb2943c@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <20250321023602.2609614-1-wangyuquan1236@phytium.com.cn>
Yuquan Wang wrote:
> Changes in v3:
> - Introduce numa_add_reserved_memblk()
> - Use more explicit way to make sure CFMWs fake node >= 1
> - Replace numa_add_memblk() with numa_add_reserved_memblk() in acpi_parse_cfmws()
>
> Problem
> -------
> The absence of SRAT
Can you say more about CXL ACPI platforms that do not have an SRAT? That
seems like the first problem, and this information helps determine
whether this is a fix that needs backporting, or just a cleaner way to
handle this quirk.
> would cause the fake_pxm to be -1 and increment
Not an issue in your patch but it strikes me that "fake_pxm" is
misnamed. There is nothing "fake" about it. It is simply the first
synthesized CXL proximity domain for future CXL region provisioning.
I would not mind a separate patch renaming "fake_pxm" to "cxl_pxm", just
to not confuse future readers with the simulated nodes produced by
mm/numa_emulation.c.
prev parent reply other threads:[~2025-03-26 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 2:36 Yuquan Wang
2025-03-21 2:36 ` [RFC PATCH v3 1/2] mm: numa_memblks: introduce numa_add_reserved_memblk Yuquan Wang
2025-03-26 23:33 ` Dan Williams
2025-03-21 2:36 ` [RFC PATCH v3 2/2] ACPI: NUMA: debug invalid unused PXM value for CFMWs Yuquan Wang
2025-03-21 11:51 ` Jonathan Cameron
2025-03-26 15:00 ` Mike Rapoport
2025-03-26 23:48 ` Dan Williams
2025-03-26 23:19 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e48b81493c2_13cb2943c@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=bfaccini@nvidia.com \
--cc=chenbaozi@phytium.com.cn \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=haibo1.xu@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®