From: Juergen Gross <jgross@suse.com>
To: Sander Eikelenboom <linux@eikelenboom.it>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
x86@kernel.org
Cc: sstabellini@kernel.org, stable@vger.kernel.org, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, boris.ostrovsky@oracle.com,
tglx@linutronix.de
Subject: Re: [Xen-devel] [PATCH] xen: fix xen_qlock_wait()
Date: Fri, 9 Nov 2018 16:35:43 +0100 [thread overview]
Message-ID: <67e80fc6-e47a-3ba2-09ce-b1c8557cc74c@suse.com> (raw)
In-Reply-To: <913d7f22-9ec2-54be-3edb-a93a6adf4fda@eikelenboom.it>
On 09/11/2018 16:29, Sander Eikelenboom wrote:
> On 09/11/18 16:20, Juergen Gross wrote:
>> On 09/11/2018 16:02, Sander Eikelenboom wrote:
>>> On 09/11/18 13:04, Juergen Gross wrote:
>>>> Commit a856531951dc80 ("xen: make xen_qlock_wait() nestable")
>>>> introduced a regression for Xen guests running fully virtualized
>>>> (HVM or PVH mode). The Xen hypervisor wouldn't return from the poll
>>>> hypercall with interrupts disabled in case of an interrupt (for PV
>>>> guests it does).
>>>>
>>>> So instead of disabling interrupts in xen_qlock_wait() use a nesting
>>>> counter to avoid calling xen_clear_irq_pending() in case
>>>> xen_qlock_wait() is nested.
>>>>
>>>> Fixes: a856531951dc80 ("xen: make xen_qlock_wait() nestable")
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> Although you don't seem too interested, you can stick on a:
>>> Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
>>> if you like.
>>
>> I am interested.
>>
>> OTOH I wanted to post the patch officially to give others the chance to
>> send remarks.
>
> OK, would be nice to at least be CC'ed on patches going upstream when
> you have been reporting stuff.
Sorry, my fault.
Juergen
prev parent reply other threads:[~2018-11-09 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 12:04 Juergen Gross
2018-11-09 14:53 ` Boris Ostrovsky
2018-11-09 15:02 ` [Xen-devel] " Sander Eikelenboom
2018-11-09 15:20 ` Juergen Gross
2018-11-09 15:29 ` Sander Eikelenboom
2018-11-09 15:35 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e80fc6-e47a-3ba2-09ce-b1c8557cc74c@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®