From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757343AbcJ3Sj5 (ORCPT ); Sun, 30 Oct 2016 14:39:57 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:43583 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754765AbcJ3Sj4 (ORCPT ); Sun, 30 Oct 2016 14:39:56 -0400 Subject: Re: [PATCH 09/10] staging: iio: tsl2583: add error code to sysfs store functions To: Brian Masney , linux-iio@vger.kernel.org References: <1477648821-3786-1-git-send-email-masneyb@onstation.org> <1477648821-3786-10-git-send-email-masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Mark.Rutland@arm.com From: Jonathan Cameron Message-ID: <67f82ece-f975-3295-ee02-7586188cabfe@kernel.org> Date: Sun, 30 Oct 2016 18:39:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477648821-3786-10-git-send-email-masneyb@onstation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/16 11:00, Brian Masney wrote: > in_illuminance_input_target_store() and in_illuminance_calibrate_store() > validated the data from userspace, however it would not return an > error code to userspace if an invalid value was passed in. This patch > changes these functions so that they return -EINVAL if invalid data is > passed in. > > Signed-off-by: Brian Masney Applied thanks. Jonathan > --- > drivers/staging/iio/light/tsl2583.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c > index 1462374..98afa5b 100644 > --- a/drivers/staging/iio/light/tsl2583.c > +++ b/drivers/staging/iio/light/tsl2583.c > @@ -525,11 +525,10 @@ static ssize_t in_illuminance_input_target_store(struct device *dev, > struct tsl2583_chip *chip = iio_priv(indio_dev); > int value; > > - if (kstrtoint(buf, 0, &value)) > + if (kstrtoint(buf, 0, &value) || !value) > return -EINVAL; > > - if (value) > - chip->taos_settings.als_cal_target = value; > + chip->taos_settings.als_cal_target = value; > > return len; > } > @@ -541,11 +540,10 @@ static ssize_t in_illuminance_calibrate_store(struct device *dev, > struct iio_dev *indio_dev = dev_to_iio_dev(dev); > int value; > > - if (kstrtoint(buf, 0, &value)) > + if (kstrtoint(buf, 0, &value) || value != 1) > return -EINVAL; > > - if (value == 1) > - taos_als_calibrate(indio_dev); > + taos_als_calibrate(indio_dev); > > return len; > } >