From: Andrew Lunn <andrew@lunn.ch>
To: TINSAE TADESSE GUTEMA <tinsaetadesse2015@gmail.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix PTP driver warnings by removing settime64 check
Date: Tue, 30 Dec 2025 11:59:16 +0100 [thread overview]
Message-ID: <67fb6d48-148f-49c7-86aa-4f4244ec6f31@lunn.ch> (raw)
In-Reply-To: <CAJ12PfM3zkJCJLJ3dLtvab2t9O9Dqs8MnoEo=zDb5OcyAPDuJQ@mail.gmail.com>
> This patch resolves warnings triggered when either gettimex64 or settime64 are
> NULL.
> The CONFIG_PTP_1588_CLOCK=y option enables PTP support for all Ethernet
> devices.
> In systems with Intel-based network devices, both the iwlwifi and e1000e
> modules attempt to register clocks, resulting in calls to ptp_clock_register in
> drivers/ptp/ptp_clock.c that produce warnings if any function pointers are
> uninitialized.
>
> Without this patch, the following warning is logged during registration:
>
> info->n_alarm > PTP_MAX_ALARMS || (!info->gettimex64 && !info->gettime64) |
> | !info->settime64
> WARNING: drivers/ptp/ptp_clock.c:325 at ptp_clock_register+0x54/0xb70, CPU#
> 2: NetworkManager/1102
> ...
> iwlwifi 0000:00:14.3: Failed to register PHC clock (-22)
It seems this patch is no longer needed. But FYI, this explanation
should of been in the commit message. The commit message should
explain why a change is needed.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-12-30 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 17:32 Tinsae Tadesse
2025-12-29 19:13 ` Vadim Fedorenko
[not found] ` <CAJ12PfM3zkJCJLJ3dLtvab2t9O9Dqs8MnoEo=zDb5OcyAPDuJQ@mail.gmail.com>
2025-12-30 10:59 ` Andrew Lunn [this message]
2025-12-30 11:50 ` TINSAE TADESSE GUTEMA
2025-12-30 9:42 ` Paolo Abeni
2025-12-30 10:08 ` TINSAE TADESSE GUTEMA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fb6d48-148f-49c7-86aa-4f4244ec6f31@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tinsaetadesse2015@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®