From: Markus Elfring <Markus.Elfring@web.de>
To: Felix Gu <ustc.gu@gmail.com>,
linux-media@vger.kernel.org, Benoit Parrot <bparrot@ti.com>,
Dale Farnsworth <dale@farnsworth.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sukrut Bellary <sbellary@baylibre.com>,
Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] media: ti: vpe: Fix the error code of devm_kzalloc() in vip_probe_slice()
Date: Sat, 21 Mar 2026 20:40:12 +0100 [thread overview]
Message-ID: <67fc2039-ff97-48c5-adc5-a0e2aee6e760@web.de> (raw)
In-Reply-To: <20260321-vip-v2-3-d502c1954817@gmail.com>
> In vip_probe_slice(), the error check for devm_kzalloc() incorrectly
> uses PTR_ERR_OR_ZERO() which returns 0 for NULL pointer.
…
I find such a change description still improvable.
Return statements should be corrected because a corresponding failure predicate
is known already for the called function.
https://elixir.bootlin.com/linux/v7.0-rc4/source/include/linux/device/devres.h#L48-L51
https://elixir.bootlin.com/linux/v7.0-rc4/source/drivers/media/platform/ti/vpe/vip.c#L3455-L3527
Regards,
Markus
prev parent reply other threads:[~2026-03-21 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 13:12 [PATCH v2 0/3] media: ti: vpe: three small fixes Felix Gu
2026-03-21 13:12 ` [PATCH v2 1/3] media: ti: vpe: Fix fwnode_handle leak in vip_probe_complete() Felix Gu
2026-03-21 13:12 ` [PATCH v2 2/3] media: ti: vpe: Fix the error code of devm_request_irq() Felix Gu
2026-03-21 19:30 ` Markus Elfring
2026-03-21 13:12 ` [PATCH v2 3/3] media: ti: vpe: Fix the error code of devm_kzalloc() in vip_probe_slice() Felix Gu
2026-03-21 19:40 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fc2039-ff97-48c5-adc5-a0e2aee6e760@web.de \
--to=markus.elfring@web.de \
--cc=bparrot@ti.com \
--cc=dale@farnsworth.org \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sbellary@baylibre.com \
--cc=ustc.gu@gmail.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®