From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65768446DB; Tue, 17 Sep 2024 08:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726562408; cv=none; b=Ld9tCJ/NgnAZo3KwB+mDU8q4G89SfI6fTXqyEkrVg+wc7qGv890PLliKhKa0E+shZ1QyuF2TfRQaSW7mEcXyvEY249e6Y8TR/92+Ek4c2zyyIF/OJlc8Yu1o/meiLv7oT/z2oTC6uydS6cuviKmIrxQnCZ097PyFZNCvT0FaeIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726562408; c=relaxed/simple; bh=TWJMtfJZ9QPOu5Te4EqE5AIl1qhQ4uGMya1ppUhTjgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e91vE6ZrED+JvEvSoHWoH2FTjAZVVOjJgTviI/tH19ZpL4RMC6QEw2FdN5F16I9X3caue2qxjb/OqFjiC9oSrpadZKkVGFLfABvOJyJ73EzVC+UFCURT6ELonHYfjc970TnYRD+FSDOrZdJ2ha3XIE35x99mPoEsC2a7IwFoqDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E3231DA7; Tue, 17 Sep 2024 01:40:33 -0700 (PDT) Received: from [10.57.83.157] (unknown [10.57.83.157]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AF643F66E; Tue, 17 Sep 2024 01:40:02 -0700 (PDT) Message-ID: <6800a37f-8a37-4a9b-9e22-a78943d1ecf7@arm.com> Date: Tue, 17 Sep 2024 09:40:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/7] m68k/mm: Change pmd_val() Content-Language: en-GB To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , "Mike Rapoport (IBM)" , Arnd Bergmann , x86@kernel.org, linux-m68k@lists.linux-m68k.org, linux-fsdevel@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Geert Uytterhoeven , Guo Ren References: <20240917073117.1531207-1-anshuman.khandual@arm.com> <20240917073117.1531207-2-anshuman.khandual@arm.com> From: Ryan Roberts In-Reply-To: <20240917073117.1531207-2-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/09/2024 08:31, Anshuman Khandual wrote: > This changes platform's pmd_val() to access the pmd_t element directly like > other architectures rather than current pointer address based dereferencing > that prevents transition into pmdp_get(). > > Cc: Geert Uytterhoeven > Cc: Guo Ren > Cc: Arnd Bergmann > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual I know very little about m68k, but for what it's worth: Reviewed-by: Ryan Roberts > --- > arch/m68k/include/asm/page.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h > index 8cfb84b49975..be3f2c2a656c 100644 > --- a/arch/m68k/include/asm/page.h > +++ b/arch/m68k/include/asm/page.h > @@ -19,7 +19,7 @@ > */ > #if !defined(CONFIG_MMU) || CONFIG_PGTABLE_LEVELS == 3 > typedef struct { unsigned long pmd; } pmd_t; > -#define pmd_val(x) ((&x)->pmd) > +#define pmd_val(x) ((x).pmd) > #define __pmd(x) ((pmd_t) { (x) } ) > #endif >