From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B2C3342CBA for ; Mon, 18 May 2026 10:27:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100044; cv=none; b=D+M6aDKaQpjQFDjw5tqmma4xtuQi8aEB1vJvrkp0srAjPg6k0mCDS75sXPsG+l1zHGEfcCRd5h5AFS5dm4SaiJlHTV4oUKTSLcfB1hW0b3xIsKSPNtqoIdGknsrVKGlG8AS2EWntmoIkqW1vhlc5Tan2nfG3CKiGmfqGYYN21V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100044; c=relaxed/simple; bh=iV0yJhfhI1iDqjYTPkc7D13ggZb4VKds5NvfVEmjYBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Avs6sB0/igRi7gi2hOn2mfOTfO27tu2+95AB+/u+sDD3WlvI1wuIYFsZxV3xaOE1eNovOgDOe3JEGDSFlLHrqNhtf2kKj9D7TJxMj+LtLci+MD7W6ZKYp5U4M1DtAmKHrd8EgOgj1HJdnQ8gqlfH6fcDYDhme1Do4uXEo914uQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=c5cdq4sy; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c5cdq4sy" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so22821345e9.0 for ; Mon, 18 May 2026 03:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779100035; x=1779704835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oofnoEjFC3k8jMJB3VTduoNGQlCA1NG6eHrRA2nUPzQ=; b=c5cdq4sy9zlUVFRdrSi5HsNiGaANx8yG68tDRfyOAOBiVKlX7hHzmI2bKQYJJKQ1vb QkP223cR3cw2En/kYzpcZ12PDe5lixCL5MqUOoytp75hje/6IG/+miZgfXHzM//gfWNZ nBEbPHkhPlY4lw0G/BXTBuVh8r8syPni7isFNrdyTppyfvreGEyzdLOWo4oj8QS+BoH1 CNfyn94nVyl7AHkupwwaUHJZbGEKNCUQxo/m1Q7vZ8uLT09Uf5X7XSmHNCD4UDDiktTb 3ml3lgsqfWfbCtb+PwaAzVgvSYMX6TAFMdHM/asDkOetMSoPhJhRc+LKX5GeTwPlMP3Q d3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779100035; x=1779704835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oofnoEjFC3k8jMJB3VTduoNGQlCA1NG6eHrRA2nUPzQ=; b=r7wG9ahqvuqWtGSizLUPVeZOKUFuRCJ9Zgk3i22Man1YADpGlA027m4bqKUquZcVym SkmCOGCZhLuRPHrs2QHTzYC3+F8vWCadaTlnhfrdcJs9fBRWiPe/COjnE+M10p69aQGU Xbg5373PzAtjMuJnvKvy3t6tYhzgBeHSqmj6FM/agzy1t+K99UMSa4lrEAi+M8Dtf8dG VbtjB4hZ26/JVwpsauyqsZBi18c85orOPWdxPHlX6xaz0MtBI2JO5d3MXv02EEvbNX2j nzXAZerZAJq5iHg0nHsADFC4z19NcFt95Oa12RC/NeROOc+/f6fHJQY1wTLsxvRqrXlt jkag== X-Forwarded-Encrypted: i=1; AFNElJ9ItHSDHLMxmco0wQCZTsCZxQX1OXMXCxWEE5IFmTvxzpgtbfdTXbuYqu6B9cuRoJNfEhY3iyLXHL6wHfA=@vger.kernel.org X-Gm-Message-State: AOJu0YzOXw8+pHSX58KFJ4HwH9NBiic42Fi3Nq5kWzNmzhAgcHiBny2J sYMtDpVruDr4YJqibSF/8dMNagAK6iuo3oOBIvYCd1Nvn8/KydsC6oXsYzvaq9Fy0Qs= X-Gm-Gg: Acq92OF4jkzWV3SFLE2QZ56J0qRsVG/kll2Da6sbUnw1jl/2KbQ3Kqkv/RBjrd7zMVA +u4CggoT1kHV1ZKTyU5IfnaOrkbkFzxId3/e8/rvC5vzh1/wpyeaChfvaMTMYSgHu2hhbrpzc5F eWlCKdFH81EwgoqnpsdBmjXY7IplpbPICSagF62qQQIwidi8ceXIZuCZUFuqAFbHu0YktwO4ium O49JgxWe5pulvwKHKMepGPw7NknVmki+3ZRjje78GuQ5TN35cupQXfjZABXtOIaCmjRL1AYUP1w ccDAIMDAaTQBHFlYUWxinp+RyAr0EYZLTtnl+UiM0DusZIre4rPHvlWbVaN2KHQak/dl6Xgm30C gB+qKNqWoefP5tPGXa2GZWcoAPKwYiRj+zNyzxAz2Twb0bdlAP4cHTYoaW1bhZuTbCDXJrrB+KD Mi9g0wuXcXxhlEUaKUDIIf1smpJKp3q1Ex0aPnSjn0ww== X-Received: by 2002:a05:600c:3b07:b0:489:1a3a:9e45 with SMTP id 5b1f17b1804b1-48fe651e127mr216677595e9.26.1779100035288; Mon, 18 May 2026 03:27:15 -0700 (PDT) Received: from [10.11.12.109] ([82.76.215.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a1aeafsm37898451f8f.23.2026.05.18.03.27.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 03:27:15 -0700 (PDT) Message-ID: <6802a856-76dc-4bd0-a026-59b0249646af@linaro.org> Date: Mon, 18 May 2026 13:27:12 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] firmware: samsung: acpm: add Exynos850 support To: Alexey Klimov , Sam Protsenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krzysztof Kozlowski , Alim Akhtar Cc: Peter Griffin , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260513-exynos850-acpm-firmware-support-v1-0-3858d097e433@linaro.org> <20260513-exynos850-acpm-firmware-support-v1-2-3858d097e433@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20260513-exynos850-acpm-firmware-support-v1-2-3858d097e433@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/13/26 2:12 AM, Alexey Klimov wrote: > The Exynos850 SoC contains an APM co-processor. Communication > with this hardware block is established using the ACPM protocol, > which handles IPC messages for clocks, power, thermal management, > and PMIC control. > > Add the "samsung,exynos850-acpm-ipc" compatible string along with > its associated match data. This includes the specific initialisation s/initialisation/initialization > data base offset (which differs from the GS101 offset) and the > "exynos850-acpm-clk" device name required to properly instantiate > the clock provider. The patch looks alright. With what client did you test it, cpufreq? Reviewed-by: Tudor Ambarus