From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97FD3A0B10 for ; Mon, 2 Mar 2026 10:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772446512; cv=none; b=Oztkbr2h+C6BK7bEmPD7KtAQQ5b3z8jJJmUHFjerKQ5dc32O2hvCip6Z5nsA3gqiMjPZxKEf02bUoqH1Xagh6N2+Veaeef+MScyv+cKCUiGALQ53NB6J7Gyc83SfD1YSer+8h9D1IyEKVlXXSekG53a3+QJJlNhrAgQJViJOZuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772446512; c=relaxed/simple; bh=/AkdgchW1du6u8cjXf3KM+oHBacBF71Tc3iQwP2BLg4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cpMPSAricRB2uT9mHhr9CydpkFD8clTYwe36l+PfrQYR8V0922jwMPwwtztpbFezNLm8j5CrfgxDa6LIE9k31vbmATJdG7rMQNjhcxWsFZ+Y/wWUTufccZ0YwK3PR/hKE88EZKI703x87HmlpquATpPM6iI2TnMngA/v7VEpJ8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GDzx9Zfm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OCK+JR/Q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GDzx9Zfm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OCK+JR/Q" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6227mX6M2612430 for ; Mon, 2 Mar 2026 10:15:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gBRf915flOO89c646podLNerCacnzutRJQ8/WgkEjh0=; b=GDzx9Zfm7+sZ5W8w 3FlEavwZTWGqA0xQkDk7qR851k+lQrSvOK5/WkgaiBCtB3i7qvApETFJ0uZnIg6g MP2mfbl7uFonXJIGpQHbbXQTH9JFH/9Fu7AErBIfXRnGu6niFMFJNCCwVPeNh2HX Emc2Y8Vg0JgEjNNzqwEx8II4Y+xkkkGHNjHQQlksD1PSO2h+rtzYnlA4oC76aCvq alu5QSy48oYMQ1u0qU/FgYISGgL4Ns9hkM87YLx7sl1dXARoi3TdN9gLGKQUfkiq cjLrfVNwOO/VVW07PjIRj7zTPv4nR2c/UwgASpia88S8ql8YOFtuygeX1K1/UB1i arsfcA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cmgbatx4j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 10:15:08 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c70c91c8b0so425896285a.2 for ; Mon, 02 Mar 2026 02:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772446508; x=1773051308; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gBRf915flOO89c646podLNerCacnzutRJQ8/WgkEjh0=; b=OCK+JR/Q1r4E4cLbMnUROxHD8jdLp532EAPRxrGcWaZoDeHt9NRClhlsWTBH4c4eG9 emVUzmZzvqW56acn+dY1rSAhPBZ6IQ0RRIYjTLbCfAyBBOHCR5LvBJxVJt27YLtrXcpH yMmUz+8t/7uLFxnURHp2r7aogUo8zS30O7jNf8Vw7JyMUy9kpnHe4w6c3g+KUN++DyJj zd0o8bFAtwiohgr2H6Z03FL0MxdSGf0b/BBHAqm+glexLa7CJsfYGO1AlThTWVvDnAcP PCyXdMt0bbQ6kS7bTV6snZFnQenXqg/e1vYqFzFeLdPR1sNy7M8XOknFaLiI0OmaTF8P jM5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772446508; x=1773051308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gBRf915flOO89c646podLNerCacnzutRJQ8/WgkEjh0=; b=LMg5xsWuZ5FMa9gcSb/DSnXVYjndOT1f1p0HXy7b48eaDVY+p5+HYgJvtuvfgtPohD Icz2JCed6WRLAW7GmEi2MroO/Bv26ezovKOqupwL05sPw9E6h5N9rqix/DF6+WJeB9Sd USLMbcS/IYbGg6Ox2MzHQO5Zp0LoSuZmvfav+8TwcGls2IGHsIaJ3ruwMlNKtmpltA+P +spLQVV3oYzNvU17MZhT5GFdAcv6mld3EFHUCSChTOe9UyyfO/73B/12FHCS9buqLF6q Y9ShmbwH4RXYa0iCVH5EfTWekF0zFAowr9JgWePtGnIErioFHZPFtFBY2mpzJWbtixo/ ONrw== X-Forwarded-Encrypted: i=1; AJvYcCVws1JtId/h0LYxILVQTbEUlKPezmOgjXkVyNvN2KVPkTL+2ph9XFSC9sAH1P87Fgt3Y6OH9u91uB9GnvA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/qvYg1Wsy1vsE0Q/yCd7d6bn8BKJsw3XpV2AqT/n3BjvFQfzD W69ORhQaIr4d929byZI5UE7stLi1GAEt62AwGYCczWz1/JwoaVXJNwh9YccjQtsVFRH9A6191Cu KMCRn07hUh358PKz02jbFi/QRH9yhGWYbOYh8uHcv3ELhTp50r9MxXHtRmiex1iUmSUQ= X-Gm-Gg: ATEYQzwQXSpjv+j9G3BI+TcWUzHvn4p6sO1HwLr2Logjr8xKboIXzmzqBCxrXtfX3EZ Hv5ggCYjrT2RPFJgBRNiOxj1ouY/pS/MZOSc88XSa6fm2NbcagmiqU58C20WuB9h0AxDI89ab9B NdxOxyrwbqz6AsxB3ZKPa9PWzY3nZ+37tjAR7GVzlTpH2V3ROREx0MrrA3AQXqIYF5hKE1mCsbg ZqrE2x828QSl/CTxoUy/dGBT/+veakXPxM7PIw1epM/MKqrHmvDhMQD/qZr7SkuEydCrwGw2uoc GOCSeTzz4FkC3CCuwYb0YuISNitMQu1KNnllr1OheymIZCOjM66HJXbjBPMse/F9qLYJXz7MqNp 72uWExTJ3M/8EMBXyMEPSRT8h/9fxdOUOFJrfdS60SyQK6hIIDssJ7g1zdEB7OJhMZA401swML9 p3RVw= X-Received: by 2002:a05:620a:c4f:b0:8b2:df32:b900 with SMTP id af79cd13be357-8cbc8e7abc4mr1125834885a.4.1772446508130; Mon, 02 Mar 2026 02:15:08 -0800 (PST) X-Received: by 2002:a05:620a:c4f:b0:8b2:df32:b900 with SMTP id af79cd13be357-8cbc8e7abc4mr1125833185a.4.1772446507733; Mon, 02 Mar 2026 02:15:07 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66006aec2fesm1777219a12.1.2026.03.02.02.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 02:15:06 -0800 (PST) Message-ID: <68049d83-8e60-4145-8ab1-d72c2394600d@oss.qualcomm.com> Date: Mon, 2 Mar 2026 11:15:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/11] media: qcom: iris: simplify HFI params handling To: Dmitry Baryshkov , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-iris-platform-data-v2-0-acf036a3c84c@oss.qualcomm.com> <20260228-iris-platform-data-v2-4-acf036a3c84c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260228-iris-platform-data-v2-4-acf036a3c84c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA4NSBTYWx0ZWRfXy4Vp/4xaE0Fv HhV1/i5kc7vQ22o4VFdlQA+7mhCFNdAArNTveICoXk5C7vMz3tcP2itwWRQuWw4nmAnpzz/DkcT KvcqsvDbNqzI9aEkfOx5lH6BFLwTFefzCtN7gARklebQalFAhqiT569qf60Tv0daFEGFMwjOoDt R8zEKta++5R6ViVO4mCZutOnig3cjANOqkcOqHF0s/gHNsdymo9w2xY+VqUUAj6ODXnBsSzq2VE C3MZNUQG8zU4oTwhxu5WdNvUzJ7nYbi+RoFVgxXjjKVU7eGM1g2wM52tJ0Y3SR+Ge3S6U/pw8Gz UkiK9JzBNGSwXNOqIewWDvk16igQn7LrkvhdL0ztjIl9WeWUGKZGvMC9YDKeJLf5v3V5Raan0S7 LcGf3/qgtWKUTRCnqKDOhKyyiRrhKTj6IX7AmDEoyByTBdMJKuimV6hPkCx1Voexsm/+TWCmlMR N/kClaSGm9OZbpBVeUg== X-Authority-Analysis: v=2.4 cv=QfVrf8bv c=1 sm=1 tr=0 ts=69a5632c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=iTeDPL9QkzG7IXd0jXAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: qbTFE-ILdWloXv017HeYCQRlmIJnwBt6 X-Proofpoint-GUID: qbTFE-ILdWloXv017HeYCQRlmIJnwBt6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020085 On 2/28/26 4:26 PM, Dmitry Baryshkov wrote: > Instead of looping over two tables to select the static order of > functions, call necessary functsions directly in the correct order. > > Signed-off-by: Dmitry Baryshkov > --- [...] > + } else { > + ret = iris_hfi_gen1_set_frame_rate(inst, plane); > + if (!ret) > + ret = iris_hfi_gen1_set_stride(inst, plane); > + if (!ret) > + ret = iris_hfi_gen1_set_resolution(inst, plane); > + if (!ret) > + ret = iris_hfi_gen1_set_raw_format(inst, plane); > + if (!ret) > + ret = iris_hfi_gen1_set_num_bufs(inst, plane); Some \n, please? Otherwise the function calls all seem to match what they've previously been decoded as Reviewed-by: Konrad Dybcio Konrad