From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABDC70830 for ; Sun, 17 May 2026 03:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778988483; cv=none; b=go9m4s3TjG4wahhFZoR8kg1stnTkG96L5JRlIRA/AF9G7DgwyhEzyOzKhgeRnu32N/7mGrp7mkSvh0fX8LK1jn8wSs0vHfQ/XF2DPNQSdXCDa8+ZpLqRwVOY1hBZI+JJzqdb8wpkJndncCltgwq/UyP1i1hu4xZ+f0qsivhZbis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778988483; c=relaxed/simple; bh=PJWcPjDMjWs0c/FR2wuQBALN8mECfQMfdss+180oHVc=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=cOCTvhVjqNEmE1IjJfZTh6/NRYyXGq/Ai2GoRmTrYhcI64AJGEJG7S/XgAMUZXDNw7uQfNAVQCTrkNSE5jJ0KXmR/mE9kwCaLeA/ywwpiw1vYIOdTKF+qlXYR6moU//ILYp+QAmkVqdEd0VFHI4f0OCHzpIGc1h5gyFdh5/KLp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NR8FTC6o; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NR8FTC6o" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c802803ac17so420969a12.1 for ; Sat, 16 May 2026 20:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778988481; x=1779593281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=/vMjqO6vdKeoZZj/1K6kqKKNvx2ViUMwGdHgA3bADEI=; b=NR8FTC6oOyjtABlVVpj1crvzwitp/KwIY6LMGMRiqdp0WhnmGHO1S+paKqcj8ccJZe NBrFMR9zR7Yl0IFeRnuJYhjtoXmSUoDqYzeoUozvV6PmSeHJuvDLmrV/uh4cV82TVze3 iaKGPlJ6tujX9EkZnm4JvSt5dgdUq0jBYLOVM9lTtvWr9OR8nCuduZ9Hh2R0cBgZTE7Q 6U1513egkS/tkkd8EbgkBb9i5zC6pOe8CiA7ZTp5u3IuCm6fwDg993BJcouH+IgODljY VtJ4XjAb1/ka/NvHWdloOJ1FtSuvWUBg+tKNtXPIO/FOplwbV5+vMNKuXk+IcS5uLBDH iNhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778988481; x=1779593281; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/vMjqO6vdKeoZZj/1K6kqKKNvx2ViUMwGdHgA3bADEI=; b=D+JV99Fw7+4BOggoPDlu7grlfc4QuQAE5qMdjEVRzAjCv9sc6PNjclNXQgA3eYJR23 ywLwEf9h+C0GN1KAX72Bb412ptQsnsNVnY1CsEEq2NjYCvIq3dU5l4oHkQPNq9SJXJkH OQZZbIuU/GLfzX2V61+lejxoG/xCEYtzwanyWyCH6cihbcdknIBNz96rRHvI64W0Bezs HS36+a/vtzxzriX8OoYGzIKfewCwPHkmrS/c8mq1VnDzetdIoor5aChlqRNkXMQA6TSf 2QJf5z6earHNc1X4nAmHS55mpZdeKbLhNHnX4Waj/mzGiCUe+qfU7Qiug6Zp5V6sZUja +6Tg== X-Forwarded-Encrypted: i=1; AFNElJ8nyG5UtaM0fH8vObMYoN3srlVZoPFK1KFOS+7NG2DjfK7Mku+klnyslh4KrS5yoXIfC6wY42ifn3h7NqA=@vger.kernel.org X-Gm-Message-State: AOJu0YzeE1u+SDx1ocd/9G5cWAkCe2ZUvdy+F6oHpLxkd0t7jdV+3NO0 qLCk8e7+4xycZZ7s3NInDe1h8ZI0h6rox1qaYJT/7xOhwcXwTtLVGU4g X-Gm-Gg: Acq92OGP4x07ds2MP3LNBjoLmQ6PEgyKxW5yUYiHIFEwPLAlK6hpWm/EYyZyuh1AGGe RKQ2/fkJUw/5xRWGCcOEFtr99Bbf4aYbI+r3rxjSQoy9eVCQT1yViAUbDXiBiYukOJypffErkCG rgXQMX4ID83Avdg8984yz9IL9ThawGYCdeLfJ4ZGjv76e6I4pSXEIVHE7wn7wDJ6y6kZ7KLgtm2 jj0iSOgTuriUMu2GVYHoxhoO7pqqTCNx0w1b8jvCb4RUDWy8aCVeokEebfEQLcr3VHKkuxFHXiq PxGbEH+CB3rbrW/Md4xpYF9/TITOwPwyAqKrEBRnrXZPirb8uIx+dpttmrnALnIiCzwhtNWrET4 ULVErzPN33SbYfamK9j5PzXoF7Ul7dEInN0dmpzT6gOQ9qiffAmuut20wGmPaisxHfjcb3Ofywr FfZHpzo2TeoIfaYUKXxIEwcmRaoUQvVD2cR96vbhsAS3FzGZSlePXHYUJ7VUykMtL4OKe4 X-Received: by 2002:a17:90b:560e:b0:369:7811:5abd with SMTP id 98e67ed59e1d1-36978116a74mr3931874a91.15.1778988480975; Sat, 16 May 2026 20:28:00 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:1f3f:2c19:c87e:d8bd:7518:c4f1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3695a10aa1fsm2527197a91.12.2026.05.16.20.27.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 20:28:00 -0700 (PDT) Date: Sun, 17 May 2026 08:57:38 +0530 From: Sanjay Chitroda To: Stepan Ionichev , jic23@kernel.org CC: lars@metafoo.de, Michael.Hennerich@analog.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sozdayvek@gmail.com Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_iio=3A_resolver=3A_ad2s1210=3A_s?= =?US-ASCII?Q?plit_trigger_handler_body_into_a_helper?= User-Agent: Thunderbird for Android In-Reply-To: <20260516151721.1982-1-sozdayvek@gmail.com> References: <20260516151721.1982-1-sozdayvek@gmail.com> Message-ID: <6805AC3F-CF03-4CCC-ACA9-E7BA463C048D@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16 May 2026 8:47:20=E2=80=AFpm IST, Stepan Ionichev wrote: >ad2s1210_trigger_handler() takes st->lock via guard(mutex), then runs >--- a/drivers/iio/resolver/ad2s1210=2Ec >+++ b/drivers/iio/resolver/ad2s1210=2Ec >@@ -1276,10 +1276,8 @@ static int ad2s1210_debugfs_reg_access(struct iio_= dev *indio_dev, > return regmap_write(st->regmap, reg, writeval); > } >=20 >-static irqreturn_t ad2s1210_trigger_handler(int irq, void *p) >+static int ad2s1210_collect_and_push(struct iio_dev *indio_dev, s64 time= stamp) Hi Stepan, Is the return value of this function checked by any caller? If not, should this helper return void instead? > { >- struct iio_poll_func *pf =3D p; >- struct iio_dev *indio_dev =3D pf->indio_dev; > struct ad2s1210_state *st =3D iio_priv(indio_dev); > size_t chan =3D 0; > int ret; >@@ -1295,15 +1293,15 @@ static irqreturn_t ad2s1210_trigger_handler(int i= rq, void *p) > AD2S1210_REG_POSITION_MSB, > &st->sample=2Eraw, 2); > if (ret < 0) >- goto error_ret; >+ return ret; > } else { > ret =3D ad2s1210_set_mode(st, MOD_POS); > if (ret < 0) >- goto error_ret; >+ return ret; >=20 > ret =3D spi_read(st->sdev, &st->sample, 3); > if (ret < 0) >- goto error_ret; >+ return ret; > } >=20 > memcpy(&st->scan=2Echan[chan++], &st->sample=2Eraw, 2); >@@ -1315,15 +1313,15 @@ static irqreturn_t ad2s1210_trigger_handler(int i= rq, void *p) > AD2S1210_REG_VELOCITY_MSB, > &st->sample=2Eraw, 2); > if (ret < 0) >- goto error_ret; >+ return ret; > } else { > ret =3D ad2s1210_set_mode(st, MOD_VEL); > if (ret < 0) >- goto error_ret; >+ return ret; >=20 > ret =3D spi_read(st->sdev, &st->sample, 3); > if (ret < 0) >- goto error_ret; >+ return ret; > } >=20 > memcpy(&st->scan=2Echan[chan++], &st->sample=2Eraw, 2); >@@ -1334,16 +1332,25 @@ static irqreturn_t ad2s1210_trigger_handler(int i= rq, void *p) >=20 > ret =3D regmap_read(st->regmap, AD2S1210_REG_FAULT, ®_val); > if (ret < 0) >- goto error_ret; >+ return ret; >=20 I cannot find this goto instance in mainline=2E Is this patch based on top of iio/testing or another branch? For patch dependencies like this, is it preferred to mention the base comm= it in the changelog for single patches as well or in the commit prefix? > st->sample=2Efault =3D reg_val; > } >=20 >- ad2s1210_push_events(indio_dev, st->sample=2Efault, pf->timestamp); >+ ad2s1210_push_events(indio_dev, st->sample=2Efault, timestamp); > iio_push_to_buffers_with_ts(indio_dev, &st->scan, sizeof(st->scan), >- pf->timestamp); >+ timestamp); >+ >+ return 0; >+} >+ >+static irqreturn_t ad2s1210_trigger_handler(int irq, void *p) >+{ >+ struct iio_poll_func *pf =3D p; >+ struct iio_dev *indio_dev =3D pf->indio_dev; >+ >+ ad2s1210_collect_and_push(indio_dev, pf->timestamp); >=20 The return value does not appear to be used by the caller=2E Should this helper return void instead, or should the caller handle the re= turned error code? The helper function changes look good otherwise=2E Thanks, Sanjay >-error_ret: > iio_trigger_notify_done(indio_dev->trig); >=20 > return IRQ_HANDLED;