From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] media: dt-bindings: Document SC8280XP/SM8350 Venus
Date: Wed, 9 Aug 2023 13:57:44 +0100 [thread overview]
Message-ID: <6807f8c8-0503-cf79-7ef0-653ebafc81e3@linaro.org> (raw)
In-Reply-To: <15b545a2-14be-47ba-a665-8ae986a7f9cd@linaro.org>
On 09/08/2023 13:15, Konrad Dybcio wrote:
>> Hmm.
>>
>> Well from earlier in the thread the question "why do we have these compat strings" is because we can have any combination of encoder/decoder assigned.
>>
>> If there's a cogent argument_still_ to be made to transition to some new way of assignment then fine so long as we don't break that basic flexibility.
>>
>> Though my own €0.02 is that a module parameter is more of a PITA than a compat string.
>>
>> OTOH I could make the argument, that the high probability is most people - probably all, just instantiate a single encoder and decoder and aren't aware of or using the inbuilt flexibility.
>>
>> @stan probably has the right idea what to do.
> Actually..
>
> Has anybody tested this, ever, with the mainline driver?
I assume Stan has.
> Do we have anyone using this?
Can't say.
> Is anybody willing to maintain that, test for regressions and
> fix them in a reasonable amount of time?
>
>
> If we don't have at least 2x "yes" here, I don't think it makes sense
> to worry about it..
Hmm.
We decide if we are encoding or decoding when we init a session and the
blocks are symmetrical. The hw blocks themselves are not bound to a
particular encode/decode mode.
Having two parallel encoders or decoders is exactly the same effort as
having a parallel encoder/decoder.
We don't test parallel encoding/decoding but we should. I'd not be
surprised to find there are bugs but, that's not a reason to exclude
rather to find and fix bugs.
---
bod
next prev parent reply other threads:[~2023-08-09 12:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 20:09 [PATCH 0/6] SM8350 and SC8280XP venus support Konrad Dybcio
2023-08-04 20:09 ` [PATCH 1/6] media: dt-bindings: Document SC8280XP/SM8350 Venus Konrad Dybcio
2023-08-05 19:29 ` Krzysztof Kozlowski
2023-08-07 12:41 ` Konrad Dybcio
2023-08-07 14:04 ` Krzysztof Kozlowski
2023-08-07 15:02 ` Konrad Dybcio
2023-08-07 15:21 ` Krzysztof Kozlowski
2023-08-07 18:44 ` Bryan O'Donoghue
2023-08-07 18:45 ` Konrad Dybcio
2023-08-07 18:49 ` Bryan O'Donoghue
2023-08-07 18:55 ` Konrad Dybcio
2023-08-07 19:05 ` Bryan O'Donoghue
2023-08-09 12:15 ` Konrad Dybcio
2023-08-09 12:57 ` Bryan O'Donoghue [this message]
2023-08-04 20:09 ` [PATCH 2/6] media: venus: core: Remove trailing commas from of match entries Konrad Dybcio
2023-08-04 21:05 ` Bryan O'Donoghue
2023-08-04 20:09 ` [PATCH 3/6] media: venus: hfi_venus: Support only updating certain bits with presets Konrad Dybcio
2023-08-04 20:50 ` Bryan O'Donoghue
2023-08-04 20:51 ` Bryan O'Donoghue
2023-08-04 20:09 ` [PATCH 4/6] media: platform: venus: Add optional LLCC path Konrad Dybcio
2023-08-04 21:04 ` Bryan O'Donoghue
2023-08-04 21:06 ` Bryan O'Donoghue
2023-08-26 13:47 ` Konrad Dybcio
2023-08-26 13:38 ` Konrad Dybcio
2023-08-07 10:43 ` Johan Hovold
2023-08-07 13:04 ` Konrad Dybcio
2023-08-04 20:09 ` [PATCH 5/6] media: venus: core: Add SM8350 resource struct Konrad Dybcio
2023-08-04 21:08 ` Bryan O'Donoghue
2023-08-04 21:17 ` Konrad Dybcio
2023-08-04 20:09 ` [PATCH 6/6] media: venus: core: Add SC8280XP " Konrad Dybcio
2023-08-04 21:10 ` Bryan O'Donoghue
2023-08-04 21:10 ` Konrad Dybcio
2023-08-04 21:12 ` Bryan O'Donoghue
2023-08-04 21:17 ` Konrad Dybcio
2023-08-05 12:11 ` Bryan O'Donoghue
2024-01-22 15:13 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6807f8c8-0503-cf79-7ef0-653ebafc81e3@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mchehab@kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®