From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E275C3563F3 for ; Wed, 17 Dec 2025 10:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765967438; cv=none; b=kZpP19vjggy8Wh41IPOM4C9bc62h9oB03B3bqnvu6voMdgsI8nObZxAtT/O5eMpubL/WjhDWO9SAmjZFMKImfHUSBTur1g/+JgVqrUSWKVsGRNhQD+pQhlRBi9IjzyAZkiItz7+mxWObbX7dS0RApOqqMIvtvg4IIGnuuiOF9us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765967438; c=relaxed/simple; bh=xnApGztY4VzE03KfVeNkQMGdXBk7CDgYf3T95fZJfiQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wz7dopVCbcKm+A6AOFxblcGqEI3fh2KQl+7tiZk8nq7YQ0TUri/TFLMH+vWrjN9NDMksi03RoCuBdY+Lp9aGK/59XFm/gzgf9bcbg5V0z8Z7dbeCkIAsgIi1VIQ4JAltEwAOYB161fmT6UHtdjG8n5eMrB3pFPNmXnoVNv0scvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PUi7fpOf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=POKIeMiP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PUi7fpOf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="POKIeMiP" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH3waGf1904167 for ; Wed, 17 Dec 2025 10:30:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XucAUpMLVF1OiLuwWX8dsfxjWqzHX7ufTd+6SkOaVkU=; b=PUi7fpOfMhkbQS3a AbLI4s4stlkUYZaSf9x7Sk4MrHpiaohnANRYdUE0eDe+CS/QJ8WwrPcjNrswC64Z 1jWq88AK88KyBMLfhf+TVo+JVJnSus2DcVky+qV+g26H4KJzGavS3V1NniulTK3e UfxJihSlL9uRdKl368wnV8ygkED3H8t93qPn9tzygZACUTjmBivxMmudMAObzl0s U/6TZOItn4ZcfSMT+9zaRu1wI499c/v5jjk8M/jOEARppH7rj7HQv2m/NxBclLOD QHQR5Ldja1COHn1ITH9A4+2usRxm7t6zjCx0RPECPH27FDanDLFWUKL+RGf8Z2pn /QZR5A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3n3317bv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 10:30:35 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f1e17aa706so17222451cf.2 for ; Wed, 17 Dec 2025 02:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765967435; x=1766572235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XucAUpMLVF1OiLuwWX8dsfxjWqzHX7ufTd+6SkOaVkU=; b=POKIeMiPV8Vf/9NPV7dLYIj4pdcbmsAnHjkdf5ZE76pjrBBMyJGfRuUdXH8pN2BFA9 5fy2+5jsU+4Pr00Jq3dmlQm6hl8LEU/2eE5ttfXm/lm+SHNuJ7fNz4ZwPkpeckorVV54 mjLvUYZbWXWniUxyHpuKEuasG/mW6YVpAx5g2We7tqYoqYH+vmmbFwBnEXvgfxKv+508 Hwi4Jzq0EcGbUGvI/htqyk2ofv0+a3xtqN+QQvsmkYGvbR+IceosuE5+ZEkuqxh7YLLR sEVoc4APl/KlukIRGHAuoTa68EUGtApU/L0EfznLHFpFA3XcCkwHlYgx+ikiUvx0CcdR xEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765967435; x=1766572235; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XucAUpMLVF1OiLuwWX8dsfxjWqzHX7ufTd+6SkOaVkU=; b=EcYAQSaJ2xImVb8ZetuDD5Yezmx5CY5NlZPyQVW/9JBVzRgYGGlUmT06ThYYWQamwr lE49akjo8Cekt3DNAHHOtT7lxX6t23tqfGNq1URxKRY5hT2EGf3ceOBKtWuSYwJpqpss OzjNfnLcm23OmKSXOvGOJrfdzxDqEehZrAv3N112WlYOoJisBniCv2WYdCMJEzYIqxe0 Vzl8cDNHDv+QDir6fbuXT27rZQGu0s8Tilsr6qW+kNAiL2A1wVnw7Md2dsWVrs3Kfukt cy1eB2E6sG+x5JAAB14V56R/PQEfcwTVzv8CaRHWpu28yNx6OZUP7E52rG6UF7udMHdc Ikfw== X-Forwarded-Encrypted: i=1; AJvYcCWE44/NuOdfk6RTE+CfxZ6S/KYCJht3bPiowkT2WsJhZzzRfbsbeaVzo+/iH37Gpq1Pl/DBFm4nXLirJGs=@vger.kernel.org X-Gm-Message-State: AOJu0YzjjADWb3BeLtpV9zkybWn54QePdQEQ9mF+C3AjYars4tmMe676 8mF5rGE1Hei98ypKSXGhxOTzhoK8o6eTG90sefxU2gfSmUipVGGmij1icmsTIuN0ectzsvUlHvC U5kb+VJIuNHgp/w6rpM9pWNfCAaddCIHa8309vgL7HWUUl2Y91h5ufKBIzZErbvcQXbo= X-Gm-Gg: AY/fxX5j92azzeZrf6Ua9SL1fhMjGw97vkpyf2vMG5VQxwWgd1EmDyIdMC5U/9yBcWo E7CzM1bAQnk9kh5ymv3Rq8Mq6Gou5zYLiqJ29jeUPfghCW3IKPEm304hdsQDUCLuwDbPi+RotH/ 0B21gsfwm919yNCASfHfQCOc9wdoQ1XBfPlpHlL7+jz/5FraKzo/L9McxpvCY6lY70qwZhIBh+w 0mQlGIUWJXvNREaziIgMPchKY92wc0sRBv+GdIpkn0aL/wORg6EkKWDuEUWMhIkrh/njEHaYAhZ 0vARAZSCo7IougoY60sm5wJMhJwFPC2YbbnFq9SIEZ/PcFM4mp3JqxWpjCFP4BNKlrB6XdEYsB3 iQqcRJcYEnou5/AiyyNTo+0DWIqOniYUebwDAPGUzfhPBH7q1QOYLy65er48qrT/hhw== X-Received: by 2002:ac8:5e09:0:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f1d06772cemr180421651cf.9.1765967434869; Wed, 17 Dec 2025 02:30:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTbwO53ucpQ58I9B0cqpVXakTfZzbcNFCFzaHh34IQ4boXaHYcm3+nvD8+c4Onz9BhQueGTA== X-Received: by 2002:ac8:5e09:0:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f1d06772cemr180421311cf.9.1765967434458; Wed, 17 Dec 2025 02:30:34 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa51b859sm1938398366b.43.2025.12.17.02.30.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 02:30:33 -0800 (PST) Message-ID: <680d3b17-7983-4522-89b9-13ad67f4bfe4@oss.qualcomm.com> Date: Wed, 17 Dec 2025 11:30:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] regulator: qcom_smd: change MP5496 supply names To: Gabor Juhos , Liam Girdwood , Mark Brown , Varadarajan Narayanan , Devi Priya , Praveenkumar I , Konrad Dybcio , Kathiravan T Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251216-qcom_smd-mp5496-supply-fix-v1-1-f9b5e70536de@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251216-qcom_smd-mp5496-supply-fix-v1-1-f9b5e70536de@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA4MyBTYWx0ZWRfX0d14DSCNOoBN kmn5OB8LgFbrY1ZCxKxlNleAvGFxTkheErDx9LpWkm4s6NmdKbMFfoyJL9FtGlKzMWXZj8Ngvql pTbEqfNUsuQkmUP5uPUHroEsB9rK5GMrX7cQ/N95LZih0aoZA5HFDs7rsGHJPYCjP/7LaBqkpaR uBYTyvQx0xirsHkhA44xUmr7fG0K9BV6t9oAd+5p887oUZ4g52a1UmxiREn50EpyTuQyWcRJeZ3 O2S3hyEbtWW4JoGQ1uowcCPZIPSp7u+w4wP06rnHrrCWM0NHPnkkPEhsOJ46b+YzvObqrWV9TCv 3WP0Au2OQe26pgKO/Bg2JiYS67zL1aZDRFZ1PgFtKT5vj86UZYTz7m1EfuVIhbZfzZQZbeHfsjy rHglSk/3zUPVJRTCfbyz17Ucoepvjw== X-Proofpoint-GUID: xq4ITykcQrWaHmusFXbOqsSID5LTJFkb X-Proofpoint-ORIG-GUID: xq4ITykcQrWaHmusFXbOqsSID5LTJFkb X-Authority-Analysis: v=2.4 cv=U82fzOru c=1 sm=1 tr=0 ts=6942864b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=4KVRF7KopP9KPnTJK18A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170083 On 12/16/25 7:38 PM, Gabor Juhos wrote: > In case of the MP5496 regulators, the driver uses the same name both for > the regulator and for its supply. Due to this, in some cases the supply > gets resolved to the regulator itself, and the regulator core code throwns > an error message. > > For example, booting the kernel with the 'ipq9574-rdp433' device tree, > results in the following message in the log: > > [ 1.710392] qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators: Supply for s1 (s1) resolved to itself > > Additionally, the driver uses different supply names for the 's2' and for > the 'l2' regulators which is incorrect. Here is the supply map based on the > datasheet of the MP5496: > > VIN1 -> Buck1 > VIN2 -> Buck2, LDO2, LDO3 > VIN3 -> Buck3 > VIN4 -> Buck4 > VIN5 -> LDO4, LDO5 One thing this reveals is that there's an LDO3 and an LDO4 which we don't describe today.. are they managed as power-domains, or are there other other reasons? Konrad