From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2D7C433F5 for ; Wed, 30 Mar 2022 15:23:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348141AbiC3PYy (ORCPT ); Wed, 30 Mar 2022 11:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348133AbiC3PYt (ORCPT ); Wed, 30 Mar 2022 11:24:49 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9158119317D for ; Wed, 30 Mar 2022 08:23:00 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id b19so29769263wrh.11 for ; Wed, 30 Mar 2022 08:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=035VL1akDfA3rp4LH54Rc3G/U1HwVipvz0ZmdfyEOow=; b=HBNyPvECMaVw9sz7r7CfQ74AMIJrMRaExUtKfCpbiilPaQEkJtTikda78N1pZ4v9dd aCkPzzdpTnoqajJbTrX4nRyNznVVCQDFWx7A+F/oP399D1YgVe4Gn3+h4tYxGnt3NfyY MZbTAXyQT1I/jIWeXKdOvDqJiB9VW32bZGkm+gNe+Q/ubBEajExPVbFfV3JJuou0c+vw sYEGd/wBuN/RMkssawgqG9WbQ8yiw3oTt/r0JBFdyNSd/XQJPU4QiIHS/N4aI7wdW/3i Bf1gmZBSNBQGJyoHZIoy/RWTWrByfrgDPXQuEEZqtzRn7rd8oXXiAg0Zj+tPeWOUc1Sa Bj5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=035VL1akDfA3rp4LH54Rc3G/U1HwVipvz0ZmdfyEOow=; b=v7zhUc4V+1lwu4u2dAslkWewe39Im+RPO4UdNoT/xTSQpV8R0s55GCeCgpUk3dai8b UWK1BYgXdGyInXzes4yCSzQqvVW/IOLfdcVv8WzyDBSV8K4BlDfbzy2GknIIsXTm2cTf Q+TzkHRm2Ugk/xPL1XHgObssxudqB8aS5lAiKczyuZFx7pEuDuq6I4bZJBQaZdJazw20 /gOzO2yr5drJcmv7LWDGK5sz3nSyHjBPRLNayoyq1obHvtL/ilxLedI9f9xrNL4PrfAX hJLdRBKpLXtQViMVUNpnBUXm5kVZwxUXB8fU/ypD3tbuLi3RFQdhQMdnzFJ5mabYfFsc rvnw== X-Gm-Message-State: AOAM533fSMj2ubnbHk1TRjBHAvv/4foB2BXt/Wf4tOMh0RXvkLN2raAx mdzhdI9GmL+Y6/upwyGbclQjyg== X-Google-Smtp-Source: ABdhPJwPO+9KqDC9OD9SVYuzhQrpd9w9wVAdCuyfdEX+Fx0MX21LDBTOjmjsuSvR25YetXYFuLlO1A== X-Received: by 2002:adf:d1cf:0:b0:204:12b6:9f5 with SMTP id b15-20020adfd1cf000000b0020412b609f5mr96496wrd.249.1648653778974; Wed, 30 Mar 2022 08:22:58 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:e47f:3cdb:5811:cee8? ([2001:861:44c0:66c0:e47f:3cdb:5811:cee8]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c410700b0038c72ef3f15sm4801683wmi.38.2022.03.30.08.22.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 08:22:58 -0700 (PDT) Message-ID: <6812bb31-5d2b-4737-c2ad-8727d105847d@baylibre.com> Date: Wed, 30 Mar 2022 17:22:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 09/13] pinctrl: meson: Rename REG_* to MREG_* Content-Language: en-US To: Andy Shevchenko Cc: Geert Uytterhoeven , Qianggui Song , Krzysztof Kozlowski , Fabien Dessenne , "open list:GPIO SUBSYSTEM" , Linux ARM , "open list:ARM/Amlogic Meson..." , Linux Kernel Mailing List , openbmc@lists.ozlabs.org, Linux-Renesas , linux-samsung-soc , linux-stm32@st-md-mailman.stormreply.com, Linus Walleij , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Geert Uytterhoeven , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski , Philipp Zabel References: <20220329152926.50958-1-andriy.shevchenko@linux.intel.com> <20220329152926.50958-10-andriy.shevchenko@linux.intel.com> <94e888fe-d8fc-5379-302f-66d64f2ae10b@baylibre.com> <1b0bc704-a740-ea15-1e90-166905be27d0@baylibre.com> From: Neil Armstrong Organization: Baylibre In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/03/2022 11:18, Andy Shevchenko wrote: > On Wed, Mar 30, 2022 at 11:09:11AM +0200, Neil Armstrong wrote: >> On 30/03/2022 10:54, Geert Uytterhoeven wrote: >>> On Tue, Mar 29, 2022 at 6:47 PM Andy Shevchenko >>> wrote: >>>> On Tue, Mar 29, 2022 at 06:13:19PM +0200, Neil Armstrong wrote: >>>>> On 29/03/2022 17:29, Andy Shevchenko wrote: > > ... > >>>>> What error do you hit ? >>>> >>>> arch/x86/include/asm/arch_hweight.h:9:17: error: expected identifier before string constant >>>> 9 | #define REG_OUT "a" >>>> | ^~~ >>> >>> Perhaps REG_{OUT,IN} in arch/x86/include/asm/arch_hweight.h should be >>> renamed instead, as this is a generic header file that can be included >>> anywhere, while the REG_{OUT,IN} definitions are only used locally, >>> in the header file? >> >> Even better, those REG_OUT/REG_IN should be undefined at the end of the header since only >> used in the headers inline functions: >> ==============><================================== >> diff --git a/arch/x86/include/asm/arch_hweight.h b/arch/x86/include/asm/arch_hweight.h >> index ba88edd0d58b..139a4b0a2a14 100644 >> --- a/arch/x86/include/asm/arch_hweight.h >> +++ b/arch/x86/include/asm/arch_hweight.h >> @@ -52,4 +52,7 @@ static __always_inline unsigned long __arch_hweight64(__u64 w) >> } >> #endif /* CONFIG_X86_32 */ >> >> +#undef REG_IN >> +#undef REG_OUT >> + >> #endif >> ==============><================================== > > Can you submit a formal patch, please? I'll submit it separately > > > And I think it would be good to have my patch as well, so we do not depend on > the fate of the other one. > Yes sure Thanks, Neil