From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED92C6FA89 for ; Fri, 2 Sep 2022 14:51:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236435AbiIBOvj (ORCPT ); Fri, 2 Sep 2022 10:51:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236811AbiIBOvM (ORCPT ); Fri, 2 Sep 2022 10:51:12 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 518D0C7422; Fri, 2 Sep 2022 07:13:18 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C223D6E; Fri, 2 Sep 2022 07:13:24 -0700 (PDT) Received: from [10.57.15.84] (unknown [10.57.15.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D7AF3F766; Fri, 2 Sep 2022 07:13:14 -0700 (PDT) Message-ID: <6813a737-736d-7e15-a44f-d800ed9248be@arm.com> Date: Fri, 2 Sep 2022 15:12:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] perf vendor events: Add missing Neoverse V1 events To: John Garry , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org Cc: Will Deacon , James Clark , Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org References: <20220901151804.294823-1-nick.forrington@arm.com> From: Nick Forrington In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2022 09:04, John Garry wrote: > On 01/09/2022 16:18, Nick Forrington wrote: >> Based on updated data from: >> https://github.com/ARM-software/data/blob/master/pmu/neoverse-v1.json >> >> which is based on PMU event descriptions from the Arm Neoverse V1 >> Technical Reference Manual. >> >> This adds the following missing events: >> ASE_INST_SPEC >> SVE_INST_SPEC >> SVE_PRED_SPEC >> SVE_PRED_EMPTY_SPEC >> SVE_PRED_FULL_SPEC >> SVE_PRED_PARTIAL_SPEC >> SVE_LDFF_SPEC >> SVE_LDFF_FAULT_SPEC >> FP_SCALE_OPS_SPEC >> FP_FIXED_OPS_SPEC >> >> It also moves REMOTE_ACCESS from other.json to memory.json. > > Any specific reason why? I see that neoverse n2 and a76-n1 still use > "other" json for REMOTE_ACCESS. Nicer to be consistent. Thanks John, I agree on consistency. I think memory is a better categorisation (for all CPUs), and this is consistent with what I submitted for various Cortex CPUs a while back. I'd be happy to remove the REMOTE_ACCESS change here and update (or not) REMOTE_ACCESS for Neoverse separately. > >> >> Signed-off-by: Nick Forrington >> --- > > Apart from above: > Reviewed-by: John Garry Thanks, Nick