From: Sudeep Holla <sudeep.holla@arm.com>
To: Andy Gross <andy.gross@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Brown <david.brown@linaro.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] spi: qup: skip clk_disable_unprepare if the device is already runtime suspended
Date: Thu, 25 Aug 2016 14:27:53 +0100 [thread overview]
Message-ID: <6816de1a-430c-ba4c-fb48-b8728cc074f2@arm.com> (raw)
In-Reply-To: <20160825132606.GA24683@hector.attlocal.net>
Hi Andy,
On 25/08/16 14:26, Andy Gross wrote:
> On Thu, Aug 25, 2016 at 01:33:28PM +0100, Sudeep Holla wrote:
>> If the spi device is already runtime suspended, if spi_qup_suspend is
>> executed during suspend-to-idle or suspend-to-ram it will result in the
>> following splat:
>>
>> WARNING: CPU: 3 PID: 1593 at drivers/clk/clk.c:476 clk_core_unprepare+0x80/0x90
>> Modules linked in:
>>
>
> <snip>
>
> Thanks for fixing this. I had noticed this yesterday when I was testing your
> freeze patch but hadn't had time to dig in.
>
Yes, even I tested the same once I got PSCI firmware :)
>
> Tested-by: Andy Gross <andy.gross@linaro.org>
>
Thanks.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-08-25 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 12:33 Sudeep Holla
2016-08-25 13:26 ` Andy Gross
2016-08-25 13:27 ` Sudeep Holla [this message]
2016-09-01 20:29 ` Mark Brown
2016-09-02 8:42 ` Sudeep Holla
2016-09-02 9:38 ` Mark Brown
2016-09-02 10:45 ` Sudeep Holla
2016-09-01 20:35 ` Applied "spi: qup: skip clk_disable_unprepare if the device is already runtime suspended" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6816de1a-430c-ba4c-fb48-b8728cc074f2@arm.com \
--to=sudeep.holla@arm.com \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®