From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E3AEE49AB for ; Mon, 21 Aug 2023 15:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236498AbjHUPxB (ORCPT ); Mon, 21 Aug 2023 11:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236451AbjHUPxB (ORCPT ); Mon, 21 Aug 2023 11:53:01 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 708B1A1 for ; Mon, 21 Aug 2023 08:52:59 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-58ddb534848so2377927b3.0 for ; Mon, 21 Aug 2023 08:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1692633178; x=1693237978; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t00Z+mQcMCai4g8+ZNlrGqkLYK+YPlBN/K0yx63dyFI=; b=PYrWHbzwLWe61qr58b7yipvRI3uI7LYUq6puVeMqAUnH5aYhC2bww+9D9PNEtx4JKg e9umTs6g7/TvHjJWpojiqZK/9dk5Cug2ZO0FRLruFEXwiVHqKQIrsGDKti9gc5RqneXV wyBgk8EqaaeeA8yrV0v46hnt6DxEgsNioNqxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692633178; x=1693237978; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t00Z+mQcMCai4g8+ZNlrGqkLYK+YPlBN/K0yx63dyFI=; b=SwySAob1UoNYT3lc1mDxdi+0e0FuU6lIJbDd7kkKCiET4E+OVcujQRTsciILwM5Vrd ecp4XHyuUKvHjCh+/J6lYZborwn225KFIpHJu8NtWdCQhemmf9ih+XtvbWNVz8o9rjvZ lDUD3Sa3XUoLuBXlEF316OEHBKLAk26mPD+9lvbiygEjyDqRx88YEXnbEmMmT9StPez9 OsrIkVm6wE5qDSmjKxunPk7GxC4Cs3mykdDCWQXgmuKLPvZckfJ3h3gKUc0MK52E4nLV XEO1VMy3uQXVjnUxS4sMxbQ7ezlYrrhE0gU779ao32sAu5++cgWf8m/ij9DU5BXUGZC8 kHgA== X-Gm-Message-State: AOJu0Yz/wMENNHolE+P+LFYENS/6bz8xNF2zk+QlJuRVy9X/bfg4XFP+ MGWd6Sun8DtSaVXHDlye/lZULQ== X-Google-Smtp-Source: AGHT+IGSnVYnQZ8xAuQ1Rtjf6i7jON/WZ8Rvcr9+R6jCfIjY49BUPcdFPAo4U1Evo/P7LWavHqVFBw== X-Received: by 2002:a81:4e10:0:b0:583:fc63:7e01 with SMTP id c16-20020a814e10000000b00583fc637e01mr3770247ywb.3.1692633178654; Mon, 21 Aug 2023 08:52:58 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id v22-20020a814816000000b005922c29c025sm303823ywa.108.2023.08.21.08.52.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 08:52:58 -0700 (PDT) Message-ID: <6822c914-4f11-be93-ed55-56447a5838f9@linuxfoundation.org> Date: Mon, 21 Aug 2023 09:52:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: linux-next: duplicate patch in the nolibc tree Content-Language: en-US To: Christian Brauner , "Paul E. McKenney" , Willy Tarreau Cc: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List , Shuah Khan References: <20230817133811.0a73c624@canb.auug.org.au> <9cfb4fe4-162b-3f26-646b-71bed3493925@linuxfoundation.org> <4c037ef2-9159-4528-8ecb-8596cb2a3889@paulmck-laptop> <20230817193909.GA30505@1wt.eu> <01d517c4-d91b-4426-b7f2-2b1277f21d8c@paulmck-laptop> <20230818-anblicken-mitinhaber-11cd07cce0a1@brauner> From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/23 07:59, Shuah Khan wrote: > On 8/18/23 07:27, Christian Brauner wrote: >> On Thu, Aug 17, 2023 at 01:41:45PM -0700, Paul E. McKenney wrote: >>> On Thu, Aug 17, 2023 at 09:39:09PM +0200, Willy Tarreau wrote: >>>> On Thu, Aug 17, 2023 at 11:46:57AM -0700, Paul E. McKenney wrote: >>>>> On Thu, Aug 17, 2023 at 12:27:46PM -0600, Shuah Khan wrote: >>>>>> On 8/17/23 10:30, Thomas Weißschuh wrote: >>>>>>> On 2023-08-17 13:38:11+1000, Stephen Rothwell wrote: >>>>>>>> The following commit is also in the vfs-brauner tree as a different commit >>>>>>>> (but the same patch): >>>>>>>> >>>>>>>>     ba859b2e419c ("selftests/nolibc: drop test chmod_net") >>>>>>>> >>>>>>>> This is commit >>>>>>>> >>>>>>>>     49319832de90 ("selftests/nolibc: drop test chmod_net") >>>>>>>> >>>>>>>> in the vfs-brauner tree. >>>>>>> >>>>>>> I think we can drop the patch from the nolibc tree. >>>>>>> The patch is only really necessary in combination with >>>>>>> commit 18e66ae67673 ("proc: use generic setattr() for /proc/$PID/net") >>>>>>> which already is and should stay in the vfs tree. >>>>>> >>>>>> Thomas, >>>>>> >>>>>> Do the rest of the nolibc patches build without this if we were >>>>>> to drop this patch? Dorpping requires rebase and please see below. >>>>>> >>>>>> Willy, Paul, >>>>>> >>>>>> How do we want to handle this so we can avoid rebasing to keep >>>>>> the Commit IDs the same as one ones in Willy's nolibc branch? >>>>> >>>>> The usual way would be for Willy to drop the patch, rebase, and republish >>>>> his branch.  You would then discard the current branch and pull the >>>>> new one. >>>>> >>>>>> I would recommend dropping this commit from vfs-brauner if it >>>>>> doesn't cause problems. >>>>> >>>>> It might be good for nolibc patches to be going through Willy's tree. >>>> >>>> It would indeed be more logical as a general rule. However, here I don't >>>> care as I don't see any issue caused by dropping it, I can adapt to what >>>> is most convenient for most of us. >>>> >>>> Let's maybe just wait a little bit for Christian to suggest what he >>>> prefers then we can adapt. >>>> >>>>> Or does Christian have some situation where it is necessary to make >>>>> a coordinated vfs/nolibc change? >>>> >>>> I don't think there's any need for coordination on this one. >>> >>> It is always good when either option can be make to work.  ;-) >> >> The patch in the vfs tree will make the test fail so it makes sense to >> have both go in together. I would normally be happy to drop it but I'm >> rather unenthusiastic in this particular case because I replied to this >> almost 5 weeks ago on Thursday, July 13 and since then this has been in >> -next. >> > > I totally understand you being unenthusiastic. Considering summer > vacation schedules and all, emails get missed at times. > > I sincerely request you to consider dropping as it is the simpler route > for all involved. > Christian, Please let us know if my request failed to raise your enthusiasm level. We will go to our plan b of having Willy drop the patch, resend the pull request to me .... thanks, -- Shuah