From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3911F2C68D; Thu, 25 Jan 2024 11:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706182782; cv=none; b=myIFHEEo8/BiZVBsBQwE/Cyvfxvms+DfW83NeQPAR3UrqMpg3QoWN91d12sHPu0Uh4U1aEY62NwfYu9gZHQd+gSTY4qcFHhiCSTJ1J6aBGqbNNRro/SGX5cPwYY83Sz3Z+3WGuOKvjnuBH3f2+s1DajADBbPeOrsUywozX2WH1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706182782; c=relaxed/simple; bh=uuLQcn67ndZcZcBwuCqbGXWUe0vDASxm3uUwFtizmbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FHiOYz5zjTzXbuPx1ndmnqneFHFaZShPbtWVjl95QItxhQk7c0VlICwg/BjumxOB5SCI4Tl/opCdYyMiVBYYcJ4Kd3PnHB3u4IOqxlv3MVbFBRcb36+2USnVzC2KZlnwbs7EcG1AxkEl00Jq23zOCD4VDhaiBEIG5VotIBy3jKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=envjQJ8c; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="envjQJ8c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1706182779; bh=uuLQcn67ndZcZcBwuCqbGXWUe0vDASxm3uUwFtizmbE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=envjQJ8ceoZeoRYHWBr+w/i6IBO3d6F57Se1tosc9GNzMCx3O9LxVW0JZBA9sCPC2 iMH6KmKwKTvnL0dT3TNrdEtI92faSsuTBg7+HOmEoZlJiWoK6jcvWHJaFYSI4QiuwQ jJ2s31+gFHe0a91WJYw/6A3qHT7bbtEbonwyQUSt4dVNkb3jOlbDVW9iXplPqTpclF Ff8mckuU7EsSsfGuA0T5LR4/prZZSCvM+/g06rqPViRaG4o62nmHB8aPwcyje0D87p iVDNUw1w4WzY9QXJ8VE/EIy09iyMrtrgE5uqNAPNzygW6gilTLMQyF0Kp9unItGGVr 4yLjsoIAr+DQQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7D1F33781182; Thu, 25 Jan 2024 11:39:38 +0000 (UTC) Message-ID: <68249675-4081-48d9-abbb-1b2e49894fae@collabora.com> Date: Thu, 25 Jan 2024 12:39:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Content-Language: en-US To: Chen-Yu Tsai , Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger Cc: Sean Wang , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240125095240.2308340-1-wenst@chromium.org> <20240125095240.2308340-2-wenst@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20240125095240.2308340-2-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 25/01/24 10:52, Chen-Yu Tsai ha scritto: > The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over > SDIO. While the Bluetooth function is fully discoverable, the chip > has a pin that can reset just the Bluetooth side, as opposed to the > full chip. This needs to be described in the device tree. > > Add a device tree binding for MT7921S Bluetooth over SDIO specifically > ot document the reset line. > > Cc: Sean Wang > Signed-off-by: Chen-Yu Tsai > --- > .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml > new file mode 100644 > index 000000000000..bbe240e7cc40 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7921s-bluetooth.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT7921S Bluetooth > + title: maintainers: description: ... and then, you missed allOf: - $ref: bluetooth-controller.yaml# Everything else looks good. Cheers, Angelo > +description: MT7921S is a (dual?) SDIO-attached dual-radio WiFi+Bluetooth combo chip; this chip has two dedicated reset lines, one of which is used to reset the Bluetooth core. The WiFi part of this chip is described in ....where? :-) > + This binding describes the Bluetooth side of the SDIO-attached MT7921S > + WiFi+Bluetooth combo chips. These chips are dual-radio chips supporting > + WiFi and Bluetooth. Bluetooth works over SDIO just like WiFi. Bluetooth > + has its own reset line, separate from WiFi, which can be used to reset > + the Bluetooth core. > + > +maintainers: > + - Sean Wang > + > +properties: > + compatible: > + enum: > + - mediatek,mt7921s-bluetooth > + reg: > + const: 2 > + > + reset-gpios: > + maxItems: 1 > + description: A GPIO line connected to the Bluetooth subsystem reset line. > + Typically the W_DISABLE2# pin on M.2 E-key modules. If present this > + shall be flagged as active low. description: An active-low reset line connected for the Bluetooth core; on typical M.2 Key-E modules this is the W_DISABLE2# pin. Cheers, Angelo > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + mmc { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bluetooth@2 { > + compatible = "mediatek,mt7921s-bluetooth"; > + reg = <2>; > + reset-gpios = <&pio 8 GPIO_ACTIVE_LOW>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index b64a64ca7916..662957146852 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13657,6 +13657,7 @@ M: Sean Wang > L: linux-bluetooth@vger.kernel.org > L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) > S: Maintained > +F: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml > F: Documentation/devicetree/bindings/net/mediatek-bluetooth.txt > F: drivers/bluetooth/btmtkuart.c >