From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CD0430ACFB for ; Tue, 28 Apr 2026 02:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777341955; cv=none; b=sQfc3gkG5lJwRxIClUnyHU4/zCH+lgytQxTwTrkoDlRDs9K3hUP7k5AqEliAOdymSLtU0mmjHd3VflEzNJz7sHoZRqwh3o14uacNUoa9QqcKS2HDC14vEMltJ0dx56/uvjo6FTEXsDsoEvJ8GYGvUNPLmgNUzr/O+cFmks8c4A0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777341955; c=relaxed/simple; bh=2hhwXirIdVQ7AOLAJsT7xoc52MI2ce7Ub4Ea6KE9IH0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BPJFkefc3qUTAz62+RQtkOxFXrOjIW6Zid+K0rVzS9hs78OY/zyv2nhwnaP2RS7ZlDNiM1aNbcbNhiimQLbJ6kMmBbPfT2Gl88pdzVnZ0ccy2XTHaSg/wXBBpqkq0E7/eDmmhR9hKqRVkc4i0AuOy9whCbjPd/6TRf2bc44bY5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UsZytqrF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kaCwxbm4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UsZytqrF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kaCwxbm4" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63RIRPOB1237224 for ; Tue, 28 Apr 2026 02:05:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4wVcCD4RrGGxb9mwsikZgQXgvSMM4iURlDffudqtC14=; b=UsZytqrFzA0sqWAh lpUP7lFrvxx4cQiYL/5RiioKPm0Y2iE85nfJHVJESwSi+YSi/Bc3VeDY1xe3OsMK xq+3yZFSl5EpdQtU5/aVdUl0pKt+8s6IiMHG3uCQIkF15LbqtyfoKHSKMY+uLprS lKYov9CvcGlMwkptqlDkYDN6ypmBzw3SOtul0ncatRnKpxl1+R+TJTNhKTtP3oHc 7c7GzYoADUE0j8paznsv5PVonLHe2rfcrLRSWCxThUFCVhiqU4S512KLruL6LWaQ 4oBciUn9oZB7PMoVTIeGlSGDXWQeO1P73VEqZA4knjxVoN1ctM24rEWwh5kZ73Ne umypBg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dt6n4k3h9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 02:05:50 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b24308165dso153872015ad.1 for ; Mon, 27 Apr 2026 19:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777341950; x=1777946750; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4wVcCD4RrGGxb9mwsikZgQXgvSMM4iURlDffudqtC14=; b=kaCwxbm4hOy9g2tIwrWp2HarGDOioOpCP3oDPnh3pAEIX4BtF1qLoFU1aA474ZebYj FnB6D0fg7Su8dOwtjJNAuCTWy2T3dYC15gVtKuCw8revEJxdJYiTGVZbS9bEdOUrcq9G zcVgD1i08zYa4nFggoxE6hEb3Z68aMH1SjxT+bLPbmBFZF1YsE7qqjWCqGSKczNpkZm/ q8tShXC/U0yAJ37YBwIpBAwcZS3LjwRL0PCYqJBBKpFC3TBNDvNBKP09L6rVRaOUYb6y PGo2in1BWtIaurYx9ZOyBZEtDIs5cveWkrErEVNEgWVAEhkIbSuTUPdae6jYSnsj1Gpw 3kWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777341950; x=1777946750; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4wVcCD4RrGGxb9mwsikZgQXgvSMM4iURlDffudqtC14=; b=S4/qlBrHFI/nWWjdAbLjjpPypFxLDFcq0arQlfSSZqOXAiriWOZkalZ8K0PetMezjO Bq2vfp1aWA1FBKl2MxHwNNVjP/oTwNFdDVOwUMbwG4pZT5i2qhbjGKibLuCxmfZV977/ ykBGkQ0yIz1knFbcOhUtHYtrJH1QPUFgCZhNx5FWd+9ZjZc7oB7QCBAKlStMOqF7xeTn HbIhld+88a9/e/Sj4YfncyKvPSEPWvZ1/CsjI7gd2LP+dbXRaa7mD02PeIxZAku802KZ MjstqA3YWMjuta6+1UDFIxWy4ZPtnyDQx1yFEMiM90PQGP2dfvrKEqBdWSdaOaAk0LZC 7uGg== X-Forwarded-Encrypted: i=1; AFNElJ+nicl1uQFjCLHZQ+1RAy4q0XWRl8G5i2M5+VkK29kCvBKvfE8AOb5UUWffg/9Zuw9sR/AKgwDg1iC5qNo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp0Vrx68qU8MhT2YRF2/bymij6LQFuHSSl4yQd6DoVSFr5ABLV s20vrcqZqS+JDWN8ESR2AsNVxiLW3zJw9JQ0BjjZGmgXsnKAhdzv+QrlRFMkRL0RSTyAHJTfUcm hSArAQVWWkIjKBCn5yfTz5fPDVqUdQ7oKkXFHRLFUCH0NvGRgNuc2l8jnxjkbUCn8Va0= X-Gm-Gg: AeBDiesiEx7hHlJ3cbMNTFT0PPineChFAYO3mGJfkmJP9t1WXocwdmdONua7wTt4jp/ JMryxr3UJXaFl836xxDD9GuIGgpwISTuLYxwR6bqIyeQxg8Gq5koCvyAZOU81A9fmIXjwtWCHx/ rDDLC2myPYp+P7KkW2na+IuCv3pNASpCTyduQy36Dg3AJ9Tp39w1seNXlI7ptVvJWrBWBt4dMyg 6qMAZu0sMaBqoCzW+BElSKC9df0LlnANWMvpqEFEfm/qTFm+Q1wGBj+HhBYXuKYpCVvo7RsawtM F3jhNbZ9COPwQLZnFBJSsXfI9YesPNdvdYX5S56nugVj7LxRdxjnmjDfnxbDqPibr7WOmhoqitS FVLk57BWRQHNoU23XMr8YOOs+10aUjQ5pMsL4Z3NXmswGXvLVGOec/g9rLHkCigBj6TfmJ+s5ZC ypAyjPVM3uKiaCogMlfE/25vSoQvEMtQ== X-Received: by 2002:a17:903:2acc:b0:2b2:4cd2:e162 with SMTP id d9443c01a7336-2b97c48d869mr9555855ad.34.1777341949772; Mon, 27 Apr 2026 19:05:49 -0700 (PDT) X-Received: by 2002:a17:903:2acc:b0:2b2:4cd2:e162 with SMTP id d9443c01a7336-2b97c48d869mr9555605ad.34.1777341949264; Mon, 27 Apr 2026 19:05:49 -0700 (PDT) Received: from [10.133.33.153] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b97aa93329sm8048505ad.20.2026.04.27.19.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 19:05:48 -0700 (PDT) Message-ID: <6826ce13-ed2f-42a2-8b46-1357b4a9b4ee@oss.qualcomm.com> Date: Tue, 28 Apr 2026 10:05:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath11k: cancel SSR work items during PCI shutdown To: Wei Zhang , jeff.johnson@oss.qualcomm.com Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260404043050.3433754-1-wei.zhang@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260404043050.3433754-1-wei.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XvIC_IuIoc_vNRajnuJGEljcxvWCpclU X-Authority-Analysis: v=2.4 cv=Xba5Co55 c=1 sm=1 tr=0 ts=69f015fe cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=G9A0gv2bhTP1aVYgofQA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: XvIC_IuIoc_vNRajnuJGEljcxvWCpclU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDAxOCBTYWx0ZWRfXx2AXQ8KNsEFC m6+114PYEeUz+pRfu8rXbzyA1LgrjNSy/H707+qouspL3hW1zxzXf66wn2paCN7lkZBeMRDEFH+ GX/YAXM5Y7gTvZIYF+im52I5rzqXWaHGeHpJemAl57017Af0kYjzoA34hcapAF/omsuK0S4msoZ 2DX5dXa6lSX+2YdQBZBJQOGB1pIMqRW2LErLSaRVT1BkjkrdwwE4S8bA+3ZLpZOAJIMeXea+NXe Zb6aUNZPSCoy14VO3upsgwayCWG5HJQ3VQ2GG10eJgpZeCeyuPiEGFE1XMO+rO95Hf6eKDH2Adi oO9M0+zXDXuryZR772wWkNoC9iC1FDdmlMOd0v1c5EwDJSb6Yzbm7BGovUGWeHK1yrsKI7Fl4nw HELGFk1dMDNwp8ySpvoVGXxlpVQXY5IVGyD4zCx5hjoZeW+WeshHgpcTcUOZWcfwHYtKdlFXwfy v4V3JIz6adpaT9qQpNg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280018 On 4/4/2026 12:30 PM, Wei Zhang wrote: > A reboot can crash the kernel if it overlaps with WLAN firmware crash > recovery (SSR). The crash is a NULL pointer dereference in the MHI teardown > path while freeing DMA-backed MHI contexts. > > Simplified trace: > dma_free_attrs > mhi_deinit_dev_ctxt [mhi] > ath11k_pci_power_down [ath11k_pci] > ath11k_pci_shutdown [ath11k_pci] > device_shutdown > kernel_restart > > On the host side, SSR is driven by the MHI RDDM callback, which queues > reset_work to perform device recovery. reset_work power-cycles the device > by calling ath11k_hif_power_down() followed by ath11k_hif_power_up(). The > power-down phase deinitializes MHI and frees DMA resources. > > Shutdown/reboot runs fully asynchronously with this RDDM-driven SSR > recovery flow. As a result, the shutdown path > (ath11k_pci_shutdown() -> ath11k_pci_power_down()) can race with the SSR > recovery sequence. > > Fix this by canceling SSR-related work items during PCI shutdown, marking > the device as unregistering, and serializing the RDDM callback path that > checks and queues reset_work. This ensures that no new SSR recovery work > can be queued once teardown has started, and that any in-flight recovery > work is fully synchronized before device power-down, preventing MHI > teardown and DMA resource freeing from running more than once. > > Note: This issue only affects PCI/MHI-based devices. AHB-based ath11k > devices do not queue reset_work in normal SSR flows. > > Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04866.5-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 > > Fixes: 13da397f884d ("ath11k: add support for device recovery for QCA6390/WCN6855") > Fixes: 5edbb148bc57 ("wifi: ath11k: Add firmware coredump collection support") > Signed-off-by: Wei Zhang Reviewed-by: Baochen Qiang