From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sen Wang <sen@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: ti: omap-twl4030: use per-device instance of headset jack gpio
Date: Mon, 27 Jul 2026 20:46:20 +0300 [thread overview]
Message-ID: <682769a7-887e-4afd-a61e-54348955ceb7@bitmer.com> (raw)
In-Reply-To: <20260724233432.31325-2-dmitry.torokhov@gmail.com>
On 25/07/2026 2:34 am, Dmitry Torokhov wrote:
> hs_jack_gpios is being potentially shared among several instances of the
> same device, and is being modified. This is not the best approach to
> structuring the code (even if the device is in fact a singleton).
> Change it to allocate a per-device instance.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> sound/soc/ti/omap-twl4030.c | 24 +++++++++---------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2026-07-27 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 23:34 [PATCH 1/2] ASoC: ti: omap-twl4030: drop support for platform data Dmitry Torokhov
2026-07-24 23:34 ` [PATCH 2/2] ASoC: ti: omap-twl4030: use per-device instance of headset jack gpio Dmitry Torokhov
2026-07-25 1:10 ` Sebastian Reichel
2026-07-27 17:46 ` Jarkko Nikula [this message]
2026-07-25 1:09 ` [PATCH 1/2] ASoC: ti: omap-twl4030: drop support for platform data Sebastian Reichel
2026-07-27 17:46 ` Jarkko Nikula
2026-07-27 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682769a7-887e-4afd-a61e-54348955ceb7@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sen@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®