From: Marc Zyngier <marc.zyngier@arm.com>
To: "weiyongjun (A)" <weiyongjun1@huawei.com>,
Stafford Horne <shorne@gmail.com>
Cc: Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
"openrisc@lists.librecores.org" <openrisc@lists.librecores.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] irqchip/ompic: fix return value check in ompic_of_init()
Date: Thu, 4 Jan 2018 09:57:42 +0000 [thread overview]
Message-ID: <68282353-1c44-3d0f-32ec-23934fc19686@arm.com> (raw)
In-Reply-To: <6AADFAC011213A4C87B956458587ADB40131FAB5@dggemi507-mbx.china.huawei.com>
On 04/01/18 03:56, weiyongjun (A) wrote:
> On Wed, Jan 03, 2018 10:41 PM, Stafford Horne wrote:
>> On Tue, Jan 02, 2018 at 11:47:19AM +0000, Wei Yongjun wrote:
>>> In case of error, the function ioremap() returns NULL pointer not
>>> ERR_PTR(). The IS_ERR() test in the return value check should be
>>> replaced with NULL test.
>>
>> Thanks, I am not sure why I was using the *ERR*() macros. 2 questions:
>>
>> - How did you notice this?
>
> This is detected by Coccinelle semantic patch.
>
>> - Should I pull this in through my tree or do you have another route? i.e.
>> Marc?
>
> Feel free to pull this through your tree.
That's for me to say... I'll take it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2018-01-04 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 11:47 Wei Yongjun
2018-01-03 14:41 ` Stafford Horne
2018-01-04 3:56 ` weiyongjun (A)
2018-01-04 9:57 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68282353-1c44-3d0f-32ec-23934fc19686@arm.com \
--to=marc.zyngier@arm.com \
--cc=jason@lakedaemon.net \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®