From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933160AbcGIMHw (ORCPT ); Sat, 9 Jul 2016 08:07:52 -0400 Received: from mout02.posteo.de ([185.67.36.66]:59531 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932947AbcGIMHu (ORCPT ); Sat, 9 Jul 2016 08:07:50 -0400 Subject: Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes To: Dmitry Torokhov References: <1465903215-2351-1-git-send-email-martink@posteo.de> <20160623171835.GE32561@dtor-ws> <246597fa-6a85-1128-853d-3ebdf6f41032@posteo.de> <20160708210824.GE28589@dtor-ws> Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, kernel-testers@vger.kernel.org, linux-usb@vger.kernel.org From: Martin Kepplinger Message-ID: <6828d5b3-519c-27df-0153-2f8d8b6d526a@posteo.de> Date: Sat, 9 Jul 2016 14:07:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160708210824.GE28589@dtor-ws> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2016-07-08 um 23:08 schrieb Dmitry Torokhov: > On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: >> Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: >>> Hi Martin, >>> >>> On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: >>>> static int pegasus_reset_resume(struct usb_interface *intf) >>>> { >>>> + struct pegasus *pegasus = usb_get_intfdata(intf); >>>> + >>>> + if (pegasus->dev->users) >>>> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE); >>>> + >>>> return pegasus_resume(intf); >>> >>> Hmm, we need to take input mutex when using pegasus->dev->users, how >>> about the version below instead? >>> >>> Thanks. >>> >> >> Sorry for the delay, give me a few more days to test and confirm this or >> come up with a final patch. > > Martin, did you have time to try out this version of the patch? > > Thanks! > This patch doesn't seem to work as is. Holidays get in the way, but you can expect a working patch(set) next week. martin