From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011051.outbound.protection.outlook.com [40.93.194.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1711A450409 for ; Tue, 11 Aug 2026 16:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.51 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786465247; cv=fail; b=YNtVhUjuarFaM1Ykhhh/2lxUos/+joVDw3LmXtYhql5qLf+nH2f22bkF6rjq/GsScBT08V7AgzWwKy/E4CiO0Nu/PSyZADBZOftexOU/Q3aoN622aQTpPw0t/6J21l3nxRSxD2Zz0F/r2v6t+FnAZYzNviBsYgTADgd0VOVE1PM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786465247; c=relaxed/simple; bh=wr39SjDGPRPSmliMYdSH4IChjUoHMYRlTR0Ums0XtOQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=k1q3SMLlMVqdzchkxUQW68Jjj4ijWxryyyyMmQMn8/8ohirwqFS4NIrd1+pFSjSJ0kmAHVWV1IhrkX2Y7BpLJYG8fRWwVmoDCMtn8YE0xrxz1NgLJx4B1iyUFpe8IDK0ecF1a1Pz3KPzlivLKQJUe1fa0aBsKoSrLFNIOOvqtAc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=4JFqzRZS; arc=fail smtp.client-ip=40.93.194.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="4JFqzRZS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OAFlnX2s0kyUs9R1Bry6BH9FRYl3C3P4qLWDELre3RHMWfIqAVAIyGlXfY9lDY9V57PzBnNmfvJJaxYaxqfgsyn/KFbZwhwdwscXXoo6WFQBa6XniAswtszdmnsj0E4HfGpXnSd0XRfqdwNNa/fDQi2x3vXIa+MLRvl7uV35D9r5TIlhu6reKHzL2sFXmiJ+OhxqP+klP5Nr1u5LhoFz8Cvj/IJQE/+JTsZlrtRkiLtbPL26KBE7GeYsNj8+a4GEGm/516rGWglz9h5NOgBAfwoVLJMrmcUQyoCXuypcYH/L0AommfUbil9PmNz96XS8Q8lDY4yI5xBGx668847F4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qyNZ1EHcn/5Ac3fSaZZ7Q46rY+0jZ+232ASgm1z5Q2A=; b=bTCHbOCGmGyhI6f58OuY4LsxwBST7lYDHzc3w4RSOr8KCkhaTyUpYF58bkp4d8rEYx2LpcGcR5HNIEpRR30VZKdCGMv9rTatjad3UiZN4xGUE3xFpBnoqa9gQHIoeHGiCP2L4TgLA0nkkNJkmXFWpvUYRVPjW69gKP7LjKK0Cogu0pEVpU18bxDgJe1uis+iw//XdPmx1m/uNp5sKcOr6Qn44oYT3bBN1nt7FnaMrgFLZeGpV7Fk9mqhXtL6IcfcQk4Am7QdJV4m6c6LuNTKMYH0rRnXwl/NyeQUIJ/Z/OtdhjugdtFT+CgTnsx7q7/74U+RcVsQ+1OSaBOblosLCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qyNZ1EHcn/5Ac3fSaZZ7Q46rY+0jZ+232ASgm1z5Q2A=; b=4JFqzRZSQ7w3YdKx9SRY315tcrwVIU6aJ1pSdZRS+l0GNM5cXYi3FgZWp1fVMHEPo7iYBYRdFi1o3r0G+hAOOIMcbNoYbNS3FD8D6g+YXd7XgEzSqoWfaZ7hBVLogVg1V/c81w78A5dem292P946dJATmAzpegg/V4epcuGEjjU= Received: from CYXPR02CA0047.namprd02.prod.outlook.com (2603:10b6:930:cc::14) by CH2PR12MB9542.namprd12.prod.outlook.com (2603:10b6:610:27d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 16:20:35 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:930:cc:cafe::1b) by CYXPR02CA0047.outlook.office365.com (2603:10b6:930:cc::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.11 via Frontend Transport; Tue, 11 Aug 2026 16:20:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 16:20:35 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 11 Aug 2026 11:20:34 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Tue, 11 Aug 2026 11:20:32 -0500 Message-ID: <682cde5e-d002-4d20-a613-6cf65784748c@amd.com> Date: Tue, 11 Aug 2026 21:50:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/itmt: Don't make ITMT enablement depend on debugfs To: Mario Limonciello , Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , "Dave Hansen" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H . Peter Anvin" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Klaus Kusche References: <20260811143643.378589-1-mario.limonciello@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260811143643.378589-1-mario.limonciello@amd.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|CH2PR12MB9542:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a4251ed-4b42-4727-5028-08def7c47927 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|1800799024|376014|23010399003|56012099006|5023799004|11063799006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: +KojtuFSra/Ju+/+r4dJFVi7vYXtpIBx05ikz8DjcKDl3i7dSPlj4S3xl7+CTRKiDibej3RRZuF4tAg1euu/yXkGLG7po94Tb1mlajKdFKhhJI6g0n6mbgNIV1IDb5J/SOEhi7w2qjIGTOAY8mLbYiY0+DnK/2Pegw5gu99bDaKEHDBqEPeCPRuNjzp7T/YeJ9Dick903M33GRireyHdKjIkL2DnZY+WYv3U6gnEDG5XrrCDpJGuYVyAIGs1TKbZuVxbyPX6fHnTZ5W281q3e/73gSpHhjlH5x9gXlN11IEHYTUdESatyAj2GqRfUC0bKGj5NNAy2A2We1gD4Ht+BKyNLwVuOEmnUm6aMyTnLoMSrZWEd9dTuP4aFqQ4zXmeOva+2WCvWMoNNHnhUzbmzqDPHPscIPjGOapzgoDha1ubo9Uu3w74QnaM5gSbCEe/Z3m/Vlm6chMnl8DarrYnGklCTZ/DmLIfYsCJO8vhlNH+ecf02ZvMJoKDoQAmFycVhgxJMPGBZrNvJi8Nge5Edorw1fTzADxAR0/I1Va6NzIxotgaVkQ177HArQB1l4Zl8QsTqWvsbHsIecdzBrE9dZKjtXGU8uaWXZj0BCrKst1J1KfQq3TPzxZ3dd8d1fIe73+kkcYZWK96r2K0lzF9NvrJv4j5oHZlKDeR5BeB7o4pNTiCYqpySOBpbqvSE/wH9At50PVlxjouGScfPbYFRA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(1800799024)(376014)(23010399003)(56012099006)(5023799004)(11063799006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BO+eomjRUMqQGDu8oWbcpl0Y1OLXNgHjIMSOS2ifjgwGTxDeSCdLB182mS9Qi/zhveh75ctIE6Ko2w0YZqU89fzs0QxcqBSWYwyonUEWgMPpFIq9KFfzS4P3eKRyMgI+dRkDcIxOqesRNFBSwQ+rABijFI00EA4LPJgtmb6rcRUdYWu6TszkXdQ3+IuEHHRW+1tOwF1NdSW5RP4WjCcla7bpK4j8how7GnEVOckay3pxmh3SfEPLEvbI8lOiTOVScVoAkhrLB9ZGSFdZ9r4sHWg7xwhlwN9q7gPki8TPZRq3R1rcbE/AgE8Axk0SyXvVjF5p2hphjjatOrf88fuAGwpXKPJwKVFrNthZGBhWFyTvhGEm43dRRKmyeiDwYpBkCu8u/9ijsuYeMbHQ1hUsq7e9HgXFavaFe+BCkBJ6jzL3o3GiXVr1EUMKaPpT9nZB X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 16:20:35.0494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a4251ed-4b42-4727-5028-08def7c47927 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB9542 Hello Mario, On 8/11/2026 8:06 PM, Mario Limonciello wrote: > sched_set_itmt_support() treats debugfs file creation failures as fatal. > When CONFIG_DEBUG_FS is disabled, debugfs stubs return ERR_PTR(-ENODEV), > causing ITMT to be silently disabled. > > debugfs is a debug-only facility; its return values should be ignored. > Drop the fatal error handling and enable ITMT unconditionally. > > Fixes: d04013a4b21b ("x86/itmt: Move the "sched_itmt_enabled" sysctl to debugfs") > Reported-by: Klaus Kusche > Signed-off-by: Mario Limonciello Feel free to include: Reviewed-by: K Prateek Nayak > --- > arch/x86/kernel/itmt.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c > index 243a769fdd97b..85ebde361d6ae 100644 > --- a/arch/x86/kernel/itmt.c > +++ b/arch/x86/kernel/itmt.c > @@ -110,18 +110,14 @@ int sched_set_itmt_support(void) > arch_debugfs_dir, > &sysctl_sched_itmt_enabled, > &dfs_sched_itmt_fops); > - if (IS_ERR_OR_NULL(dfs_sched_itmt)) { > + if (IS_ERR(dfs_sched_itmt)) > dfs_sched_itmt = NULL; > - return -ENOMEM; > - } > > dfs_sched_core_prio = debugfs_create_file("sched_core_priority", 0644, > arch_debugfs_dir, NULL, > &sched_core_priority_fops); > - if (IS_ERR_OR_NULL(dfs_sched_core_prio)) { > + if (IS_ERR(dfs_sched_core_prio)) > dfs_sched_core_prio = NULL; > - return -ENOMEM; > - } > > sched_itmt_capable = true; > -- Thanks and Regards, Prateek