From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA84CA0ECA for ; Tue, 12 Sep 2023 08:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232859AbjILIkW (ORCPT ); Tue, 12 Sep 2023 04:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232800AbjILIkQ (ORCPT ); Tue, 12 Sep 2023 04:40:16 -0400 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7728910C4; Tue, 12 Sep 2023 01:40:12 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Vrw4LF-_1694508008; Received: from 30.97.48.71(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vrw4LF-_1694508008) by smtp.aliyun-inc.com; Tue, 12 Sep 2023 16:40:08 +0800 Message-ID: <682f9cf8-10ab-fd89-7eea-97274f81ac4c@linux.alibaba.com> Date: Tue, 12 Sep 2023 16:40:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH V2 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver To: Linus Walleij , Linhua Xu Cc: Orson Zhai , Chunyan Zhang , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Andy Shevchenko , lh xu , Zhirong Qiu , Xiongpeng Wu References: <20230908055146.18347-1-Linhua.xu@unisoc.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/2023 9:41 PM, Linus Walleij wrote: > On Fri, Sep 8, 2023 at 7:52 AM Linhua Xu wrote: > >> From: Linhua Xu >> >> Recently, some bugs have been discovered during use, and patch2 and patch3 >> are bug fixes. Also, this patchset add new features: patch1 is for >> compatibility with more platforms, patch4 add pinctrl support for UMS512, >> patch5 Increase the range of register values, patch6 add pinctrl support >> for UMS9621. >> >> change in V2 > > V2 is starting to look good, please address Andy's comments, especially > move the fixes first in the series so they can be queued as fixes > if need be. Yes, agree. Please send the fix patches separately with proper Fixes tag. > > I would really appreciate if Baolin can review the patches as well as > he knows this hardware very well and wrote the initial version. Sure.