From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA78C7EE2A for ; Fri, 2 Jun 2023 08:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234225AbjFBIHi (ORCPT ); Fri, 2 Jun 2023 04:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234050AbjFBIHg (ORCPT ); Fri, 2 Jun 2023 04:07:36 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 938C113E for ; Fri, 2 Jun 2023 01:07:32 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30ae4ec1ac7so1581900f8f.2 for ; Fri, 02 Jun 2023 01:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685693251; x=1688285251; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mO/RY3F3B8GPgwLB+7S4hwzVRXzzO6lIPxIO1gccjeg=; b=A598VmaeQlIXU5K1gtsDSH/qH+2fNkD6meglLxmoet8DKTfui5H2P1hC+6+8TtYUOW MnB9VrNtFdGkSFg/mEQ9TN1U2/FtVCU7hqcQ74JZWpxANY+fABdbkCnz68Zv0kuFqkO1 A1XgwUfJXRaIcHo73epEQZGz8+43hPhrR37OP4u1kG5lPH2M7bk6mQB7bADLWEt6GoUz VD7/LilwTL4qKynoEcDLjk9Nwb+fRuhjY2W59L6SaO8K8ZSU8vT5BZ4908x4/t8tT1nu 1cvIHtGamhZCJp4HSp6kFt0K9ubiiiwsG8u8oRn8DiY/E1uiOdqr05TTbzeBb0zX7kTO 1xWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685693251; x=1688285251; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mO/RY3F3B8GPgwLB+7S4hwzVRXzzO6lIPxIO1gccjeg=; b=BrboHb0+Q1zb4L+16mz8sdftfCDpxXoC4Qn4ORGPOui5mCjMv6PJbxIKtkSg47iBVb UfLqYX4X9S8ZPz9OA2db8ro6MisHMICfdTF6Ogsse3G1Cg+Ef3yu+j3Uw8u+9yJYKsgA euODy+JavWgluKN3o/Rk/RUQLHuIY2yRgd7ehhuK8IQv/jMwM7msglY1lrltO78NoXWM WzKhcwRwB5jfoxq/tHaBQZrfAADbVpVLW2zmHFmTia43yxsr1lWN389XcxIchg2T2htN XUxKwTbuNz8MFTZ8j1zAZeoetOsT7gOR5Y43Zk10mgHaH3yw+ubsiQ+Dk6y+26aiKVLf 2Ukw== X-Gm-Message-State: AC+VfDxNU05bqYY7CcmcRN5CY6JAsgm+Gz9L/iIoIBGhURUykgICuRaE 8QwnNOGuRyzrI2RSjXf8q17kx3nrfrUm6xt6bsI= X-Google-Smtp-Source: ACHHUZ4iJjab6zb7VKTRm84jdXYQvx32T3lqpuKG6BtYc68C7Lg6oyRp4fV/jUzSTe+AMMJXE2XPLw== X-Received: by 2002:adf:cd8b:0:b0:307:83a4:5860 with SMTP id q11-20020adfcd8b000000b0030783a45860mr3794370wrj.68.1685693250955; Fri, 02 Jun 2023 01:07:30 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:548f:8f7e:a3c2:888a? ([2a05:6e02:1041:c10:548f:8f7e:a3c2:888a]) by smtp.googlemail.com with ESMTPSA id d8-20020adff848000000b0030ae849c70csm929300wrq.37.2023.06.02.01.07.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 01:07:30 -0700 (PDT) Message-ID: <68393044-9d28-8402-e190-7cbb28442f6d@linaro.org> Date: Fri, 2 Jun 2023 10:07:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 0/3] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Chen-Yu Tsai , Alexandre Bailon , kernel@collabora.com, Balsam CHIHI , AngeloGioacchino Del Regno , Alexandre Mergnat , Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230428195347.3832687-1-nfraprado@collabora.com> <20230502103344.GA3388518@google.com> <87b0f5cd-67a8-fbd5-5ca7-a286b543d796@linaro.org> <8a38a0da-3a4f-4e39-9f9e-42682edfd9bf@notapiano> From: Daniel Lezcano In-Reply-To: <8a38a0da-3a4f-4e39-9f9e-42682edfd9bf@notapiano> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/05/2023 21:46, Nícolas F. R. A. Prado wrote: > On Tue, May 30, 2023 at 02:27:36PM +0200, Daniel Lezcano wrote: >> >> Hi, >> >> On 02/05/2023 12:33, Chen-Yu Tsai wrote: >>> On Fri, Apr 28, 2023 at 03:53:44PM -0400, Nícolas F. R. A. Prado wrote: >>>> >>>> Fixes in the interrupt handling of the LVTS thermal driver noticed while >>>> testing it on the Spherion Chromebook (mt8192-asurada-spherion) with the >>>> MT8192 support series [1]. >>>> >>>> These are standalone fixes and don't depend on anything else. >>>> >>>> [1] https://lore.kernel.org/all/20230307163413.143334-1-bchihi@baylibre.com/ >>>> >>>> Thanks, >>>> Nícolas >>>> >>>> >>>> Nícolas F. R. A. Prado (3): >>>> thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers >>>> thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode >>>> thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts >>> >>> This series seems to have solved all interrupt storm issue I ran into, so >>> >>> Tested-by: Chen-Yu Tsai >> >> I gave a try on a mt8195 board and I don't see any interrupt firing when >> crossing the temperature thresholds. >> >> Did I miss something ? > > No, indeed interrupts seem to be completely disabled on mt8195, even after > setting the controllers to filtered mode (a requirement to get interrupts). Really? interrupts work only on filtered mode? That sounds strange What board are you using for testing? > I > haven't investigated that further yet. This series was validated on mt8192, > which did have working interrupts, but they were being triggered too often. Ok. > Also note that I've sent a v2 with even more fixes: > https://lore.kernel.org/all/20230504004852.627049-1-nfraprado@collabora.com/ Yes, I'm reviewing it closely -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog