From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424762AbcFMPrL (ORCPT ); Mon, 13 Jun 2016 11:47:11 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55198 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424144AbcFMPrJ (ORCPT ); Mon, 13 Jun 2016 11:47:09 -0400 From: Arnd Bergmann To: Binoy Jayan Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gdm724x: Replace semaphore netlink with mutex Date: Mon, 13 Jun 2016 17:48:34 +0200 Message-ID: <6839489.KXLklQkzgz@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1465828160-17141-1-git-send-email-binoy.jayan@linaro.org> References: <1465828160-17141-1-git-send-email-binoy.jayan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xlbgE2EmE4zUuuvGjedD0ZwYw/gerPEVNuZGN3bEiFi9lLVxumA Z12kGfiwN0TrXg+WG2mnTcAeuZiQjURAk2+/s/33SN112qCf9n/q4CNcXKxPNjWGi9rCRTo VrU/+tCTOglWVwJa30LiJw4CyohxShMVULWOp7ZmSgRSWH6zUQUucCECKB0PFJIsrD1MLOg TugBEX7UDvRj1RLjA3HEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:AOlcx1RUGJA=:GazEQfmp9KyxDCeZwZyBkY HnbsErGtDr+P0eloZkJ85dg7TiF4tyyWMUMmlGv3NbIXnWbuNaWav+tQH7QlKiTAXYOzpn2Sq GScRGY+HvKf+Tc/xGvbgJBRB35OWzu+NrJVSiG7MQG4V4ECdHMMwtGaNv9VP7Cr9mcPxvNEdG 4Lp7aW1xA755hMqp7bJvRPOLYbdkepa/JUgjRqdrnQV5fMaGf4GZMfbkQWQuHKbKjGASZAT3c QDyrze/qhOEjPdztqhNffmk0DEQpIngEGbD4NBEueYVkvcXgFrba2CF+l+vOq0YqFV5XbwYtp 6yW6B/dETam2Q5l1jmR6+lCnHjDOSTWOAjbMo/KZJ5LrnCE8IFa3Ug3SNUfpPYcn55opfsMA3 YMbZy0pVh5HeTsLsKONsK+H3K3kBUJ1Ra8+jqZfOzx50BzcKo+Llb4E4/LS7VIQpwo6L59wNT h7PGPoR+YGE04aSKDVfviJSvPpqsmyrYD8aynotGjNkWKpl8hJnChyluOKGoakiIKgDvoDcQh bkkfO6/6CfdFqw3Ud12ZaZTX+NdmYnUXQTbYWHEMXbyXokF0ORjsj81Ffbi/mieQLft9PSCLR HAtakvXueMQpJOvKKcr7Z6RAc9JElsjpWl6nmEXYqu8T+x8wcIu4GuXcsJJCXs9NTP4IAwOFo sixBqfGnT2neYfuqPrGtS+qKCiQNLIICBUxIzZptnzd4NZ6GoxYwZ+9so8ONMI7xx2aLA1lZ/ RXHBuOmeV/NfyFPS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, June 13, 2016 7:59:20 PM CEST Binoy Jayan wrote: > > -#if defined(DEFINE_MUTEX) > -static DEFINE_MUTEX(netlink_mutex); > -#else > -static struct semaphore netlink_mutex; > -#define mutex_lock(x) down(x) > -#define mutex_unlock(x) up(x) > -#endif > +static struct mutex netlink_mutex; > Good catch! I think the patch is correct, but the DEFINE_MUTEX here seems preferable over the runtime mutex_init() call. Arnd