From: Andrew Lunn <andrew@lunn.ch>
To: Sanman Pradhan <sanman.p211993@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
kernel-team@meta.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
mohsin.bashr@gmail.com, sanmanpradhan@meta.com,
andrew+netdev@lunn.ch, vadim.fedorenko@linux.dev,
jdamato@fastly.com, sdf@fomichev.me, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] eth: fbnic: Add PCIe hardware statistics
Date: Wed, 6 Nov 2024 18:32:01 +0100 [thread overview]
Message-ID: <683c8ffd-6766-4ad3-8049-0defaff7295f@lunn.ch> (raw)
In-Reply-To: <20241106002625.1857904-1-sanman.p211993@gmail.com>
> +struct fbnic_hw_stat {
> + struct fbnic_stat_counter frames;
> + struct fbnic_stat_counter bytes;
> +};
I don't think this belongs in this patch, since the PCIe counters
don't seem to have anything to do with frames or bytes.
Andrew
next prev parent reply other threads:[~2024-11-06 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 0:26 Sanman Pradhan
2024-11-06 0:43 ` Jakub Kicinski
2024-11-06 0:49 ` Joe Damato
2024-11-07 2:14 ` Sanman Pradhan
2024-11-06 12:22 ` Leon Romanovsky
2024-11-06 17:12 ` Bjorn Helgaas
2024-11-06 17:36 ` Andrew Lunn
2024-11-07 0:09 ` Jakub Kicinski
2024-11-07 8:23 ` Leon Romanovsky
2024-11-07 11:30 ` Vadim Fedorenko
2024-11-07 12:03 ` Leon Romanovsky
2024-11-07 15:40 ` Jakub Kicinski
2024-11-07 16:42 ` Leon Romanovsky
2024-11-06 17:50 ` Leon Romanovsky
2024-11-06 21:17 ` Bjorn Helgaas
2024-11-07 8:11 ` Leon Romanovsky
2024-11-06 17:32 ` Andrew Lunn [this message]
2024-11-07 2:16 ` Sanman Pradhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683c8ffd-6766-4ad3-8049-0defaff7295f@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®