From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751105AbdE3Slr (ORCPT ); Tue, 30 May 2017 14:41:47 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:52002 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdE3Slp (ORCPT ); Tue, 30 May 2017 14:41:45 -0400 Date: Tue, 30 May 2017 20:41:05 +0200 (CEST) From: Stefan Wahren To: Phil Elwell , linux-clk@vger.kernel.org, Eric Anholt , linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , Florian Fainelli , linux-rpi-kernel@lists.infradead.org Message-ID: <684006892.45085.1496169665454@email.1und1.de> In-Reply-To: <866b60bb-d1c8-726e-3a2d-11a34f9e8ac7@raspberrypi.org> References: <866b60bb-d1c8-726e-3a2d-11a34f9e8ac7@raspberrypi.org> Subject: Re: [PATCH 1/2] clk: bcm2835: Limit PCM clock to OSC and PLLD_PER MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.2-Rev34 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K0:xeUAx1VSn2vZ9/RPTBgXhNTuecKRRt+X1v1hUDnVmmlIY3yN2/T tud4Wv9gIkHSuNVtAQMn1Cjdg+NDkgF12/JyfWG6mNLi03Oeof85IeDDuumwlbSXXoWq99f ApWTvIdObo22e3amY3y4RmUDxciTt7yuROzcmxn0XtQvgWufLYlTF6S5DDuw/ttq1gEBkib KDDf8ltmVG5wZZ2Fc7fkg== X-UI-Out-Filterresults: notjunk:1;V01:K0:nSD2A5lDs+s=:XJDtj/OAcZXrL79qMkorMQ J+HpES+3zdkxWPRGLjkbTwqhM59GqM59ZfFJl+64zLWm7rdld4T7DGOspWLrWS479+YSu935b Ym1mLVUYeHCwnM7LKLl5rCG4iXMvLliU8cJNwMdUgR5v5y5XYxon01GN1m8najWWR9OVrtL/X /pZN2spB6kCfabypHXsTiwt0W46GcK1cQnVWqYXYOyrim9RR9EoKZd/RaBqQLgWImVVGpc6y1 FXPGa/dX6qoEv73eN0UANF7/z+4PNRhKRgN9JFge3biTj0Yu38MsDZCE1IVY4Bu7JwpCWi/FH nbhR5VaOoem3r6E6dyAHhKzxhX33+l+SohLqQWLbiSKe0U7DbhOon6xmLCcrT2QMUa5aAZW68 8tKWAHG3rO/zlyOT51iQAHcizv14gtIz+OSj1Rs5aSNCkwWgg8R7Cllq+FFnhEAgTOvdD4I2O GzDwq7B2apLsbVhE90JaiesWWdRFIn448TbmuDiudOTlVimRdlrwab8O5UBTHwFEIjmFUAbu7 03LXdJBBCeELsDwgYQQ3FXZdGHWifZbry4+Z/8soC4+HU8NiI5niRkizvzy95M41YqzWdlXKj vy94ez8TGYdYsTZ2SwjSVxFUTXLLJ9s4DLWaOnxTofPDGmCGGV30zH/vNqXme7fD3u8m4Cn2Z KfrhsQOsE4FemYvt+nbXwmSCgxORKN6z/p3JlQHEl8+//o8GQKBJhDRv/Ug3J9vyQLXuRB85C 9hB4h9ZiTnBm2Pf/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Phil, > Phil Elwell hat am 30. Mai 2017 um 18:28 geschrieben: > > > Restrict clock sources for the PCM peripheral to the oscillator and > PLLD_PER because other source may have varying rates or be switched off. > Prevent other sources from being selected by replacing their names in > the list of potential parents with dummy entries (entry index is > significant). i like to have this as a comment above the definition of bcm2835_pcm_per_parents. > > Signed-off-by: Phil Elwell > --- > drivers/clk/bcm/clk-bcm2835.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 0258538..facc346 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1511,6 +1511,16 @@ struct bcm2835_clk_desc { > "pllh_aux", > }; > > +static const char *const bcm2835_pcm_per_parents[] = { As mentioned above, there should be a comment like all the others. > + "-", > + "xosc", > + "-", > + "-", > + "-", > + "-", > + "plld_per", > +}; Is there a dummy entry for "pllh_aux" missing? > + > #define REGISTER_PER_CLK(...) REGISTER_CLK( \ > .num_mux_parents = ARRAY_SIZE(bcm2835_clock_per_parents), \ > .parents = bcm2835_clock_per_parents, \ > @@ -2000,6 +2010,7 @@ struct bcm2835_clk_desc { > .int_bits = 12, > .frac_bits = 12, > .is_mash_clock = true, > + .parents = bcm2835_pcm_per_parents, This looks a little bit hacky to me. Not sure, but can we do something like this? #define REGISTER_PCM_CLK(...) REGISTER_CLK( \ .num_mux_parents = ARRAY_SIZE(bcm2835_pcm_per_parents), \ .parents = bcm2835_pcm_per_parents, \ __VA_ARGS__) Regards Stefan > .tcnt_mux = 23), > [BCM2835_CLOCK_PWM] = REGISTER_PER_CLK( > .name = "pwm", > -- > 1.9.1 >