From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B5AC77B75 for ; Mon, 8 May 2023 16:05:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233367AbjEHQFp (ORCPT ); Mon, 8 May 2023 12:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233223AbjEHQFf (ORCPT ); Mon, 8 May 2023 12:05:35 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02A2E5596; Mon, 8 May 2023 09:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=ebaZanb8mMS/3kCwPp9fvWuYfdqaIKECCeqEOV7mGaA=; t=1683561934; x=1684771534; b=YTxLkG7l+w7jnhPWdV7E4YhsYBHl+VZ5Yri7FmcJFi3Gjkh HP2jyGF2oS5zZYwZSaiM9hipdgOTWzco45fjJSPdxMlfLR+GwUSBBKOD5U60eh3RBRWiA9oj+XWkW nryLa0t+eXqGSDzFVHsBV5m2tPc5E1S1fDa0IiAX1+ERzeM0nSrhoSL7XlfkM1A6qMY37SvtbR9R1 WbJtgkUuCzxfYdELgmShHhcAn0hxpGW6eAWiHNH7HwWrZSCN4MOEmiKqqEFvCVcz1BnMEkTRd7lg2 ukhxrOhqed6EMhGC/AJ6dU8/UA5BCeRbYnO9mHq455Offlysz8xYdkSKvKXNJ4cQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1pw3MP-003Mif-0F; Mon, 08 May 2023 18:05:13 +0200 Message-ID: <68404955637d963f3111a60d3d99c1be8b5d4045.camel@sipsolutions.net> Subject: Re: [PATCH] wifi: iwlwifi: Use default @max_active for trans_pcie->rba.alloc_wq From: Johannes Berg To: Tejun Heo Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, kernel-team@meta.com, Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Gregory Greenman , Avraham Stern , Kees Cook , Mordechay Goodstein , "Haim, Dreyfuss" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Mon, 08 May 2023 18:05:11 +0200 In-Reply-To: References: <20230421025046.4008499-1-tj@kernel.org> <20230421025046.4008499-10-tj@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2023-05-05 at 12:52 -1000, Tejun Heo wrote: > trans_pcie->rba.alloc_wq only hosts a single work item and thus doesn't n= eed > explicit concurrency limit. Let's use the default @max_active. This doesn= 't > cost anything and clearly expresses that @max_active doesn't matter. >=20 > Signed-off-by: Tejun Heo > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Gregory Greenman > Cc: Johannes Berg > Cc: Avraham Stern > Cc: Kees Cook > Cc: Mordechay Goodstein > Cc: "Haim, Dreyfuss" > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org >=20 Sure, that seems fine too. Acked-by: Johannes Berg For whatever that's worth, might better to get Gregory ;-) johannes > --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c > +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c > @@ -3577,7 +3577,7 @@ struct iwl_trans *iwl_trans_pcie_alloc(s > init_waitqueue_head(&trans_pcie->imr_waitq); > =20 > trans_pcie->rba.alloc_wq =3D alloc_workqueue("rb_allocator", > - WQ_HIGHPRI | WQ_UNBOUND, 1); > + WQ_HIGHPRI | WQ_UNBOUND, 0); > if (!trans_pcie->rba.alloc_wq) { > ret =3D -ENOMEM; > goto out_free_trans; >=20