From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v7 6/6] arm64: dts: qcom: x1e80100-crd: Define RGB sensor for cci1_i2c1
Date: Fri, 25 Apr 2025 22:06:36 +0100 [thread overview]
Message-ID: <6841b51f-a4f6-452a-b5f4-c018ac2ec94b@linaro.org> (raw)
In-Reply-To: <d0b3a631-e75b-47c7-a98c-6158507f1148@oss.qualcomm.com>
On 25/04/2025 22:01, Konrad Dybcio wrote:
>> + orientation = <0>; /* front facing */
> This most definitely needs a dt binding definition instead of a comment
That's standard somewhere.
But now that you mention it, it should be a define not an integer.
---
bod
next prev parent reply other threads:[~2025-04-25 21:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 11:27 [PATCH v7 0/6] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2025-04-17 11:27 ` [PATCH v7 1/6] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2025-04-17 11:27 ` [PATCH v7 2/6] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2025-04-17 11:27 ` [PATCH v7 3/6] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2025-04-17 11:27 ` [PATCH v7 4/6] arm64: dts: qcom: x1e80100-crd: Define RGB camera clock and reset pinout Bryan O'Donoghue
2025-04-17 11:27 ` [PATCH v7 5/6] arm64: dts: qcom: x1e80100-crd: Add pm8010 CRD pmic,id=m regulators Bryan O'Donoghue
2025-04-25 20:59 ` Konrad Dybcio
2025-04-17 11:27 ` [PATCH v7 6/6] arm64: dts: qcom: x1e80100-crd: Define RGB sensor for cci1_i2c1 Bryan O'Donoghue
2025-04-25 21:01 ` Konrad Dybcio
2025-04-25 21:06 ` Bryan O'Donoghue [this message]
2025-04-17 13:51 ` [PATCH v7 0/6] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6841b51f-a4f6-452a-b5f4-c018ac2ec94b@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®