From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758374AbdHYThh (ORCPT ); Fri, 25 Aug 2017 15:37:37 -0400 Received: from mout.web.de ([212.227.15.3]:58494 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758355AbdHYThf (ORCPT ); Fri, 25 Aug 2017 15:37:35 -0400 To: linux-scsi@vger.kernel.org, "James E. J. Bottomley" , "Martin K. Petersen" Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] SCSI-sd: Delete an error message for a failed memory allocation in sd_revalidate_disk() Message-ID: <68431300-6ceb-0c61-a0cf-e6b7b20f6a45@users.sourceforge.net> Date: Fri, 25 Aug 2017 21:37:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:nb6r1C0k9n8zCXuJyUD37BOTi9rjtOowoqGVf1u6A23SOJ76Hbg tfBzvXNuiUIsfClRO8jmqkj5Qko6V/wax31SJEklnYVu7SmfPSHvEuiFwkeHhYRxnazwOFu zerX3OhLBIBIH5+VefPyDJvlbpn++m/cmzGAXGU+b6XZEdYX3gERu7OpIBc0AunWi8G+Y56 BL2wcfnhyHIz3der4trGA== X-UI-Out-Filterresults: notjunk:1;V01:K0:TWxGP8Lzedg=:SJYck9WtUJnjNR5Dgrpq9t ORBQhq3TKLQXpzrMfQQadrOE5PPndrcRbqdyFKWmlpVLMaFjLexhl2q5es2Ck8+xit0LjZu2X sgPCqDvV20D2nb28TfhaC1HQF4eABJxL33XVZTBnk+cOvcGx7qRRAUU3QweUty4S3LnKnZVLL BWFasMbdRxQjTB7oCqBq2QNQ64pOFjXM9eeV0C1L4sWiTFws4yCnY0s/Byf9g3rw+2UtWzTQN 255D/2N40cQPLrtRE4y3G942WsJSIrLrzLpAeYDzoX4xNPjP7RiyjOH9nBh8c1naS1XWvQBsy LZPQ6cSkRvT6Mx1jSDk6TbjoLvWgMkqIrVqRzrJvhp/WWZ1ZqlQlo9h8e1JCKEso0PuAdWOtK M3usONgiF/WgxUAAxQH9lJ4g7TYL24R9TMqiYYrfX7/lhlcm35qtsWTDvM8RhEcqiOGU+eEAF De4RGR8WJxP1hp1KHt93FnT6BG+RDWlFWEBgFlp64hELk/o8R8NufMk4hDihjnJ6eKSMpLJ9+ roejFp7iparWzYnt2+32nSDg7FeMmsL4UZhtUYSCrm7+YsIrKwAe2+w6Dka18SkFF3pISYkfC 4iJgzxqv9oCgJ+XjG++/hLf5WsLHYTxBvK3CQHLYV4PsWwJ3Pa/G4CPxpzvzCKp5mWCDRZSRK eKrYObwiet9XxPWEMtjBdB31UcOVQyE8CbU03Bj6KI/hmSGnTEYQ3bifa2V9o+PmVgtR86Hvw Z5tHZvUYqagD8I7fmW30hdtNTOlDkuxtuLQu7U3mmoKdZH4JGiVSZnw/bS6hO1alkgHGawciw 9rXV4814XBmh77zOzdGuW+ytI5ftKDiE0Oo71BkkueqVmSGous= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 25 Aug 2017 21:34:44 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/scsi/sd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index bea36adeee17..1f15c31e5a8a 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3067,11 +3067,8 @@ static int sd_revalidate_disk(struct gendisk *disk) goto out; buffer = kmalloc(SD_BUF_SIZE, GFP_KERNEL); - if (!buffer) { - sd_printk(KERN_WARNING, sdkp, "sd_revalidate_disk: Memory " - "allocation failure.\n"); + if (!buffer) goto out; - } sd_spinup_disk(sdkp); -- 2.14.0