From: Liu Peibao <liupeibao@163.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] init/main.c: fix strings split across lines
Date: Wed, 13 Jan 2021 10:02:19 +0800 [thread overview]
Message-ID: <6843b1c0-cbea-98c5-4c37-6a5aae25893e@163.com> (raw)
In-Reply-To: <20210112161124.2789c67e@gandalf.local.home>
On 1/13/21 5:11 AM, Steven Rostedt wrote:
> On Tue, 12 Jan 2021 22:26:21 +0800
> Liu Peibao <liupeibao@163.com> wrote:
>
>> Thanks for your replay! I get it.
>> But I still feel a little confused that we use different standard to
>> measure the existing code and the new code. I also checked some commits,
>> there are similar patches too.
>
> For the reason of different standards for existing code to new code. Think
> of it as a "grandfather clause". Where rules change for new instantiations,
> but if you already have something, you can still use the old rules. Hmm,
> it's kind of like how RCU works!
>
> As for some commits getting it. They sometimes get pulled in by various
> maintainers, and also may happen if you are changing the code around
> something. With the "one commit does one thing", you can have a "clean up
> code" patch followed by a "change the code" patch. matters what the context
> is.
>
> -- Steve
>
Whoa, the RCU example is really amazing!
Thanks for your detailed explanation.
BR,
Peibao
next prev parent reply other threads:[~2021-01-13 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 6:04 Review request 0/2: init/main.c: sink the kernel_init to the bottom Liu Peibao
2020-12-30 6:04 ` [PATCH 1/2] init/main.c: fix strings split across lines Liu Peibao
2021-01-12 0:02 ` Steven Rostedt
2021-01-12 14:26 ` Liu Peibao
2021-01-12 21:11 ` Steven Rostedt
2021-01-13 2:02 ` Liu Peibao [this message]
2020-12-30 6:04 ` [PATCH 2/2] init/main.c: sink the kernel_init to the bottom Liu Peibao
2021-01-12 0:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6843b1c0-cbea-98c5-4c37-6a5aae25893e@163.com \
--to=liupeibao@163.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®