From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E26617DE36; Fri, 18 Oct 2024 09:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729242127; cv=none; b=WbEiuvpy5oCjDZ0zRcOx3GQzUQdkpUZP3RJKgRJ6kGop1czIeAgHZnHvqjLSdS/RQK4aTzXL8DVydOCmNEEi2/GnmV0JREdeHLCh+PnB1iEGX3L/Aq8JFR1cNV84cOCzsN8UjdC97EMf5rHAJBAbtRu6Ktf4fCba7ICHSeY6xmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729242127; c=relaxed/simple; bh=5zevuy9/0H8ybeszjdKv6ORtzNZwJb6hVxMXGIrm4Po=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IfhkmqschnYtr5uqUAyujuTeLf+sCmso3Scw5FohnwIc9F2yq5EYyYuhhlm62FbqloyjdLcN0NRTADHNBX1iMYcJI0wGgV8FP0Zi4yjpCY99Qje8f1qyQhqbFewOqCpb12+z8BzVijYhj36VcUWLPfUtlxEC8K3PuR0J5f1WVMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=G3Yj21Bk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="G3Yj21Bk" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49I6KYoF006874; Fri, 18 Oct 2024 09:01:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /xq50zskWssdL5cb4gep6QWqjz2fidOOlyXs84vf6mI=; b=G3Yj21BkASf/WL0Q uEMw/fAvBiQCuFSFAI+BmeiQ7dFCC8RBQCdnGWDYY+YkM6+Go+rfg/annN2edvpY S2fRg+3k/XfxGrMEbvxgBfHJkC81O/be+kH6Otuc4xxMbKbETYSk6ayeR+dudTcH yH4fIYubJQqsY2ni4JcfwVTnDoqy7rRZV9QDniIF8Qody6vjB8TnR39mCVohN6Yv 6+iBY9mBeM11loxeR7Pp24XosRaRoZSq+/Zg64UP0oMrKro+tF6kZaV3woUIMNzJ 8o6ZRQ8vjwgc8yd1ctehJlHocVVKUG2ktI/rvDoZa5s4VScc8+BtxjuSmODi3ORA Sri4Ag== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42b5hstfgb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Oct 2024 09:01:57 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 49I91uuj025280 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Oct 2024 09:01:56 GMT Received: from [10.233.17.145] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 18 Oct 2024 02:01:51 -0700 Message-ID: <684582c3-3559-4c54-8257-cb952bbfe2ec@quicinc.com> Date: Fri, 18 Oct 2024 17:01:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] phy: qcom: qmp-usbc: Add qmp configuration for QCS615 To: Dmitry Baryshkov CC: Krishna Kurapati , Vinod Koul , Krzysztof Kozlowski , Rob Herring , Kishon Vijay Abraham I , "Bjorn Andersson" , Wesley Cheng , Konrad Dybcio , "Conor Dooley" , Greg Kroah-Hartman , Manivannan Sadhasivam , , , , , , , References: <20241017130701.3301785-1-quic_kriskura@quicinc.com> <20241017130701.3301785-6-quic_kriskura@quicinc.com> From: Tingwei Zhang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GypxlSRqaNk_gTLWXB9lyjej6lAJ0ETH X-Proofpoint-ORIG-GUID: GypxlSRqaNk_gTLWXB9lyjej6lAJ0ETH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410180057 On 10/18/2024 4:06 PM, Dmitry Baryshkov wrote: > On Fri, 18 Oct 2024 at 10:48, Tingwei Zhang wrote: >> >> On 10/18/2024 2:27 AM, Dmitry Baryshkov wrote: >>> On Thu, 17 Oct 2024 at 16:07, Krishna Kurapati >>> wrote: >>>> >>>> Provide PHY configuration for the USB QMP PHY for QCS615 Platform. >>>> >>>> Signed-off-by: Krishna Kurapati >>>> Reviewed-by: Dmitry Baryshkov >>> >>> After checking platform details, >>> >>> Unreviewed-by: Dmitry Baryshkov >>> >>> Please perform global s/QCS615/SM6150/ and s/qcs615/sm6150/ >> >> QCS615 and SM6150 are different variants of the same SoC. QCS615 is an >> IoT variant, while SM6150 is a mobile variant. We are currently adding >> QCS615 SoC support to the upstream Kernel, as it is in an active >> development stage and we anticipate many products based on this SoC. On >> the other hand, the SM6150 is an older mobile platform that is unlikely >> to be used in new designs. For a product introduction of the QCS615, >> please refer to >> https://docs.qualcomm.com/bundle/publicresource/87-83838-1_REV_A_Qualcomm_IQ6_Series_Product_Brief.pdf > > Yes, I guessed so. It would have been nice if it was documented this > way from the beginning. > > Please note that we usually get support for the mobile SoC first. So > in most of the cases devices use mobile compatible even for IoT > platforms, see qrb5165, qrb4210, qcm6490 and other similar platforms. > I simply asked to follow the established pattern. Yes, we start from mobile variant for most of the platforms. There are some exceptions like sc7180 and sc7280 which we started from compute variant since they are widely used by compute platform on upstream Kernel. I think we have similar case here. QCS615 will be widely used by IOT products on upstream Kernel. We should have clarified this from beginning so there's no ambiguity. > >> >>> >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c >>>> index d4fa1063ea61..c56ba8468538 100644 >>>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c >>>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c >>>> @@ -1123,6 +1123,9 @@ static const struct of_device_id qmp_usbc_of_match_table[] = { >>>> }, { >>>> .compatible = "qcom,qcm2290-qmp-usb3-phy", >>>> .data = &qcm2290_usb3phy_cfg, >>>> + }, { >>>> + .compatible = "qcom,qcs615-qmp-usb3-phy", >>>> + .data = &qcm2290_usb3phy_cfg, >>>> }, { >>>> .compatible = "qcom,sdm660-qmp-usb3-phy", >>>> .data = &sdm660_usb3phy_cfg, >>>> -- >>>> 2.34.1 >>>> >>> >>> >> >> >> -- >> Thanks, >> Tingwei > > > -- Thanks, Tingwei