From: Miaohe Lin <linmiaohe@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function
Date: Thu, 25 Apr 2024 14:25:24 +0800 [thread overview]
Message-ID: <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com> (raw)
In-Reply-To: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com>
On 2024/4/24 0:14, Andy Shevchenko wrote:
> In some configurations I got
> mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> Becuase the only user is guarged with a certain ifdeffery,
guarged? ifdeffery?
> do the same for add_to_free_list().
A Fixes tag might be needed.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Anyway, this patch looks good to me. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks.
.
next prev parent reply other threads:[~2024-04-25 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 16:14 Andy Shevchenko
2024-04-23 18:10 ` Andrew Morton
2024-04-23 18:27 ` Andy Shevchenko
2024-04-23 20:30 ` Johannes Weiner
2024-04-23 20:45 ` Andy Shevchenko
2024-04-25 6:25 ` Miaohe Lin [this message]
2024-04-25 9:15 ` Andy Shevchenko
2024-04-25 9:45 ` Andy Shevchenko
2024-04-25 11:23 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68489f85-5579-5cff-eed1-55ae585916f3@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®