From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B09C433EF for ; Fri, 15 Apr 2022 00:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348191AbiDOAuk (ORCPT ); Thu, 14 Apr 2022 20:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237187AbiDOAug (ORCPT ); Thu, 14 Apr 2022 20:50:36 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65165B822C for ; Thu, 14 Apr 2022 17:48:10 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id p10so11761540lfa.12 for ; Thu, 14 Apr 2022 17:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=BycpfwmzoR4vzcAZR2CT84zb+01RL1PgdUJzETRbklU=; b=NBQEoiYmC/899Hw9WnmJ+R+JGTM5xfbrHKBaRot/VLZdi5oUx132Hm34eKvvuzCQq4 wKW7E6pru0TICqR+6kebPpRT6Vcb53nbTvdPh+5Uz4BRRilxTNIguBHGly9DxV520Zhu ZRc7hnUYVvPL3q5Muo7vIDSv5MrJ8J+Bgk6L1tyCvJ4P7FK6ZeNidUaxmu9v78STJr7U 7/cNbXOQrTXbCWDTs3iSe+ad3Err8qBiC33WZfzyagj4X3erSZrykwgp9WxLmXP4z87u yjSnHSWEO37JgM+CUb6PXghGg0BXDK9u1oeb+Oq6pwVMV2jqzjMiE33pmH7YNUhZvRZi wGtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BycpfwmzoR4vzcAZR2CT84zb+01RL1PgdUJzETRbklU=; b=oE9v059LJS7POroFhed9ndIU1ZZeHl7KT5v9xMXXb/WsJ3XrynpW7LiVedWMCzDPIE KjWs04rRTO2NsBbfW64ZikzQNn+Og7SWeWIuvia+VadfxJcnr5qskojQyqYMXdqCxF0W 11xF0UvfuKFMEyCASlUHY3/m8JLJ+JOmtJqWjLlVhti6mu1pg+e9yqVVw1nPKyNIFGum VJyxpuCmWwT11RZIFjEiSAuCnxM3bGJDLhSxfYIGAC3k2YDi4MfveVcaYhjmFqx4I04u 0hvm1eYYfvRbHvr8pVhb2pbRD3gY2qK7MK3a1J9qDWAkXkQmZcpVkSGn5VAkx3jW5ahI 5f6g== X-Gm-Message-State: AOAM530l/TDYVuWYB96BVj/8h6tQazYfUPRHfOHrdNuEA0ww1jBCfwEe 2dCiQUaprb6QbVF+zP5nZucT6w== X-Google-Smtp-Source: ABdhPJwbti2aqvzvc7DFdbELNEMXxtK8iweXhJZDxAE3gj2VfSKrWrYUMtY4ksILtWY52drF7E1T9w== X-Received: by 2002:ac2:4e11:0:b0:46b:a38d:686a with SMTP id e17-20020ac24e11000000b0046ba38d686amr3522985lfr.564.1649983688700; Thu, 14 Apr 2022 17:48:08 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id p24-20020a2ea418000000b0024b5b76a06csm139293ljn.12.2022.04.14.17.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 17:48:08 -0700 (PDT) Message-ID: <68538a58-54e2-e82e-0789-52eb1cc6b66a@linaro.org> Date: Fri, 15 Apr 2022 03:48:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH 3/6] drm/dp: Add is_hpd_asserted() callback to struct drm_dp_aux Content-Language: en-GB To: Douglas Anderson , dri-devel@lists.freedesktop.org Cc: Robert Foss , Hsin-Yi Wang , Abhinav Kumar , Sankeerth Billakanti , Philip Chen , Stephen Boyd , Daniel Vetter , David Airlie , Jani Nikula , Kees Cook , Lyude Paul , Maxime Ripard , linux-kernel@vger.kernel.org References: <20220409023628.2104952-1-dianders@chromium.org> <20220408193536.RFC.3.Icf57bb12233a47727013c6ab69eebf803e22ebc1@changeid> From: Dmitry Baryshkov In-Reply-To: <20220408193536.RFC.3.Icf57bb12233a47727013c6ab69eebf803e22ebc1@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/2022 05:36, Douglas Anderson wrote: > Sometimes it's useful for users of the DP AUX bus (like panels) to be > able to poll HPD. Let's add a callback that allows DP AUX busses > drivers to provide this. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov > --- > > include/drm/dp/drm_dp_helper.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/drm/dp/drm_dp_helper.h b/include/drm/dp/drm_dp_helper.h > index dad1442c91df..a12951319573 100644 > --- a/include/drm/dp/drm_dp_helper.h > +++ b/include/drm/dp/drm_dp_helper.h > @@ -2021,6 +2021,20 @@ struct drm_dp_aux { > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > > + /** > + * @is_hpd_asserted: returns true if HPD is asserted > + * > + * This is mainly useful for eDP panels drivers to query whether > + * an eDP panel has finished powering on. This is an optional function. > + * > + * NOTE: this function specifically reports the state of the HPD pin > + * that's associated with the DP AUX channel. This is different from > + * the HPD concept in much of the rest of DRM which is more about > + * physical presence of a display. For eDP, for instance, a display is > + * assumed always present even if the HPD pin is deasserted. > + */ > + bool (*is_hpd_asserted)(struct drm_dp_aux *aux); > + > /** > * @i2c_nack_count: Counts I2C NACKs, used for DP validation. > */ -- With best wishes Dmitry