Re: [RFC PATCH v6 2/3] Tracepoint API doc update: data argument

[Mathieu Desnoyers <mathieu.desnoyers@efficios.com>]

----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frederic Weisbecker" <fweisbec@gmail.com>,
> "Andrew Morton" <akpm@linux-foundation.org>
> Sent: Wednesday, March 19, 2014 11:01:32 PM
> Subject: Re: [RFC PATCH v6 2/3] Tracepoint API doc update: data argument
> 
> On Wed, 19 Mar 2014 18:31:01 -0400
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> 
> > Describe the @data argument (probe private data).
> 
> As you probably noticed, I added your previous patch to my tree.
> You don't need to keep this with your patches.

OK, thanks!

Mathieu

> 
> -- Steve
> 
> > 
> > Fixes: 38516ab59fbc "tracing: Let tracepoints have data passed to
> > tracepoint callbacks"
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > CC: Steven Rostedt <rostedt@goodmis.org>
> > CC: Ingo Molnar <mingo@kernel.org>
> > CC: Frederic Weisbecker <fweisbec@gmail.com>
> > CC: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >  kernel/tracepoint.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
> > index f27e5f0..2e4bfcb 100644
> > --- a/kernel/tracepoint.c
> > +++ b/kernel/tracepoint.c
> > @@ -370,6 +370,7 @@ tracepoint_add_probe(const char *name, void *probe,
> > void *data)
> >   * tracepoint_probe_register -  Connect a probe to a tracepoint
> >   * @name: tracepoint name
> >   * @probe: probe handler
> > + * @data: probe private data
> >   *
> >   * Returns 0 if ok, error value on error.
> >   * The probe address must at least be aligned on the architecture pointer
> >   size.
> > @@ -412,6 +413,7 @@ tracepoint_remove_probe(const char *name, void *probe,
> > void *data)
> >   * tracepoint_probe_unregister -  Disconnect a probe from a tracepoint
> >   * @name: tracepoint name
> >   * @probe: probe function pointer
> > + * @data: probe private data
> >   *
> >   * We do not need to call a synchronize_sched to make sure the probes have
> >   * finished running before doing a module unload, because the module
> >   unload
> 
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com