From: "Luca Tettamanti" <kronos.it@gmail.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: "Tejun Heo" <htejun@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_jmicron: remove spurious #endif
Date: Mon, 5 Mar 2007 23:53:03 +0100 [thread overview]
Message-ID: <68676e00703051453l1ccfb63dtf7e90d9ff3fd3155@mail.gmail.com> (raw)
In-Reply-To: <45EC94CB.6080903@intel.com>
On 3/5/07, Kok, Auke <auke-jan.h.kok@intel.com> wrote:
> Luca Tettamanti wrote:
> > Hello,
> > commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:
> >
> > CC drivers/ata/pata_jmicron.o
> > /home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if
> > make[3]: *** [drivers/ata/pata_jmicron.o] Error 1
> >
> > Remove a spurious #endif in pata_jmicron driver.
>
> I think the problem is that Tejun forgot to *add* a #ifdef CONFIG_PM instead.
Nope, that #endif was after the jmicron_exit() function which is
unrelated with CONFIG_PM. I see that Jeff has already commited a
similar patch, mine is no longer needed.
Luca
prev parent reply other threads:[~2007-03-05 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 20:15 Luca Tettamanti
2007-03-05 22:08 ` Kok, Auke
2007-03-05 22:53 ` Luca Tettamanti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68676e00703051453l1ccfb63dtf7e90d9ff3fd3155@mail.gmail.com \
--to=kronos.it@gmail.com \
--cc=auke-jan.h.kok@intel.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®