From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AFBD42E00E for ; Tue, 20 Jan 2026 12:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913896; cv=none; b=QQzIse2mlVI8btJ6trapcqfvy7JS0s6DnNtcXFkzAxtGD6BQfZHkF8xTOmKKQQf5mOfp0XHEAB3jwsjwmwAFWQwkHq60RjvTLW+S18jSKnKMknir/28ULs6miFQkCv7c7ZoKm1M4WdPBOPsn2pmVKR4Zc//yFb/9M6DaXejtJLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913896; c=relaxed/simple; bh=hKeqLev84N0DuH1Em5Q0wdUuyDX34lo15tHBgleTsSk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mRaZlGNecV5ear0hOexsay8EYUrPHheB2iYhEthNUpC88YOOQWmkVl+0vKx+bcV/mkD4b+CtGr8AR/Oe52IMb6PF8Q+csgYpvdlKR1LmIKGz/+MV1rspt/+DB8awFld8mbCYKJn6A7johctpMczGHF4hQfAr4yj6xWhZON7NtUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=CQ3rS7A0; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=EMcGt/wX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=CQ3rS7A0; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=EMcGt/wX; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="CQ3rS7A0"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="EMcGt/wX"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="CQ3rS7A0"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="EMcGt/wX" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 83C475BCC9; Tue, 20 Jan 2026 12:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768913892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+qJs6bVpqnwm8lHKbWUBls2B4XnqyQPllX7JX0zzKkk=; b=CQ3rS7A0N9VaHm5fdzHOEPgTEq7VaAO/H5qGTsISnDsLxcK9WCHwdIcBlIxNTPW/qJyKW+ jg0xeS7Lu3+mA38JqGEx88yulj8wff6TiSFXG/9P9L4qcyzzhgw50Nex5N0S516jju2Vp1 gUtskmpEMlHiFCRQa2kT+erO94Ndu5A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768913892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+qJs6bVpqnwm8lHKbWUBls2B4XnqyQPllX7JX0zzKkk=; b=EMcGt/wXdx8NtqF8WvNqGe/hrmtQ5aN2Mr8g0+KpIK0tAMHhohPx2GbMmEW51Pb0SiU+zT 71BLGROPXJxC8mAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CQ3rS7A0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="EMcGt/wX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768913892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+qJs6bVpqnwm8lHKbWUBls2B4XnqyQPllX7JX0zzKkk=; b=CQ3rS7A0N9VaHm5fdzHOEPgTEq7VaAO/H5qGTsISnDsLxcK9WCHwdIcBlIxNTPW/qJyKW+ jg0xeS7Lu3+mA38JqGEx88yulj8wff6TiSFXG/9P9L4qcyzzhgw50Nex5N0S516jju2Vp1 gUtskmpEMlHiFCRQa2kT+erO94Ndu5A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768913892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+qJs6bVpqnwm8lHKbWUBls2B4XnqyQPllX7JX0zzKkk=; b=EMcGt/wXdx8NtqF8WvNqGe/hrmtQ5aN2Mr8g0+KpIK0tAMHhohPx2GbMmEW51Pb0SiU+zT 71BLGROPXJxC8mAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 25EAC3EA63; Tue, 20 Jan 2026 12:58:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fBgMCOR7b2nwBAAAD6G6ig (envelope-from ); Tue, 20 Jan 2026 12:58:12 +0000 Message-ID: <686d24ee-c37d-4983-9984-2bbb4543395f@suse.de> Date: Tue, 20 Jan 2026 13:58:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/8] drm/rockchip: vop2: Fix Esmart test condition To: Nicolas Frattaroli , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Stone References: <20251206-vop2-atomic-fixups-v2-0-7fb45bbfbebd@collabora.com> <20251206-vop2-atomic-fixups-v2-3-7fb45bbfbebd@collabora.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20251206-vop2-atomic-fixups-v2-3-7fb45bbfbebd@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[collabora.com,rock-chips.com,sntech.de,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,collabora.com:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Flag: NO X-Spam-Score: -4.51 X-Rspamd-Queue-Id: 83C475BCC9 X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: Hi Am 06.12.25 um 21:45 schrieb Nicolas Frattaroli: > From: Daniel Stone > > If we want to find out if a window is Esmart or not, test for not being > a cluster window, rather than AFBDC presence. > > No functional effect as only cluster windows support AFBC decode. > > Signed-off-by: Daniel Stone > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 81b3eba07095..9d715d7659af 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -1230,12 +1230,10 @@ static void vop2_plane_atomic_update(struct drm_plane *plane, > * This is workaround solution for IC design: > * esmart can't support scale down when src_w % 16 == 1. > */ > - if (!(win->data->feature & WIN_FEATURE_AFBDC)) { > - if (src_w > dsp_w && (src_w & 0xf) == 1) { > - drm_dbg_kms(vop2->drm, "vp%d %s act_w[%d] MODE 16 == 1\n", > - vp->id, win->data->name, src_w); > - src_w -= 1; > - } > + if (!vop2_cluster_window(win) && src_w > dsp_w && (src_w & 1)) { > + drm_dbg_kms(vop2->drm, "vp%d %s act_w[%d] MODE 16 == 1\n", > + vp->id, win->data->name, src_w); Drivers should usually be using drm_dbg(), drm_err(), drm_warn() etc. Print functions with _kms postfix are for the DRM helpers. Here and in all other patches. Best regards Thomas > + src_w -= 1; > } > > if (afbc_en && src_w % 4) { > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)