From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8791BC77B73 for ; Thu, 20 Apr 2023 10:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235075AbjDTKxI (ORCPT ); Thu, 20 Apr 2023 06:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235057AbjDTKwo (ORCPT ); Thu, 20 Apr 2023 06:52:44 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA8B27D9A for ; Thu, 20 Apr 2023 03:50:08 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ec81436975so478410e87.0 for ; Thu, 20 Apr 2023 03:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681987787; x=1684579787; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=InyLlK4ZtefcdVP8ZL9xZOCBp894Qu9V02DBGf4WABw=; b=hwxCE0kwvpWsmhPDmqhYOWdsEvTGtOMuY9PfG9/0bBzNaMSaIPbHp7grf4S6EUuSgH HIQh40NwJcX+xqX/l+oMjW6uj5YaYoLGZ+FOSzT4lqHRa5oW/m62IqHkXUHGNjpgKEoZ Wfg8yH0ShGhjLPD7LA25IWjzz7RhDGjOzaH4jVq6+Sr2JDyzuz7tsN5IeNr4wZS4YqOs FuzLdXyXq6s1HieL9s5kQ0n3IZIwFOWo3czcw1hhuXSpI+B/hOPDc7X6dJ+Kr8BtC8+H h7o+empLmdYjc0kTf039TeD7PSceGZ3ZjUv7LCa3PxO/IpNUm8NWAiN9RM5ghYNa78xt QBwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681987787; x=1684579787; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=InyLlK4ZtefcdVP8ZL9xZOCBp894Qu9V02DBGf4WABw=; b=MPTHAPd7a3vkbdEwumrIxMjDLDNUqc1V/q1hx0wKX/Oo52pPCcTLC56fvtIOZ25REA IS4PSVywL0V0QbzHG3uu3Ys84uQp6bmOHhEBC2KSsilZf5PbBi/lVfsuHkAYrXc+gbMs fQEzWH5OB4cnwrgXugAxb+0v1bfF/0i79j456G+za/93PMnIYNbZSkR9eHWOM1c24pHF 7V2tm9YVnUMXTLEl5KfQcpPaGt5xsuEenvTssLaf3a+62ScaNX/LqcbCtf0AGADqYd2x e81+mDpsBqZcE9SBS5Se6+rrv79FP62DfcARbeKOGo65WIlQ59YSRh2XRMotK6x0nHT0 Ek5g== X-Gm-Message-State: AAQBX9eWunp2iscY4gEAkgWWRGu8Lc3zTCCxcAXofpxCRl8BMFAkT6En TNsoPigEAMzjT2bHL6jMXhY1hw== X-Google-Smtp-Source: AKy350YSZFVa83jooVWaAgBJ/WWjOs/wEnd2zsHegiDhOqtGMl92F7BKp48PPSVqPUqqkJgLz0LjXg== X-Received: by 2002:a05:6512:38af:b0:4ed:d216:8217 with SMTP id o15-20020a05651238af00b004edd2168217mr292199lft.11.1681987786777; Thu, 20 Apr 2023 03:49:46 -0700 (PDT) Received: from [192.168.1.101] (abyj144.neoplus.adsl.tpnet.pl. [83.9.29.144]) by smtp.gmail.com with ESMTPSA id p16-20020a05651211f000b004edc5a39121sm172914lfs.242.2023.04.20.03.49.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 03:49:46 -0700 (PDT) Message-ID: <686ee776-8f5f-9814-1f89-0ab9f0e7b2b8@linaro.org> Date: Thu, 20 Apr 2023 12:49:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 08/10] ARM: dts: qcom: apq8060-dragonboard: move regulators out of simple-bus Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230420075053.41976-1-krzysztof.kozlowski@linaro.org> <20230420075053.41976-8-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230420075053.41976-8-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.04.2023 09:50, Krzysztof Kozlowski wrote: > Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs > W=1 warnings: > > Warning (simple_bus_reg): /regulators/regulator-fixed: missing or empty reg/ranges property > Warning (simple_bus_reg): /regulators/xc622a331mrg: missing or empty reg/ranges property > Warning (simple_bus_reg): /regulators/nds332p: missing or empty reg/ranges property > Warning (simple_bus_reg): /regulators/txb0104rgyr: missing or empty reg/ranges property > > Signed-off-by: Krzysztof Kozlowski > --- > .../arm/boot/dts/qcom-apq8060-dragonboard.dts | 80 +++++++++---------- > 1 file changed, 38 insertions(+), 42 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts > index 8e4b61e4d4b1..e830cb2395aa 100644 > --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts > +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts > @@ -18,50 +18,46 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > - regulators { > - compatible = "simple-bus"; > - > - /* Main power of the board: 3.7V */ > - vph: regulator-fixed { > - compatible = "regulator-fixed"; > - regulator-min-microvolt = <3700000>; > - regulator-max-microvolt = <3700000>; > - regulator-name = "VPH"; > - regulator-type = "voltage"; > - regulator-always-on; > - regulator-boot-on; > - }; > - > - /* GPIO controlled ethernet power regulator */ > - dragon_veth: xc622a331mrg { > - compatible = "regulator-fixed"; > - regulator-name = "XC6222A331MR-G"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > - vin-supply = <&vph>; > - gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>; > - enable-active-high; > - pinctrl-names = "default"; > - pinctrl-0 = <&dragon_veth_gpios>; > - regulator-always-on; > - }; > + /* Main power of the board: 3.7V */ > + vph: regulator-fixed { > + compatible = "regulator-fixed"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + regulator-name = "VPH"; > + regulator-type = "voltage"; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + /* GPIO controlled ethernet power regulator */ > + dragon_veth: xc622a331mrg { These names could also be fixed up, but that's for another day.. Reviewed-by: Konrad Dybcio Konrad > + compatible = "regulator-fixed"; > + regulator-name = "XC6222A331MR-G"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vph>; > + gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + pinctrl-names = "default"; > + pinctrl-0 = <&dragon_veth_gpios>; > + regulator-always-on; > + }; > > - /* VDDvario fixed regulator */ > - dragon_vario: nds332p { > - compatible = "regulator-fixed"; > - regulator-name = "NDS332P"; > - regulator-min-microvolt = <1800000>; > - regulator-max-microvolt = <1800000>; > - vin-supply = <&pm8058_s3>; > - }; > + /* VDDvario fixed regulator */ > + dragon_vario: nds332p { > + compatible = "regulator-fixed"; > + regulator-name = "NDS332P"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&pm8058_s3>; > + }; > > - /* This is a levelshifter for SDCC5 */ > - dragon_vio_txb: txb0104rgyr { > - compatible = "regulator-fixed"; > - regulator-name = "Dragon SDCC levelshifter"; > - vin-supply = <&pm8058_l14>; > - regulator-always-on; > - }; > + /* This is a levelshifter for SDCC5 */ > + dragon_vio_txb: txb0104rgyr { > + compatible = "regulator-fixed"; > + regulator-name = "Dragon SDCC levelshifter"; > + vin-supply = <&pm8058_l14>; > + regulator-always-on; > }; > > /*