From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbdKCO72 (ORCPT ); Fri, 3 Nov 2017 10:59:28 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50357 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbdKCO70 (ORCPT ); Fri, 3 Nov 2017 10:59:26 -0400 X-Google-Smtp-Source: ABhQp+QHalq3y0qguvI77KUlmCi1MS7+NCRbMiPuVXJYNiJYVYMXJpcUWBicTEm+Np80DroLtt/b0g== Subject: Re: [PATCH] soc: amlogic: gx pm domain: add PM and OF dependencies To: Arnd Bergmann , Kevin Hilman , Martin Blumenstingl Cc: linux-kernel@vger.kernel.org References: <20171102224256.1686675-1-arnd@arndb.de> From: Neil Armstrong Organization: Baylibre Message-ID: <68709b1d-4c16-dc8b-e315-d1e4bb10b6f2@baylibre.com> Date: Fri, 3 Nov 2017 15:59:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102224256.1686675-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2017 23:42, Arnd Bergmann wrote: > The new driver introduces harmless warnings: > > warning: (PM_RMOBILE && ARCH_RCAR_GEN1 && ARCH_RCAR_GEN2 && ARCH_R7S72100 && MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM) > warning: (MESON_GX_PM_DOMAINS) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > This adds CONFIG_OF and CONFIG_PM dependencies to ensure it > will only be enabled in valid configurations. > > Fixes: 75fcb5ca4b46 ("soc: amlogic: add Meson GX VPU Domains driver") > Signed-off-by: Arnd Bergmann > --- > drivers/soc/amlogic/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig > index 1621bb25a1ea..b04f6e4aedbc 100644 > --- a/drivers/soc/amlogic/Kconfig > +++ b/drivers/soc/amlogic/Kconfig > @@ -12,6 +12,7 @@ config MESON_GX_SOCINFO > config MESON_GX_PM_DOMAINS > bool "Amlogic Meson GX Power Domains driver" > depends on ARCH_MESON || COMPILE_TEST > + depends on PM && OF > default ARCH_MESON > select PM_GENERIC_DOMAINS > select PM_GENERIC_DOMAINS_OF > Thanks for the fix Acked-by: Neil Armstrong