From: Alexander Tsoy <alexander@tsoy.me>
To: vincenttew <vincenttew@google.com>,
perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: retry clock validate when it takes some times
Date: Thu, 01 Feb 2024 13:36:11 +0300 [thread overview]
Message-ID: <6872e9ea993633dff4e248f01cafd1ac32651355.camel@tsoy.me> (raw)
In-Reply-To: <20240201070641.401684-1-vincenttew@google.com>
В Чт, 01/02/2024 в 15:06 +0800, vincenttew пишет:
> Behringer UMC202HD and UMC404HD take some times to validate the clock
> source. To prevent more DAC have the same delay which return the
> false
> in the first time, remove the USB id check to have a chance to retry
> the
> clock validate.
>
> Signed-off-by: vincenttew <vincenttew@google.com>
Thank you for the patch! My thought about this change:
- Retrying clock source validation probably make sense only in the case
of Internal clock. But I'm not sure.
- If we want to make this a standard driver behaviour, then the code
needs to be moved out of the quirk function IMO.
next prev parent reply other threads:[~2024-02-01 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 7:06 vincenttew
2024-02-01 10:36 ` Alexander Tsoy [this message]
2024-02-01 13:02 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6872e9ea993633dff4e248f01cafd1ac32651355.camel@tsoy.me \
--to=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vincenttew@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®