mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: mathieu.desnoyers@efficios.com, peterz@infradead.org,
	boqun.feng@gmail.com,  tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de,  dave.hansen@linux.intel.com, hpa@zytor.com,
	aruna.ramakrishna@oracle.com,  elver@google.com
Cc: Dmitry Vyukov <dvyukov@google.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	x86@kernel.org,  linux-kernel@vger.kernel.org
Subject: [PATCH v6 2/4] x86/signal: Use write_permissive_pkey_val() helper
Date: Thu, 27 Feb 2025 15:03:13 +0100	[thread overview]
Message-ID: <6873fab2d09be6a4254201391872daf0c455b5cd.1740664852.git.dvyukov@google.com> (raw)
In-Reply-To: <cover.1740664852.git.dvyukov@google.com>

Use the new switch_to_permissive_pkey_reg() helper instead of the
custom code. No functional changes intended.

Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org

---
Changes in v3:
 - restore sig_prepare_pkru with the large comment and
   make it call the new write_permissive_pkey_val
---
 arch/x86/kernel/signal.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index 5f441039b5725..27a66a0697dd2 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -28,6 +28,7 @@
 #include <linux/entry-common.h>
 #include <linux/syscalls.h>
 #include <linux/rseq.h>
+#include <linux/pkeys.h>
 
 #include <asm/processor.h>
 #include <asm/ucontext.h>
@@ -72,10 +73,7 @@ static inline int is_x32_frame(struct ksignal *ksig)
  */
 static inline u32 sig_prepare_pkru(void)
 {
-	u32 orig_pkru = read_pkru();
-
-	write_pkru(0);
-	return orig_pkru;
+	return write_permissive_pkey_val();
 }
 
 /*
-- 
2.48.1.658.g4767266eb4-goog


  parent reply	other threads:[~2025-02-27 14:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 14:03 [PATCH v6 0/4] rseq: Make rseq work with protection keys Dmitry Vyukov
2025-02-27 14:03 ` [PATCH v6 1/4] pkeys: add API to switch to permissive/zero pkey register Dmitry Vyukov
2025-02-27 14:03 ` Dmitry Vyukov [this message]
2025-02-27 14:03 ` [PATCH v6 3/4] rseq: Make rseq work with protection keys Dmitry Vyukov
2025-03-08 10:02   ` Dmitry Vyukov
2025-03-10 14:31     ` Mathieu Desnoyers
2025-03-10 14:39       ` Dmitry Vyukov
2025-03-10 18:51         ` Ingo Molnar
2025-03-10 14:26   ` Mathieu Desnoyers
2025-02-27 14:03 ` [PATCH v6 4/4] selftests/rseq: Add test for rseq+pkeys Dmitry Vyukov
2025-03-10 14:30   ` Mathieu Desnoyers
2025-03-10 14:36     ` Dmitry Vyukov
2025-03-10 14:38       ` Mathieu Desnoyers
2025-03-10 14:43         ` Dmitry Vyukov
2025-03-10 15:41           ` Mathieu Desnoyers
2025-03-10 16:31             ` Dmitry Vyukov
2025-03-10 17:26               ` Mathieu Desnoyers
2025-05-21  8:57                 ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6873fab2d09be6a4254201391872daf0c455b5cd.1740664852.git.dvyukov@google.com \
    --to=dvyukov@google.com \
    --cc=aruna.ramakrishna@oracle.com \
    --cc=boqun.feng@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=elver@google.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®