From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2526C433E7 for ; Mon, 12 Oct 2020 15:38:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CFE42087D for ; Mon, 12 Oct 2020 15:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602517108; bh=5ilsmtgrr7sa13By8mYzL3sh1WhWQr5N6nl5iXe8aao=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=uuLkvsPhQltcr+prIrL30cuNWji6L6NEXGgkmuRtcDL+ah9RR+b2E2KKrgJvgc1pz I4XOExrHpPpwn2fPNgZcffAxaUcgjHr38+B2QxLgPn8UUES6a5hr6Mil0KJQG2ufIU U8ikVMqdUoczhwT+v0LkqqmZoyeXs0WgLHEoES2Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390107AbgJLPi1 (ORCPT ); Mon, 12 Oct 2020 11:38:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:43140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388881AbgJLPi1 (ORCPT ); Mon, 12 Oct 2020 11:38:27 -0400 Received: from tzanussi-mobl (c-73-209-127-30.hsd1.il.comcast.net [73.209.127.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 728BB20575; Mon, 12 Oct 2020 15:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602517106; bh=5ilsmtgrr7sa13By8mYzL3sh1WhWQr5N6nl5iXe8aao=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TbgNgzJxo+0FX0UeaezbxCOm1ZqmUmL61RODQXvkh321n/JfvBt8uO5k6J69K6tVD M1JEcgN5KkfhUl1kAfJ16FTb++Q/5KHVtBxK1YvcGGKTLP2b4YVabH4Kc8u3x7SB2G ZxrlBktINi+RnZSYMSNMjFFCj4XCyldsummIjK7Y= Message-ID: <68753123860c684af182bba48e12d7091be44d35.camel@kernel.org> Subject: Re: [PATCH 0/5] tracing: Synthetic event dynamic string fixes From: Tom Zanussi To: Steven Rostedt Cc: axelrasmussen@google.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org Date: Mon, 12 Oct 2020 10:38:25 -0500 In-Reply-To: <20201012111324.0ea933e0@gandalf.local.home> References: <20201012111324.0ea933e0@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On Mon, 2020-10-12 at 11:13 -0400, Steven Rostedt wrote: > On Fri, 9 Oct 2020 10:17:06 -0500 > Tom Zanussi wrote: > > > These patches provide fixes for the problems observed by Masami in > > the > > new synthetic event dynamic string patchset. > > > > The first patch (tracing: Don't show dynamic string internals in > > synthetic event description) removes the __data_loc from the event > > description but leaves it in the format. > > > > The patch (tracing: Add synthetic event error logging) addresses > > the > > lack of error messages when parse errors occur. > > > > The remaining three patches address the other problems Masami noted > > which result from allowing illegal characters in synthetic event > > and > > field names when defining an event. The is_good_name() function is > > used to check that's not possible for the probe events, but should > > also be used for the synthetic events as well. > > > > (tracing: Move is_good_name() from trace_probe.h to trace.h) makes > > that function available to other trace subsystems by putting it in > > trace.h. (tracing: Check that the synthetic event and field names > > are > > legal) applies it to the synthetic events, and (selftests/ftrace: > > Change synthetic event name for inter-event-combined test) changes > > a > > testcase that now fails because it uses an illegal name. > > > > > Hi Tom, > > Would you be able to address Masami's concerns on patches 1 and 4? Yes, I'll submit a v2 fixing those soon (today). Thanks, Tom > > -- Steve