mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/15] staging: rtl8723bs: align asterisk in block comment to fix formatting
Date: Tue, 30 Sep 2025 04:29:26 -0400	[thread overview]
Message-ID: <687549ed-7610-4bd8-ba30-854c99868cc1@gmail.com> (raw)
In-Reply-To: <2025092953-depravity-oasis-93cb@gregkh>

Thanks for pointing it out. Ack. I’ll wait for more comments from the 
community for another three days and then will send the next version.

Best, Vivek

On 2025-09-29 2:58 a.m., Greg KH wrote:
> On Mon, Sep 29, 2025 at 06:49:49AM +0000, Vivek BalachandharTN wrote:
>> Align the leading asterisks in a multi-line block comment to maintain
>> consistent formatting and improve readability,in accordance with kernel
>> coding style guidelines. No functional changes.
>>
>> Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
>> ---
>>   drivers/staging/rtl8723bs/core/rtw_mlme.c | 40 +++++++++++------------
>>   1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> index 3eeea832dcb6..cd41f713a52e 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
>> @@ -869,8 +869,8 @@ static void find_network(struct adapter *adapter)
>>   }
>>   
>>   /*
>> -*rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock
>> -*/
>> + *rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock
> Shouldn't you also have a space after the '*' and before the 'r'?
>
> thanks,
>
> greg k-h

  reply	other threads:[~2025-09-30  8:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29  6:49 [PATCH v3 00/15] rtl8723bs: cleanup and style improvements for better readability Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 01/15] staging: rtl8723bs: fix spacing around operators Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 02/15] staging: rtl8723bs: remove unnecessary space after type cast Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 03/15] staging: rtl8723bs: fix overlong lines to conform with kernel coding style Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 04/15] staging: rtl8723bs: align asterisk in block comment to fix formatting Vivek BalachandharTN
2025-09-29  6:58   ` Greg KH
2025-09-30  8:29     ` Vivek BalachandharTN [this message]
2025-09-29  6:49 ` [PATCH v3 05/15] staging: rtl8723bs: fix logical continuation style by moving to previous line Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 06/15] staging: rtl8723bs: fix indentation to align with open parenthesis Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 07/15] staging: rtl8723bs: adding asterisks in multi-line block comments Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 08/15] staging: rtl8723bs: remove space before semicolon Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 09/15] staging: rtl8723bs: fix excessive indentation in nested if statement Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 10/15] staging: rtl8723bs: fix unbalanced braces around conditional blocks Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 11/15] staging: rtl8723bs: remove unnecessary parentheses in conditional Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 12/15] staging: rtl8723bs: add braces to all arms of conditional statement Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 13/15] staging: rtl8723bs: fix line ending with '(' Vivek BalachandharTN
2025-09-29  6:49 ` [PATCH v3 14/15] staging: rtl8723bs: place constant on right side of comparison Vivek BalachandharTN
2025-09-29  6:50 ` [PATCH v3 15/15] staging: rtl8723bs: merge nested if conditions for clarity and tab problems Vivek BalachandharTN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=687549ed-7610-4bd8-ba30-854c99868cc1@gmail.com \
    --to=vivek.balachandhar@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®