From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C6F3A1698 for ; Wed, 8 Apr 2026 08:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775636997; cv=none; b=hfoONRMoSLC+T99vbag0ZlXRG8qNZUpo/w8t6lr9iTWdXyDUKsFcF/ASUZcNlAQEjrNP8tgDnZ7SF3GxwGIAv1zX0bkoGSU/L2UBSrscer1LX9q6QGs6O66+Xf2Vl5UYBu4UPwY319hEerQL40NWUpCq/EC71HfUleaZIQ2HY8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775636997; c=relaxed/simple; bh=/N9nDgGBUx2xNQj/8J/V+x1gepv5/QyqrTKMRR9IgJU=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=MiQpZzrOy+2iIJaJrTDhMJ8d8Z9Xelub8MpsiZbeKdIi3nw5HxiA7CmyKFfX1RL7VaSgYQeY+eyXc1kzmC35RLyFsK/ioTKPXPqGe9Z+YVpMtF+GUPZ2sDGlHdAdUIr2g5nXWhx8O7ePOFsUDTbhVYYq+YT3v171C7zttFn7VaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F1HDNG3Y; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F1HDNG3Y" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b2503753efso48557315ad.0 for ; Wed, 08 Apr 2026 01:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775636996; x=1776241796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=D3GLS/fnV1kV6HHNA7BZp2uu/52HjF+3WXvNfbBxqW4=; b=F1HDNG3YLIkSjVat6tNy5BaEAgBk8aymxNBIj2jT7UWQ5lZZW1xKS7HfFk9UOLkezc kKixG0V5UQVDSpsdDT4C3k82jirEoPNI2ayvQiKOjG3Quk3OVw+2HcwyPDBQvxcMcAMe 6a0uHLQA03B/4z1VMST3JlqsL8TB7cFVMImJmV/Y4yEsZaxaPkvtsmMEFwFv6axexMpe JlQTVAoRgX3sZuV9STX0GgHJ4SURJaHb5rBQb1yhRe3ALXl5D6X8c+Q/Zgbo/J29+dnX KDinfXaaIt1exHe9DK0woO8XkUgbkhKaR1rqqjtnG54+qEMKOKhRvZxFckfsV9XizgvB mGoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775636996; x=1776241796; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D3GLS/fnV1kV6HHNA7BZp2uu/52HjF+3WXvNfbBxqW4=; b=AaU0a+4aZ9L9z6RgJ0poS8IokQ926MT/0RJEAcmLkWffquRgXJPgTkOrQV08+KQ/Rr l2cUFvMI7lLN62Kj9w4jC8CAsQQ/osqJK6xc0BdLu0aNkMikxcn/u69bcEDAdbQ9GvIL FWnCoNNqzgsdbWkzT5QCtB1XkX8+S085bxwsDOIAhDOTTxNXazzasB6PSkZIix6rNgYi ef2tUyaDihMHchBAI9uS4F1uTEzIf68Agpjy6dW+dCKpEOTOPK5unycMYPNlQ4CtVBh+ x/7kna3VJVPXLdGN04tez+b4N1CQRXpzAVHnJExXud/gN+xunyhkmXu6AQ8N88AQU0gm 67zw== X-Forwarded-Encrypted: i=1; AJvYcCUdYWBMfeJ5TWxN9c3+hHz+HvhZnXgqz7mWnASHLViwJU3cbtW4TuazHIGXztOzkcyah9ddN2dR/NdcgkI=@vger.kernel.org X-Gm-Message-State: AOJu0YyaE3Sv9TgM8Cab+h7bGp1o9Rz4nTVb43l6lbNPLN8ngVJLIxtJ S9vRwm+t7fAbS/oS5kseWcMPNgY52Os/WsinTWFeuo9W0znBWcwRz7U1 X-Gm-Gg: AeBDies+CCIt2IDSAERubAh3kgOIDMHmsl4Mjm+KHm24bHgafdnsV+j4LxJLgf+AoVL KIeveGLvUAiWFEX3LB3ZCNzOXjCL0xztCc4gs8k4mJyGjstx7lTfMxPZ0PYZmNwAw4pezv/jfgQ DxZrgu41dCEE8Na+XGmjsoyQNIeWSyMVRzx8xylqi4ZAGq7oacidtbpIESiE71Tqxl3CtVh4CPW 5h6k8Uf/mI3P+AlVijJ9rzB+aF1/OKy4eoTrSl1X8r8GQnKLjqokswbCZQBfFmpIZ+1HXdQ86f5 IMkmJyKTfcs8MPYDaaqrYNZ+9BmKxzdXLC/pdwJ6osglNzdONN9ipy5lJzfX5KV30AZ0kfp9FH/ ARlsSX3LXB/fft4oQy2XBXDJ7rwABnGQi4hF59mQOW9zAF2apGVO997Dg1N2/RRHzACYwPxXRIH 1IVpAgFJJk29AT1iad0DjaqLl5IcOh0/Ci1+RELPcP1/PrlN8= X-Received: by 2002:a17:903:3205:b0:2b2:4eec:9806 with SMTP id d9443c01a7336-2b28182ca4cmr238395465ad.8.1775636995535; Wed, 08 Apr 2026 01:29:55 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ac07:a748:addf:cbb4:8118:a551]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27472d1a2sm209392515ad.7.2026.04.08.01.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 01:29:55 -0700 (PDT) Date: Wed, 08 Apr 2026 13:52:08 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v5_3/5=5D_iio=3A_ssp=5Fsensors=3A_fa?= =?US-ASCII?Q?ctor_out_pending_list_add/remove_helpers?= User-Agent: Thunderbird for Android In-Reply-To: References: <20260406080852.2727453-1-sanjayembedded@gmail.com> <20260406080852.2727453-4-sanjayembedded@gmail.com> Message-ID: <6878A01C-C546-4719-86F5-F1571B4A198C@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 7 April 2026 1:34:41=E2=80=AFam IST, Andy Shevchenko wrote: >On Mon, Apr 06, 2026 at 01:38:50PM +0530, Sanjay Chitroda wrote: > >> The SSP SPI transfer path manipulates the pending message list in >> multiple places, each time open-coding the same locking and list >> operations=2E >>=20 >> Re-factor the pending list add and delete logic into small helper >> functions to avoid duplication and simplify transfer flow to follow=2E >>=20 >> No functional change intended=2E > >Suggested-by? > Requesting your input on which email is recommended to tag with your name= =2E Shall I use intel=2Ecom ? >=2E=2E=2E > >> +static inline void ssp_pending_add(struct ssp_data *data, >> + struct ssp_msg *msg) > >Make it rather: > >static inline void ssp_pending_add(struct ssp_data *data, struct ssp_msg = *msg) >{ > if (msg->length) > return; > =2E=2E=2E >} It should be not, right ? { if (!msg->length) return; =2E=2E=2E } const bool use_no_irq =3D msg->length =3D=3D 0; if (!use_no_irq) {add/del} If message length is 0 then no interrupt > >> +{ >> + mutex_lock(&data->pending_lock); >> + list_add_tail(&msg->list, &data->pending_list); >> + mutex_unlock(&data->pending_lock); >> +} >> + >> +static inline void ssp_pending_del(struct ssp_data *data, >> + struct ssp_msg *msg) >> +{ >> + mutex_lock(&data->pending_lock); >> + list_del(&msg->list); >> + mutex_unlock(&data->pending_lock); >> +} > >(in the same manner) > >=2E=2E=2E > >> - if (!use_no_irq) { >> - mutex_lock(&data->pending_lock); >> - list_add_tail(&msg->list, &data->pending_list); >> - mutex_unlock(&data->pending_lock); >> - } >> + if (!use_no_irq) >> + ssp_pending_add(data, msg); > >=2E=2E=2Eand then it will become > > ssp_pending_add(data, msg); > >> status =3D ssp_check_lines(data, true); >> if (status < 0) { >> - if (!use_no_irq) { >> - mutex_lock(&data->pending_lock); >> - list_del(&msg->list); >> - mutex_unlock(&data->pending_lock); >> - } >> + if (!use_no_irq) >> + ssp_pending_del(data, msg); >> goto _error_locked; >> } > >=2E=2E=2E > >> if (wait_for_completion_timeout(done, >> msecs_to_jiffies(timeout)) =3D=3D >> 0) { >> - mutex_lock(&data->pending_lock); >> - list_del(&msg->list); >> - mutex_unlock(&data->pending_lock); >> + ssp_pending_del(data, msg); >> =20 >> data->timeout_cnt++; >> return -ETIMEDOUT; > >Also rewrite this to follow the style (missing {}, better indentation): > > if (msg->length && done && > !wait_for_completion_timeout(done, msecs_to_jiffies(timeout))) { > ssp_pending_del(data, msg); > > data->timeout_cnt++; > return -ETIMEDOUT; > } > >And kill that use_no_urq altogether=2E Move the comment rather to a helpe= r(s)=2E Understood, will follow and drop this variable in next series=2E >