mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <tangmin@cdjrlc.com>, <anton@tuxera.com>
Cc: <linux-ntfs-dev@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] treewide: Unneeded semicolon
Date: Sat, 13 Aug 2022 16:13:59 +0000	[thread overview]
Message-ID: <687da07e-ad0a-dd47-5f54-27f55e2d9b96@microchip.com> (raw)
In-Reply-To: <20220813160723.5769-1-tangmin@cdjrlc.com>

On 13/08/2022 17:07, min tang wrote:
> [PATCH] treewide: Unneeded semicolon

Hey, you might want to check whatever script you're using to
generate these commits. A single line change in a file isn't
exactly treewide...

> There is no semicolon after '}' in line 1615.

This doesn't really make much sense, maybe:
"Remove uneeded semicolon after..."
Thanks,
Conor.

> 
> Signed-off-by: min tang <tangmin@cdjrlc.com>
> ---
>  fs/ntfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
> index 5ae8de09b271..d663b49df84e 100644
> --- a/fs/ntfs/super.c
> +++ b/fs/ntfs/super.c
> @@ -1612,7 +1612,7 @@ static bool load_and_init_attrdef(ntfs_volume *vol)
>  		memcpy((u8*)vol->attrdef + (index++ << PAGE_SHIFT),
>  				page_address(page), size);
>  		ntfs_unmap_page(page);
> -	};
> +	}
>  	if (size == PAGE_SIZE) {
>  		size = i_size & ~PAGE_MASK;
>  		if (size)

  reply	other threads:[~2022-08-13 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13 16:07 min tang
2022-08-13 16:13 ` Conor.Dooley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-13 15:29 min tang
2022-07-19  4:36 [PATCH] treewide:Unneeded semicolon Xin Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=687da07e-ad0a-dd47-5f54-27f55e2d9b96@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=anton@tuxera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=tangmin@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®